Title: fix(mothership): retry a send that failed while the browser stayed online by waleedlatif1 · Pull Request #8726 · simstudioai/sim · GitHub
Open Graph Title: fix(mothership): retry a send that failed while the browser stayed online by waleedlatif1 · Pull Request #8726 · simstudioai/sim
X Title: fix(mothership): retry a send that failed while the browser stayed online by waleedlatif1 · Pull Request #8726 · simstudioai/sim
Description: Summary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interface change, a reset connection), that event never came: the message sat in the queue as a plain "Queued" row, and every follow-up queued behind it, until a reload The hold now applies only when the browser reports itself offline at the failure. Otherwise the send is retried under the same id on the busy-refusal backoff (1 s growing to 30 s), which the server deduplicates Only the POST itself failing at the network layer is retried on a timer. Any other error before the response (preparing the request, reading desktop capabilities) is held as before, since it would fail the same way each time Before the queue resends a message that may have been admitted (an automatic retry, or a send released when the browser comes back online), it reads the chat's history fresh and drops the entry if the history already shows that id. If the history can't be read, the message waits and backs off. This stops a resend after a long outage, past the server's claim on the id, from running the turn twice The send no longer needs to count online events. A browser that is offline when the send fails always fires one later busyRetries is renamed sendRetries, since it now paces both kinds of retry Type of Change Bug fix Testing New DOM tests: a send that fails while the browser stays online goes out with a follow-up behind it, and repeated failures back off. Both failed on staging DOM tests: a send retried while online stays uneditable under one id, on both the direct-send and queued-dispatch paths; a failure before the POST is held, not retried; a resend the chat history shows was accepted is dropped, whether it waited online or offline; a message that may have been admitted is not resent while its chat history is unreadable. The last three fail when their part of the change is reverted The fake network in these tests now ties navigator.onLine to its offline state. The existing tests made fetch fail while jsdom stayed online and then sent online themselves, so they never covered a failure that no online event follows Headless Chrome against a full local stack: a reset POST with the browser online now goes out about 1 s later, where on staging it stayed queued. Going offline and back during the POST still sends it Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interf...
X Description: Summary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interf...
Opengraph URL: https://github.com/simstudioai/sim/pull/8726
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7e1bc705-8af3-d280-eba9-dbea1093f5c4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC5A:FBC06:BB468D:102741A:6AFB5684 |
| html-safe-nonce | b11aad5830207c4ecd29e8e8e6f7f766a2b0668ef0eec37604ec181d72f633bf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzVBOkZCQzA2OkJCNDY4RDoxMDI3NDFBOjZBRkI1Njg0IiwidmlzaXRvcl9pZCI6IjQzNzU5MDQ4NTU5NTAxODg4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ba0de5d644a7822700e53d903f15b384e221b4eefc2a1012b4ecd3ebb350e0a0 |
| hovercard-subject-tag | pull_request:4768456213 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8726/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interf... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width