René's URL Explorer Experiment


Title: fix(mothership): retry a send that failed while the browser stayed online by waleedlatif1 · Pull Request #8726 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): retry a send that failed while the browser stayed online by waleedlatif1 · Pull Request #8726 · simstudioai/sim

X Title: fix(mothership): retry a send that failed while the browser stayed online by waleedlatif1 · Pull Request #8726 · simstudioai/sim

Description: Summary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interface change, a reset connection), that event never came: the message sat in the queue as a plain "Queued" row, and every follow-up queued behind it, until a reload The hold now applies only when the browser reports itself offline at the failure. Otherwise the send is retried under the same id on the busy-refusal backoff (1 s growing to 30 s), which the server deduplicates Only the POST itself failing at the network layer is retried on a timer. Any other error before the response (preparing the request, reading desktop capabilities) is held as before, since it would fail the same way each time Before the queue resends a message that may have been admitted (an automatic retry, or a send released when the browser comes back online), it reads the chat's history fresh and drops the entry if the history already shows that id. If the history can't be read, the message waits and backs off. This stops a resend after a long outage, past the server's claim on the id, from running the turn twice The send no longer needs to count online events. A browser that is offline when the send fails always fires one later busyRetries is renamed sendRetries, since it now paces both kinds of retry Type of Change Bug fix Testing New DOM tests: a send that fails while the browser stays online goes out with a follow-up behind it, and repeated failures back off. Both failed on staging DOM tests: a send retried while online stays uneditable under one id, on both the direct-send and queued-dispatch paths; a failure before the POST is held, not retried; a resend the chat history shows was accepted is dropped, whether it waited online or offline; a message that may have been admitted is not resent while its chat history is unreadable. The last three fail when their part of the change is reverted The fake network in these tests now ties navigator.onLine to its offline state. The existing tests made fetch fail while jsdom stayed online and then sent online themselves, so they never covered a failure that no online event follows Headless Chrome against a full local stack: a reset POST with the browser online now goes out about 1 s later, where on staging it stayed queued. Going offline and back during the POST still sends it Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interf...

X Description: Summary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interf...

Opengraph URL: https://github.com/simstudioai/sim/pull/8726

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7e1bc705-8af3-d280-eba9-dbea1093f5c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC5A:FBC06:BB468D:102741A:6AFB5684
html-safe-nonceb11aad5830207c4ecd29e8e8e6f7f766a2b0668ef0eec37604ec181d72f633bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzVBOkZCQzA2OkJCNDY4RDoxMDI3NDFBOjZBRkI1Njg0IiwidmlzaXRvcl9pZCI6IjQzNzU5MDQ4NTU5NTAxODg4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacba0de5d644a7822700e53d903f15b384e221b4eefc2a1012b4ecd3ebb350e0a0
hovercard-subject-tagpull_request:4768456213
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8726/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A chat send whose request failed at the network layer was held until the browser fired online. When the connection dropped while the browser stayed online (ERR_NETWORK_CHANGED on an interf...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8726/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8726%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8726%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8726/files
Reloadhttps://github.com/simstudioai/sim/pull/8726/files
Reloadhttps://github.com/simstudioai/sim/pull/8726/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chat-send-network-changedhttps://github.com/simstudioai/sim/tree/fix/chat-send-network-changed
Conversation 16 https://github.com/simstudioai/sim/pull/8726
Commits 3 https://github.com/simstudioai/sim/pull/8726/commits
Checks 32 https://github.com/simstudioai/sim/pull/8726/checks
Files changed https://github.com/simstudioai/sim/pull/8726/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8726/files
fix(mothership): retry a send that failed while the browser stayed online https://github.com/simstudioai/sim/pull/8726/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8726/files
9ee900f fix(mothership): retry a send that failed while the browser stayed on… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8726/commits/9ee900fc4d9427e4d0751e0c763fff62a2198d4e
2b76b5b fix(mothership): retry only network failures on a timer, and drop a r… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8726/commits/2b76b5bd225b810f363f49405da318dbf479e088
9ca5fc7 fix(mothership): check every uncertain resend against the chat histor… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8726/commits/9ca5fc75bc271d62d081be713f259a5baffe8410
Clear filters https://github.com/simstudioai/sim/pull/8726/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8726/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8726/files
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/8726/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/8726/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
store.ts https://github.com/simstudioai/sim/pull/8726/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
types.ts https://github.com/simstudioai/sim/pull/8726/files#diff-66995a79415f1ef4665bc2e86e1d1a9d3b0d0babf5f62114dc92f09880c1d1ae
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.dom.test.tsxhttps://github.com/simstudioai/sim/pull/8726/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
View file https://github.com/simstudioai/sim/blob/9ca5fc75bc271d62d081be713f259a5baffe8410/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8726/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8726/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8726/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8726/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8726/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
Please reload this pagehttps://github.com/simstudioai/sim/pull/8726/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8726/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.