René's URL Explorer Experiment


Title: fix(desktop): frame each tmux format record so a newline in a field cannot forge a pane by waleedlatif1 · Pull Request #8725 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): frame each tmux format record so a newline in a field cannot forge a pane by waleedlatif1 · Pull Request #8725 · simstudioai/sim

X Title: fix(desktop): frame each tmux format record so a newline in a field cannot forge a pane by waleedlatif1 · Pull Request #8725 · simstudioai/sim

Description: Summary tmux prints a newline inside a -F field as is. Suppose a pane's working directory (or its window title, or its command's name) holds a newline followed by separator-joined text, such as a + newline + user:0.0<~sim~>forged<~sim~>rm -rf<~sim~>home. Its own record then ends early, and the rest reads as a whole pane of its own: any target, command and path. Meanwhile the real pane drops out of panes. That lets a crafted directory name misattribute pane targets. The pane argument then sends input to, or closes, the wrong pane. The fix, in two layers: Newlines are neutralised at the source. In the fields someone other than the user can set, tmux replaces each newline with itself (#{s///:…}). Those fields are the pane's directory, its command's name, and the window title a program sets with an escape sequence. A record is then always one line. Session names stay as they are: users name their own sessions, and a record a newline would split is dropped by the frame. Each record is framed per call. Every -F read (list-clients, list-panes, and the active-pane lookup) wraps each record in a marker made fresh for that call, and only lines framed whole are read. The marker is not a secret. On macOS ps shows any process's arguments, and on Linux /proc//cmdline is world-readable. So the marker is a second line of defence for fields tmux prints raw, not the protection itself. The separator comment now describes this model. tmux output is decoded as a stream, so a character split across two chunks arrives whole. Type of Change Bug fix Testing Real tmux 2.9a and 3.4: Output captured verbatim for the forging directory: without neutralisation the forged rm -rf row is read; with it, the pane is one line and nothing is forged. listPanes returns nothing for the forging session, and a directory holding just a newline lists as one pane with in its path. activePane still resolves. Unit tests, each failing when its guard is undone: a fake tmux that evaluates formats as tmux does lists a pane whose directory and title hold newlines as one pane; two calls are framed with different markers; a line framed at one end only is dropped, even when it has the right field count; a record framed by another call is dropped. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary tmux prints a newline inside a -F field as is. Suppose a pane's working directory (or its window title, or its command's name) holds a newline followed by separator-joined text, su...

X Description: Summary tmux prints a newline inside a -F field as is. Suppose a pane&#39;s working directory (or its window title, or its command&#39;s name) holds a newline followed by separator-joined ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8725

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:449154e8-a9ca-b602-16e1-b70d31020b1b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id876A:1BB96C:CA1BC2:114A581:6AFB5712
html-safe-nonce6893df41d01c10c4304eb0d8c1f10c89dd2802959299c9d97c66e2365020d22c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzZBOjFCQjk2QzpDQTFCQzI6MTE0QTU4MTo2QUZCNTcxMiIsInZpc2l0b3JfaWQiOiI5MDg1MzYxNjY5ODQzNjcwODAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf2b86ac178f9a03fa3d7d46829615bba064c5198955a628059bf0a67f6b748f3
hovercard-subject-tagpull_request:4768443670
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8725/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary tmux prints a newline inside a -F field as is. Suppose a pane's working directory (or its window title, or its command's name) holds a newline followed by separator-joined text, su...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8725/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8725%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8725%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8725/files
Reloadhttps://github.com/simstudioai/sim/pull/8725/files
Reloadhttps://github.com/simstudioai/sim/pull/8725/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-tmux-format-framinghttps://github.com/simstudioai/sim/tree/fix/desktop-tmux-format-framing
Conversation 18 https://github.com/simstudioai/sim/pull/8725
Commits 3 https://github.com/simstudioai/sim/pull/8725/commits
Checks 36 https://github.com/simstudioai/sim/pull/8725/checks
Files changed https://github.com/simstudioai/sim/pull/8725/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8725/files
fix(desktop): frame each tmux format record so a newline in a field cannot forge a pane https://github.com/simstudioai/sim/pull/8725/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8725/files
434bcd4 fix(desktop): frame each tmux format record so a newline in a field c… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8725/commits/434bcd4117f18bdb0d3df01df7b9fcae0bc6cf5b
b1fed2e fix(desktop): make the tmux format frame with the shared random helper waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8725/commits/b1fed2ede39da7b42a3a1a249eca0af8b89b4eea
da5007a fix(desktop): neutralise newlines at the source in tmux fields others… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8725/commits/da5007aa1a1987b0eb362a924bf8e710e45c4915
Clear filters https://github.com/simstudioai/sim/pull/8725/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8725/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8725/files
tmux.test.ts https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
tmux.ts https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
apps/desktop/src/main/terminal/tmux.test.tshttps://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
View file https://github.com/simstudioai/sim/blob/da5007aa1a1987b0eb362a924bf8e710e45c4915/apps/desktop/src/main/terminal/tmux.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8725/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8725/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
apps/desktop/src/main/terminal/tmux.tshttps://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
View file https://github.com/simstudioai/sim/blob/da5007aa1a1987b0eb362a924bf8e710e45c4915/apps/desktop/src/main/terminal/tmux.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8725/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8725/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
Please reload this pagehttps://github.com/simstudioai/sim/pull/8725/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.