Title: fix(ci): tidy stop-session.sh scans, listings and arguments by waleedlatif1 · Pull Request #8724 · simstudioai/sim · GitHub
Open Graph Title: fix(ci): tidy stop-session.sh scans, listings and arguments by waleedlatif1 · Pull Request #8724 · simstudioai/sim
X Title: fix(ci): tidy stop-session.sh scans, listings and arguments by waleedlatif1 · Pull Request #8724 · simstudioai/sim
Description: Summary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same scan has rows to list under it. The deadline check also requires two empty scans 0.1s apart, like the polling loop. An empty tag or a non-numeric leader is refused (exit 2) instead of matching E2E_APP=. The expected-flush label sits in its own column, so rows stay aligned with the ps header. /proc reads for processes that exit mid-scan no longer print "No such file or directory". Type of Change Bug fix Testing Container checks in node:22-bookworm: 14 of 14 pass. That covers the earlier literal-match, self-exclusion and label checks, plus these new ones: PID columns line up under the header; the flush is listed once; an empty tag or a missing leader exits 2 and stops nothing; the first SIGTERM names each PID once. The Linux session checks still pass. A member that ignores SIGTERM and a leader that ignores SIGTERM are each SIGKILLed at about 10s, and nothing is left running. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same scan has...
X Description: Summary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same ...
Opengraph URL: https://github.com/simstudioai/sim/pull/8724
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:189ea9fa-b98b-290d-00e3-38b28019b919 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E0F6:1BB36A:EC2A08:14309A3:6AFB5DE6 |
| html-safe-nonce | 439efdc3fd19708dd516e3aa595177c16f3b1b7dfeee20598c665e9c9e456a6b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEY2OjFCQjM2QTpFQzJBMDg6MTQzMDlBMzo2QUZCNURFNiIsInZpc2l0b3JfaWQiOiI5MTM5NzU2NzgyMTA3NDUwODU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ffbf80ad1bec620d6f66c0ce3bb984eb50e0b259134afe10b69d113176d9fb0c |
| hovercard-subject-tag | pull_request:4768270051 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8724/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same scan has... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width