René's URL Explorer Experiment


Title: fix(ci): tidy stop-session.sh scans, listings and arguments by waleedlatif1 · Pull Request #8724 · simstudioai/sim · GitHub

Open Graph Title: fix(ci): tidy stop-session.sh scans, listings and arguments by waleedlatif1 · Pull Request #8724 · simstudioai/sim

X Title: fix(ci): tidy stop-session.sh scans, listings and arguments by waleedlatif1 · Pull Request #8724 · simstudioai/sim

Description: Summary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same scan has rows to list under it. The deadline check also requires two empty scans 0.1s apart, like the polling loop. An empty tag or a non-numeric leader is refused (exit 2) instead of matching E2E_APP=. The expected-flush label sits in its own column, so rows stay aligned with the ps header. /proc reads for processes that exit mid-scan no longer print "No such file or directory". Type of Change Bug fix Testing Container checks in node:22-bookworm: 14 of 14 pass. That covers the earlier literal-match, self-exclusion and label checks, plus these new ones: PID columns line up under the header; the flush is listed once; an empty tag or a missing leader exits 2 and stops nothing; the first SIGTERM names each PID once. The Linux session checks still pass. A member that ignores SIGTERM and a leader that ignores SIGTERM are each SIGKILLed at about 10s, and nothing is left running. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same scan has...

X Description: Summary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8724

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:189ea9fa-b98b-290d-00e3-38b28019b919
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0F6:1BB36A:EC2A08:14309A3:6AFB5DE6
html-safe-nonce439efdc3fd19708dd516e3aa595177c16f3b1b7dfeee20598c665e9c9e456a6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEY2OjFCQjM2QTpFQzJBMDg6MTQzMDlBMzo2QUZCNURFNiIsInZpc2l0b3JfaWQiOiI5MTM5NzU2NzgyMTA3NDUwODU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacffbf80ad1bec620d6f66c0ce3bb984eb50e0b259134afe10b69d113176d9fb0c
hovercard-subject-tagpull_request:4768270051
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8724/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary PIDs from the session scan and the tag scan are deduped. ps pads PIDs with spaces, so sort -u missed repeats. The "outlived its leader" heading prints only when the same scan has...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8724/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8724%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8724%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8724/files
Reloadhttps://github.com/simstudioai/sim/pull/8724/files
Reloadhttps://github.com/simstudioai/sim/pull/8724/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/stop-session-nitshttps://github.com/simstudioai/sim/tree/fix/stop-session-nits
Conversation 5 https://github.com/simstudioai/sim/pull/8724
Commits 1 https://github.com/simstudioai/sim/pull/8724/commits
Checks 32 https://github.com/simstudioai/sim/pull/8724/checks
Files changed https://github.com/simstudioai/sim/pull/8724/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8724/files
fix(ci): tidy stop-session.sh scans, listings and arguments https://github.com/simstudioai/sim/pull/8724/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8724/files
a3b7861 fix(ci): tidy stop-session.sh scans, listings and arguments waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8724/commits/a3b78614ac26f7a4b21d27a48f56ad06d797d4a7
Clear filters https://github.com/simstudioai/sim/pull/8724/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8724/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8724/files
.github/scripts/stop-session.shhttps://github.com/simstudioai/sim/pull/8724/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
View file https://github.com/simstudioai/sim/blob/a3b78614ac26f7a4b21d27a48f56ad06d797d4a7/.github/scripts/stop-session.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8724/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8724/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8724/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8724/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8724/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8724/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8724/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
Please reload this pagehttps://github.com/simstudioai/sim/pull/8724/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.