René's URL Explorer Experiment


Title: fix(mothership): keep any queued send the server may already hold from being edited by waleedlatif1 · Pull Request #8723 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): keep any queued send the server may already hold from being edited by waleedlatif1 · Pull Request #8723 · simstudioai/sim

X Title: fix(mothership): keep any queued send the server may already hold from being edited by waleedlatif1 · Pull Request #8723 · simstudioai/sim

Description: Summary Follow-up to #8717. No queued send the server may already hold can be edited. #8717 blocked edits only for a first message the unmount queued itself. Other entries carrying an earlier attempt's id stayed editable, and an edit dropped that id, so the edited text could go out as a second message: a send another surface withdrew, handed over through the send event or the stored handoff, that lands in a busy chat's queue; a queued follow-up re-queued after its dispatch got no answer. One place enforces it. The queue store marks every message written with a resumeUserMessageId as admissionUnknown, unless the writer says the server is known not to have it. Queues restored from the session go through the same guard, so entries saved before this change are covered too. The existing edit guards (store, hook, Edit button) then apply. Only the server refusing that id clears it. A busy 409 or a superseded 409 means the server doesn't have the id. It checks the send's id before it takes the chat lock, so it answers a retry of an admitted id as a duplicate, never as busy. A message held this way becomes editable again once the server refuses it. A Send-now whose Stop never settles keeps the earlier uncertainty. Nothing was sent, which proves nothing about the earlier attempt the message resumes, so the message stays uneditable. Moves a test doc comment back above its own test. Type of Change Bug fix Testing New DOM tests, each failing before its fix: does not let a withdrawn send handed to a busy chat be edited does not let a queued follow-up be edited after its send got no answer lets a held message be edited again once the server refuses it as busy keeps a resumed message uneditable when its Send-now Stop does not settle Store tests: treats any message resuming an earlier attempt as possibly sent, unless told otherwise, and a rehydration test (store.dom.test.ts) for queues saved before the guard. The existing held-Stop edit test now carries admissionUnknown: false: that entry was never sent and resumed no earlier attempt, so the server can't have it. The full gate and integration tests ran on the CI runner. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #8717. No queued send the server may already hold can be edited. #8717 blocked edits only for a first message the unmount queued itself. Other entries carrying an earlier atte...

X Description: Summary Follow-up to #8717. No queued send the server may already hold can be edited. #8717 blocked edits only for a first message the unmount queued itself. Other entries carrying an earlier atte...

Opengraph URL: https://github.com/simstudioai/sim/pull/8723

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b53046f6-95b7-a233-0fdc-54ec371d99e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id821C:1CB508:BDB608:10D2E23:6AFB5DCB
html-safe-nonce828d3de074a5c0a4b92e580f56ceea195f5245d0c9e95e7ae41b92f0e56657a7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjFDOjFDQjUwODpCREI2MDg6MTBEMkUyMzo2QUZCNURDQiIsInZpc2l0b3JfaWQiOiI0NzM4NzE1ODQ5ODY5NDUwNjk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace8215f8a41d7b7175e319b044efdbebae97f2a6b81f0c03722f4b8da0aab5b95
hovercard-subject-tagpull_request:4768067366
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8723/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #8717. No queued send the server may already hold can be edited. #8717 blocked edits only for a first message the unmount queued itself. Other entries carrying an earlier atte...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8723/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8723%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8723%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8723/files
Reloadhttps://github.com/simstudioai/sim/pull/8723/files
Reloadhttps://github.com/simstudioai/sim/pull/8723/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mothership-resumed-send-edithttps://github.com/simstudioai/sim/tree/fix/mothership-resumed-send-edit
Conversation 15 https://github.com/simstudioai/sim/pull/8723
Commits 2 https://github.com/simstudioai/sim/pull/8723/commits
Checks 33 https://github.com/simstudioai/sim/pull/8723/checks
Files changed https://github.com/simstudioai/sim/pull/8723/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8723/files
fix(mothership): keep any queued send the server may already hold from being edited https://github.com/simstudioai/sim/pull/8723/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8723/files
80ee657 fix(mothership): keep any queued send the server may already hold fro… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8723/commits/80ee657d7571d2c3ec545ac1a8ed904aaa262c41
a3fb22f fix(mothership): keep earlier-attempt uncertainty through a failed St… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8723/commits/a3fb22fd8889d140e58998dfe207a4c3db424e74
Clear filters https://github.com/simstudioai/sim/pull/8723/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8723/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8723/files
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/8723/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
types.ts https://github.com/simstudioai/sim/pull/8723/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
store.dom.test.ts https://github.com/simstudioai/sim/pull/8723/files#diff-6b254137160c4dbb5b0b26e82a5e6b07a78bfcfe4255e2dbd88cd9ba952a2cb1
store.test.ts https://github.com/simstudioai/sim/pull/8723/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
store.ts https://github.com/simstudioai/sim/pull/8723/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.dom.test.tsxhttps://github.com/simstudioai/sim/pull/8723/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
View file https://github.com/simstudioai/sim/blob/a3fb22fd8889d140e58998dfe207a4c3db424e74/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8723/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8723/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8723/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8723/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8723/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.tshttps://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
View file https://github.com/simstudioai/sim/blob/a3fb22fd8889d140e58998dfe207a4c3db424e74/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8723/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8723/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
apps/sim/app/workspace/[workspaceId]/home/types.tshttps://github.com/simstudioai/sim/pull/8723/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
View file https://github.com/simstudioai/sim/blob/a3fb22fd8889d140e58998dfe207a4c3db424e74/apps/sim/app/workspace/%5BworkspaceId%5D/home/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8723/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8723/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
https://github.com/simstudioai/sim/pull/8723/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
apps/sim/stores/mothership-queue/store.dom.test.tshttps://github.com/simstudioai/sim/pull/8723/files#diff-6b254137160c4dbb5b0b26e82a5e6b07a78bfcfe4255e2dbd88cd9ba952a2cb1
View file https://github.com/simstudioai/sim/blob/a3fb22fd8889d140e58998dfe207a4c3db424e74/apps/sim/stores/mothership-queue/store.dom.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8723/{{ revealButtonHref }}
apps/sim/stores/mothership-queue/store.test.tshttps://github.com/simstudioai/sim/pull/8723/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
View file https://github.com/simstudioai/sim/blob/a3fb22fd8889d140e58998dfe207a4c3db424e74/apps/sim/stores/mothership-queue/store.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8723/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8723/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
https://github.com/simstudioai/sim/pull/8723/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
https://github.com/simstudioai/sim/pull/8723/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
Please reload this pagehttps://github.com/simstudioai/sim/pull/8723/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8723/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.