René's URL Explorer Experiment


Title: fix(ci): match E2E app tags literally, make them unique per run, and never stop the caller by waleedlatif1 · Pull Request #8721 · simstudioai/sim · GitHub

Open Graph Title: fix(ci): match E2E app tags literally, make them unique per run, and never stop the caller by waleedlatif1 · Pull Request #8721 · simstudioai/sim

X Title: fix(ci): match E2E app tags literally, make them unique per run, and never stop the caller by waleedlatif1 · Pull Request #8721 · simstudioai/sim

Description: Summary stop-session.sh matches E2E_APP= as a fixed string (grep -Flzx). A tag like s.im, or a prefix like sc, no longer matches another app's E2E_APP=scim. Each HTTP E2E app's tag is now ---, so it is unique among the runner user's processes. The script never signals itself, its ancestors, or its own subshells, even when the caller exported the same tag. Before, it SIGTERMed itself and its parent shell (rc=143). It reads /proc//stat without forking, so scans stay cheap. A surviving Next telemetry flush is labelled "(expected telemetry flush)", so an unexpected escapee stands out. Type of Change Bug fix Testing Ran the checks in a node:22-bookworm container, and all passed: a s.im tag and a sc prefix tag each stop only their own app and leave E2E_APP=scim running; with the caller exporting the same tag, the caller survives and the script exits 0, while the app and a tagged escapee in its own session are both stopped; the flush label is printed. On Linux, every earlier session check still passes: a member in its own process group is stopped; a member that ignores SIGTERM is SIGKILLed at 10s; a process spawned during shutdown is stopped; a detached tagged writer is stopped; a leader that ignores SIGTERM is SIGKILLed at 10s. Stop-then-wipe loop on Linux: 6 of 6 rounds had no flush left and nothing written under .next afterwards. Full HTTP E2E app sequence on Linux (8 cores, cold .next per app): 3 of 3 passed. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary stop-session.sh matches E2E_APP=<tag> as a fixed string (grep -Flzx). A tag like s.im, or a prefix like sc, no longer matches another app's E2E_APP=scim. Each HTTP E2E app's ...

X Description: Summary stop-session.sh matches E2E_APP=&lt;tag&gt; as a fixed string (grep -Flzx). A tag like s.im, or a prefix like sc, no longer matches another app&#39;s E2E_APP=scim. Each HTTP E2...

Opengraph URL: https://github.com/simstudioai/sim/pull/8721

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:64600a7d-e467-abb4-026c-ff75d891f26a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADC4:29D5DB:E40FE1:138C274:6AFB5EA1
html-safe-nonce580a56d01c161e4d91b1d365c1480ae3fb519c93b35bfb7e5aebe24f6873a0ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREM0OjI5RDVEQjpFNDBGRTE6MTM4QzI3NDo2QUZCNUVBMSIsInZpc2l0b3JfaWQiOiI0OTI0ODA3NTc4NjkwMjE1NTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac31c9c51ebf2ae0fe0ad899bef0a11a5321c1fab3ab75906c3c15ae8134ac16f2
hovercard-subject-tagpull_request:4767908169
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8721/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary stop-session.sh matches E2E_APP=<tag> as a fixed string (grep -Flzx). A tag like s.im, or a prefix like sc, no longer matches another app's E2E_APP=scim. Each HTTP E2E app's ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8721/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8721%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8721%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8721/files
Reloadhttps://github.com/simstudioai/sim/pull/8721/files
Reloadhttps://github.com/simstudioai/sim/pull/8721/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/stop-session-hardeninghttps://github.com/simstudioai/sim/tree/fix/stop-session-hardening
Conversation 12 https://github.com/simstudioai/sim/pull/8721
Commits 2 https://github.com/simstudioai/sim/pull/8721/commits
Checks 32 https://github.com/simstudioai/sim/pull/8721/checks
Files changed https://github.com/simstudioai/sim/pull/8721/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8721/files
fix(ci): match E2E app tags literally, make them unique per run, and never stop the caller https://github.com/simstudioai/sim/pull/8721/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8721/files
32fe492 fix(ci): match E2E app tags literally, make them unique per run, and … waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8721/commits/32fe4924c6facac9a517701c3e83181a25037fd2
c91205a fix(ci): never spare an app process whose ancestry changes mid-scan, … waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8721/commits/c91205aa6fe817930ebde9c191f0706d54c52f91
Clear filters https://github.com/simstudioai/sim/pull/8721/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8721/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8721/files
stop-session.sh https://github.com/simstudioai/sim/pull/8721/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
test-build.yml https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
.github/scripts/stop-session.shhttps://github.com/simstudioai/sim/pull/8721/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
View file https://github.com/simstudioai/sim/blob/c91205aa6fe817930ebde9c191f0706d54c52f91/.github/scripts/stop-session.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8721/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8721/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8721/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8721/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8721/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
https://github.com/simstudioai/sim/pull/8721/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
.github/workflows/test-build.ymlhttps://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
View file https://github.com/simstudioai/sim/blob/c91205aa6fe817930ebde9c191f0706d54c52f91/.github/workflows/test-build.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8721/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8721/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8721/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.