Title: fix(desktop): read tmux format output with a separator no tmux version escapes by waleedlatif1 · Pull Request #8720 · simstudioai/sim · GitHub
Open Graph Title: fix(desktop): read tmux format output with a separator no tmux version escapes by waleedlatif1 · Pull Request #8720 · simstudioai/sim
X Title: fix(desktop): read tmux format output with a separator no tmux version escapes by waleedlatif1 · Pull Request #8720 · simstudioai/sim
Description: Summary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four characters \037 and no line split. Effect on those versions: Sim never found the tmux client running in a terminal, so it treated that terminal as a plain shell, and the agent's runs were refused as busy. The panes operation came back empty. The separator is now the printable |~sim~|, which no tmux version escapes. A field that happens to contain it changes the line's field count, so that line is dropped rather than misread. Why not accept both forms tmux 3.3 and later also escape backslashes (\ prints as \\). So "split on the byte or on \037" could cut a field whose text holds a real \037. Telling the cases apart would mean decoding each version's escaping. A printable separator doesn't depend on escaping at all. Versions checked (real binaries) tmux 0x1f separator |~sim~| separator 2.9a raw verbatim 3.3a raw verbatim 3.4 (Ubuntu 24.04) escaped as \037 verbatim 3.5a escaped as \037 verbatim 3.6a raw verbatim 3.7c (current Homebrew) raw verbatim On real tmux 3.4, listPanes returned nothing with staging's code and the session's panes with this change. Autopsy The unit tests run against a fake tmux that printed format output unescaped, so this kind of bug could never fail them. The fake now escapes its output the way 3.4 and 3.5 do: backslashes doubled, control characters as octal escapes. The new attachment test goes through that fake. It fails with the old separator and passes with this one. It was found by a new Electron E2E against real tmux 3.4. That E2E follows in a separate PR. Type of Change Bug fix Testing Unit tests, red first with the old separator. Real tmux 2.9a, 3.3a, 3.4, 3.5a, 3.6a and 3.7c. Electron E2E with real tmux 3.4. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four ...
X Description: Summary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four ...
Opengraph URL: https://github.com/simstudioai/sim/pull/8720
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e5f2819c-7a26-6625-2b48-026bfb5e25af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D25C:267719:C2D593:10B2440:6AFB5679 |
| html-safe-nonce | b550c5f8b399e93340ec804641f313b93854dce817905683926aa7546fb7e3ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjVDOjI2NzcxOTpDMkQ1OTM6MTBCMjQ0MDo2QUZCNTY3OSIsInZpc2l0b3JfaWQiOiI3MDY0NDI2NDI4NjA2NjY2MzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9e31da4b959dc29420d5cfd72f7e2cab798dd5cd6bdfd34d18f48b163edb1f8b |
| hovercard-subject-tag | pull_request:4767388883 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8720/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width