René's URL Explorer Experiment


Title: fix(desktop): read tmux format output with a separator no tmux version escapes by waleedlatif1 · Pull Request #8720 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): read tmux format output with a separator no tmux version escapes by waleedlatif1 · Pull Request #8720 · simstudioai/sim

X Title: fix(desktop): read tmux format output with a separator no tmux version escapes by waleedlatif1 · Pull Request #8720 · simstudioai/sim

Description: Summary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four characters \037 and no line split. Effect on those versions: Sim never found the tmux client running in a terminal, so it treated that terminal as a plain shell, and the agent's runs were refused as busy. The panes operation came back empty. The separator is now the printable |~sim~|, which no tmux version escapes. A field that happens to contain it changes the line's field count, so that line is dropped rather than misread. Why not accept both forms tmux 3.3 and later also escape backslashes (\ prints as \\). So "split on the byte or on \037" could cut a field whose text holds a real \037. Telling the cases apart would mean decoding each version's escaping. A printable separator doesn't depend on escaping at all. Versions checked (real binaries) tmux 0x1f separator |~sim~| separator 2.9a raw verbatim 3.3a raw verbatim 3.4 (Ubuntu 24.04) escaped as \037 verbatim 3.5a escaped as \037 verbatim 3.6a raw verbatim 3.7c (current Homebrew) raw verbatim On real tmux 3.4, listPanes returned nothing with staging's code and the session's panes with this change. Autopsy The unit tests run against a fake tmux that printed format output unescaped, so this kind of bug could never fail them. The fake now escapes its output the way 3.4 and 3.5 do: backslashes doubled, control characters as octal escapes. The new attachment test goes through that fake. It fails with the old separator and passes with this one. It was found by a new Electron E2E against real tmux 3.4. That E2E follows in a separate PR. Type of Change Bug fix Testing Unit tests, red first with the old separator. Real tmux 2.9a, 3.3a, 3.4, 3.5a, 3.6a and 3.7c. Electron E2E with real tmux 3.4. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four ...

X Description: Summary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8720

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e5f2819c-7a26-6625-2b48-026bfb5e25af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD25C:267719:C2D593:10B2440:6AFB5679
html-safe-nonceb550c5f8b399e93340ec804641f313b93854dce817905683926aa7546fb7e3ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjVDOjI2NzcxOTpDMkQ1OTM6MTBCMjQ0MDo2QUZCNTY3OSIsInZpc2l0b3JfaWQiOiI3MDY0NDI2NDI4NjA2NjY2MzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9e31da4b959dc29420d5cfd72f7e2cab798dd5cd6bdfd34d18f48b163edb1f8b
hovercard-subject-tagpull_request:4767388883
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8720/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Sim joins the fields of tmux -F output with a 0x1f byte and splits on it. tmux 3.4 and 3.5 print control characters in format output as octal escapes, so the separator arrived as the four ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8720/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8720%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8720%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8720/files
Reloadhttps://github.com/simstudioai/sim/pull/8720/files
Reloadhttps://github.com/simstudioai/sim/pull/8720/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-tmux-format-separatorhttps://github.com/simstudioai/sim/tree/fix/desktop-tmux-format-separator
Conversation 5 https://github.com/simstudioai/sim/pull/8720
Commits 1 https://github.com/simstudioai/sim/pull/8720/commits
Checks 35 https://github.com/simstudioai/sim/pull/8720/checks
Files changed https://github.com/simstudioai/sim/pull/8720/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8720/files
fix(desktop): read tmux format output with a separator no tmux version escapes https://github.com/simstudioai/sim/pull/8720/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8720/files
b752e11 fix(desktop): read tmux format output with a separator no tmux versio… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8720/commits/b752e116bd9f36a3d0960cf88dc9ebbf12879232
Clear filters https://github.com/simstudioai/sim/pull/8720/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8720/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8720/files
tmux.test.ts https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
tmux.ts https://github.com/simstudioai/sim/pull/8720/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
apps/desktop/src/main/terminal/tmux.test.tshttps://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
View file https://github.com/simstudioai/sim/blob/b752e116bd9f36a3d0960cf88dc9ebbf12879232/apps/desktop/src/main/terminal/tmux.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8720/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8720/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
apps/desktop/src/main/terminal/tmux.tshttps://github.com/simstudioai/sim/pull/8720/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
View file https://github.com/simstudioai/sim/blob/b752e116bd9f36a3d0960cf88dc9ebbf12879232/apps/desktop/src/main/terminal/tmux.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8720/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8720/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8720/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8720/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
https://github.com/simstudioai/sim/pull/8720/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
Please reload this pagehttps://github.com/simstudioai/sim/pull/8720/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.