René's URL Explorer Experiment


Title: fix(events): authorize the events queued before a stream opens once by waleedlatif1 · Pull Request #8718 · simstudioai/sim · GitHub

Open Graph Title: fix(events): authorize the events queued before a stream opens once by waleedlatif1 · Pull Request #8718 · simstudioai/sim

X Title: fix(events): authorize the events queued before a stream opens once by waleedlatif1 · Pull Request #8718 · simstudioai/sim

Description: Summary Review follow-ups to #8700's SSE opening gate. Shared pre-open authorization: events that arrived before a revalidated stream opened each queued their own authorization behind the write chain, so ten of them made ten serial checks. They now share one authorization that starts when the stream opens, while each event is still written in order. The comment on the write chain now says exactly which events share a check. Defensive guards documented: comments explain the two guards no test can reach without depending on promise-scheduling depth: the fast path's empty-queue check, which covers an event sent from a microtask between the opening and the writes queued before it; the rejection handler on each authorization, which keeps a rejection from surfacing as unhandled until the write chain reaches that event. Mock hygiene: the mothership and MCP event route tests reset their ready mocks in beforeEach, so a mockReturnValueOnce cannot leak into the next test. Type of Change Bug fix Testing New writes every event queued before it opened once one authorization passes: ten events are queued before the open, and each authorization is a promise the test controls. Settling only the first writes all ten, in order. On staging it fails, because only the first event can be written before the next serial check. SSE, mothership, MCP and desktop route suites pass. The desktop inbox E2E over real HTTP on cold apps passed 3/3. The full gate (lint, typecheck, audits, unit and integration tests) passes. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Review follow-ups to #8700's SSE opening gate. Shared pre-open authorization: events that arrived before a revalidated stream opened each queued their own authorization behind the writ...

X Description: Summary Review follow-ups to #8700's SSE opening gate. Shared pre-open authorization: events that arrived before a revalidated stream opened each queued their own authorization behind the ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8718

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ef6dd5e0-cb13-4bd2-7aa3-74c7f1fc2422
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8940:303206:C68107:11796A2:6AFB5DDD
html-safe-nonceb7621fea6fc344ca0c5219115c486d0ab4bcb94606cf856f3b398c43de9ad9c2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTQwOjMwMzIwNjpDNjgxMDc6MTE3OTZBMjo2QUZCNURERCIsInZpc2l0b3JfaWQiOiI4NTExMjQzMDQwNTE2MTY5MTgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca30075374c03a5d0d8f71d935755bc8d6e796765e3f309d7cea11823cd9b187d
hovercard-subject-tagpull_request:4767169520
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8718/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Review follow-ups to #8700's SSE opening gate. Shared pre-open authorization: events that arrived before a revalidated stream opened each queued their own authorization behind the writ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8718/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8718%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8718%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8718/files
Reloadhttps://github.com/simstudioai/sim/pull/8718/files
Reloadhttps://github.com/simstudioai/sim/pull/8718/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sse-review-nitshttps://github.com/simstudioai/sim/tree/fix/sse-review-nits
Conversation 14 https://github.com/simstudioai/sim/pull/8718
Commits 2 https://github.com/simstudioai/sim/pull/8718/commits
Checks 33 https://github.com/simstudioai/sim/pull/8718/checks
Files changed https://github.com/simstudioai/sim/pull/8718/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8718/files
fix(events): authorize the events queued before a stream opens once https://github.com/simstudioai/sim/pull/8718/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8718/files
acde14b fix(events): authorize the events queued before a stream opens once waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8718/commits/acde14bbdee9b957625bf9a0239fd9392f455587
b37a7d9 test(events): prove the shared pre-open authorization through the str… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8718/commits/b37a7d9ffec540514ad6436d57586bf4df75f91b
Clear filters https://github.com/simstudioai/sim/pull/8718/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8718/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8718/files
route.test.ts https://github.com/simstudioai/sim/pull/8718/files#diff-761f69edd21df6a1238121fc9ca4edf8ae8ba3636cb204936c00a0f6d8ecff1d
route.test.ts https://github.com/simstudioai/sim/pull/8718/files#diff-4a36dbd1da4796453c7ff42f08c347dc5ffd20a4c448bc35cc6cbc720e19b683
sse-endpoint.test.ts https://github.com/simstudioai/sim/pull/8718/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
sse-endpoint.ts https://github.com/simstudioai/sim/pull/8718/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
apps/sim/app/api/mcp/events/route.test.tshttps://github.com/simstudioai/sim/pull/8718/files#diff-761f69edd21df6a1238121fc9ca4edf8ae8ba3636cb204936c00a0f6d8ecff1d
View file https://github.com/simstudioai/sim/blob/b37a7d9ffec540514ad6436d57586bf4df75f91b/apps/sim/app/api/mcp/events/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8718/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8718/files#diff-761f69edd21df6a1238121fc9ca4edf8ae8ba3636cb204936c00a0f6d8ecff1d
https://github.com/simstudioai/sim/pull/8718/files#diff-761f69edd21df6a1238121fc9ca4edf8ae8ba3636cb204936c00a0f6d8ecff1d
apps/sim/app/api/mothership/events/route.test.tshttps://github.com/simstudioai/sim/pull/8718/files#diff-4a36dbd1da4796453c7ff42f08c347dc5ffd20a4c448bc35cc6cbc720e19b683
View file https://github.com/simstudioai/sim/blob/b37a7d9ffec540514ad6436d57586bf4df75f91b/apps/sim/app/api/mothership/events/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8718/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8718/files#diff-4a36dbd1da4796453c7ff42f08c347dc5ffd20a4c448bc35cc6cbc720e19b683
https://github.com/simstudioai/sim/pull/8718/files#diff-4a36dbd1da4796453c7ff42f08c347dc5ffd20a4c448bc35cc6cbc720e19b683
apps/sim/lib/events/sse-endpoint.test.tshttps://github.com/simstudioai/sim/pull/8718/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
View file https://github.com/simstudioai/sim/blob/b37a7d9ffec540514ad6436d57586bf4df75f91b/apps/sim/lib/events/sse-endpoint.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8718/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8718/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
https://github.com/simstudioai/sim/pull/8718/files#diff-fe4bc27f0a5836f89b1ee7e1ab0e1180c4c53f170b14768b494c3d83e482e7a0
apps/sim/lib/events/sse-endpoint.tshttps://github.com/simstudioai/sim/pull/8718/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
View file https://github.com/simstudioai/sim/blob/b37a7d9ffec540514ad6436d57586bf4df75f91b/apps/sim/lib/events/sse-endpoint.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8718/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8718/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/8718/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/8718/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/8718/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
https://github.com/simstudioai/sim/pull/8718/files#diff-383257e7bcffe26ad3a94d114fdb49ceed8019920242632adf23ea0b72687978
Please reload this pagehttps://github.com/simstudioai/sim/pull/8718/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.