René's URL Explorer Experiment


Title: fix(mothership): keep a withdrawn first message held at the queue head as written by waleedlatif1 · Pull Request #8717 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): keep a withdrawn first message held at the queue head as written by waleedlatif1 · Pull Request #8717 · simstudioai/sim

X Title: fix(mothership): keep a withdrawn first message held at the queue head as written by waleedlatif1 · Pull Request #8717 · simstudioai/sim

Description: Summary Follow-up to #8707. A withdrawn first message held at the queue head can't be edited. When a chatless surface remounts with follow-ups queued, its first message goes back at the head of the queue under its original id. The server may already hold that message as sent. An edit dropped its resume id, so the edited text would have gone out as a second message, possibly in a second chat. The entry is now marked admissionUnknown. The store ignores edits to it, editQueuedMessage refuses to open it, and its Edit button is blocked with a tooltip ("May already be sent; editing could send a second message"), like the button of a message that is already sending. Remove and Send-now still work. It goes out exactly as written, and the server deduplicates it by id. More realistic ordering test. Its resent first message now gets the server's real dedupe 409 naming the chat, instead of a fresh 200. Type of Change Bug fix Testing The DOM ordering test asserts that the held head is flagged, and that the first message, then the follow-up, are each sent once. It fails on staging. does not let a withdrawn first message held at the queue head be edited (DOM) and leaves a first message the server may already hold unchanged, with its id (store) both fail on staging and pass here. The blocked Edit button uses aria-disabled, not disabled, so its tooltip can open (a disabled button gets no hover or focus); clicks are ignored while it is blocked. This also fixes the existing "Sending now" tooltip. queued-messages.dom.test.tsx covers it. The full gate and integration tests ran on the CI runner. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #8707. A withdrawn first message held at the queue head can't be edited. When a chatless surface remounts with follow-ups queued, its first message goes back at the head o...

X Description: Summary Follow-up to #8707. A withdrawn first message held at the queue head can't be edited. When a chatless surface remounts with follow-ups queued, its first message goes back at the he...

Opengraph URL: https://github.com/simstudioai/sim/pull/8717

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e83a2974-5508-a8f6-a520-261964d894a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB128:92D88:1AE67:23F49:6AFB64A7
html-safe-nonce5188eb134c9885c144a0cced9fb69ccbdc90b5527d73b78d9e9c2b704f90790a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTI4OjkyRDg4OjFBRTY3OjIzRjQ5OjZBRkI2NEE3IiwidmlzaXRvcl9pZCI6IjU5MzA3Mjk1NDU1MDkwNjk5OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac98e7e967f356a2bf904eaa879a2eed7b5c91a1566bb82c90c3237e4cc7b15eb6
hovercard-subject-tagpull_request:4767040955
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8717/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #8707. A withdrawn first message held at the queue head can't be edited. When a chatless surface remounts with follow-ups queued, its first message goes back at the head o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8717/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8717%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8717%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8717/files
Reloadhttps://github.com/simstudioai/sim/pull/8717/files
Reloadhttps://github.com/simstudioai/sim/pull/8717/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mothership-queued-first-message-edithttps://github.com/simstudioai/sim/tree/fix/mothership-queued-first-message-edit
Conversation 31 https://github.com/simstudioai/sim/pull/8717
Commits 5 https://github.com/simstudioai/sim/pull/8717/commits
Checks 32 https://github.com/simstudioai/sim/pull/8717/checks
Files changed https://github.com/simstudioai/sim/pull/8717/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8717/files
fix(mothership): keep a withdrawn first message held at the queue head as written https://github.com/simstudioai/sim/pull/8717/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/8717/files
30ccab5 fix(mothership): keep a withdrawn first message held at the queue hea… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8717/commits/30ccab54bec69c5fe545237d5a0318f8e124844b
48f268a fix(mothership): say a held first message may already be sent, not th… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8717/commits/48f268aa9f033f46bb2bf23f65a238ce5d9fd1d1
6fa70aa fix(mothership): let the blocked Edit button's tooltip open waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8717/commits/6fa70aa10f605316fcacf43fbb58008b70725c13
cbdcdd5 test(mothership): check the queued message edit state, not the edit c… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8717/commits/cbdcdd57a190de40e1e1ee6e6e22faf07b4146bf
792e002 test(mothership): name the queue test harness props waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8717/commits/792e002f116fe7a8855774a8bce09ed87762b487
Clear filters https://github.com/simstudioai/sim/pull/8717/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8717/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8717/files
queued-messages.dom.test.tsx https://github.com/simstudioai/sim/pull/8717/files#diff-b91d047b1c69ea960d4032e1750ceefb3cb2bae8f024100017ddc45a7fea2f4f
queued-messages.tsx https://github.com/simstudioai/sim/pull/8717/files#diff-3b4ae747b2c4b2c89569b74d47b07e46a9706201c1a37c3ec37a3b9ded989e27
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/8717/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
types.ts https://github.com/simstudioai/sim/pull/8717/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
store.test.ts https://github.com/simstudioai/sim/pull/8717/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
store.ts https://github.com/simstudioai/sim/pull/8717/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
.../app/workspace/[workspaceId]/home/components/queued-messages/queued-messages.dom.test.tsxhttps://github.com/simstudioai/sim/pull/8717/files#diff-b91d047b1c69ea960d4032e1750ceefb3cb2bae8f024100017ddc45a7fea2f4f
View file https://github.com/simstudioai/sim/blob/792e002f116fe7a8855774a8bce09ed87762b487/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/queued-messages/queued-messages.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8717/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/home/components/queued-messages/queued-messages.tsxhttps://github.com/simstudioai/sim/pull/8717/files#diff-3b4ae747b2c4b2c89569b74d47b07e46a9706201c1a37c3ec37a3b9ded989e27
View file https://github.com/simstudioai/sim/blob/792e002f116fe7a8855774a8bce09ed87762b487/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/queued-messages/queued-messages.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8717/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8717/files#diff-3b4ae747b2c4b2c89569b74d47b07e46a9706201c1a37c3ec37a3b9ded989e27
https://github.com/simstudioai/sim/pull/8717/files#diff-3b4ae747b2c4b2c89569b74d47b07e46a9706201c1a37c3ec37a3b9ded989e27
https://github.com/simstudioai/sim/pull/8717/files#diff-3b4ae747b2c4b2c89569b74d47b07e46a9706201c1a37c3ec37a3b9ded989e27
https://github.com/simstudioai/sim/pull/8717/files#diff-3b4ae747b2c4b2c89569b74d47b07e46a9706201c1a37c3ec37a3b9ded989e27
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.dom.test.tsxhttps://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
View file https://github.com/simstudioai/sim/blob/792e002f116fe7a8855774a8bce09ed87762b487/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8717/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8717/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.tshttps://github.com/simstudioai/sim/pull/8717/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
View file https://github.com/simstudioai/sim/blob/792e002f116fe7a8855774a8bce09ed87762b487/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8717/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8717/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8717/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8717/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8717/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
apps/sim/app/workspace/[workspaceId]/home/types.tshttps://github.com/simstudioai/sim/pull/8717/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
View file https://github.com/simstudioai/sim/blob/792e002f116fe7a8855774a8bce09ed87762b487/apps/sim/app/workspace/%5BworkspaceId%5D/home/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8717/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8717/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
https://github.com/simstudioai/sim/pull/8717/files#diff-931d1911f7368f5ce57b8f771e28c8b424eb4353334860aa03e1963369a0f222
apps/sim/stores/mothership-queue/store.test.tshttps://github.com/simstudioai/sim/pull/8717/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
View file https://github.com/simstudioai/sim/blob/792e002f116fe7a8855774a8bce09ed87762b487/apps/sim/stores/mothership-queue/store.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8717/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8717/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
https://github.com/simstudioai/sim/pull/8717/files#diff-7d2974e798ef7a4d7a04a4cf937327e478bb15555326c08838222e30dcbf5c54
apps/sim/stores/mothership-queue/store.tshttps://github.com/simstudioai/sim/pull/8717/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
View file https://github.com/simstudioai/sim/blob/792e002f116fe7a8855774a8bce09ed87762b487/apps/sim/stores/mothership-queue/store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8717/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8717/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
https://github.com/simstudioai/sim/pull/8717/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
Please reload this pagehttps://github.com/simstudioai/sim/pull/8717/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.