René's URL Explorer Experiment


Title: fix(ci): stop the detached telemetry flush too, re-signal stragglers on a monotonic clock, and report HTTP E2E failures by route by waleedlatif1 · Pull Request #8706 · simstudioai/sim · GitHub

Open Graph Title: fix(ci): stop the detached telemetry flush too, re-signal stragglers on a monotonic clock, and report HTTP E2E failures by route by waleedlatif1 · Pull Request #8706 · simstudioai/sim

X Title: fix(ci): stop the detached telemetry flush too, re-signal stragglers on a monotonic clock, and report HTTP E2E failures by route by waleedlatif1 · Pull Request #8706 · simstudioai/sim

Description: Summary CI: next dev spawns its telemetry flush detached, in a session of its own, even with telemetry disabled. That process outlived the app's session and wrote .next/dev/trace after stop-session.sh returned. The next app's rm -rf .next/dev could then fail with "Directory not empty", which happened in 5 of 68 recent CI runs. Each app now starts as E2E_APP= setsid ..., and every process it spawns inherits that tag. stop-session.sh stops and waits for both the session's members and any tagged process that left the session. stop-session.sh: Times its grace period from /proc/uptime, which is monotonic and not affected by the locale's decimal separator. EPOCHREALTIME is neither. Re-signals the session every 0.1s, so a process that joins the session after the first signal is stopped too. The header now says why zombies don't count. Version compare E2E: a request that times out while its body is being read now names its route, the same as a request that never answered. Desktop inbox E2E: callers that join an executor pull already in flight share it, so a failed pull is logged once instead of once per caller. Type of Change Bug fix Testing Checked stop-session.sh on Linux; each case left no processes behind: a member in its own process group stopped immediately; a member that ignores SIGTERM was SIGKILLed at 10s; a member that starts a new process when it receives SIGTERM: the new process was stopped within 1s; a leader that ignores SIGTERM was SIGKILLed at 10s. Ran a stop-then-wipe loop on Linux: Before this change, Next's detached flush was still running every time stop-session.sh returned (12 of 12 rounds). After, it was caught, in its own session, and stopped. No flush was left and nothing wrote under .next afterwards (8 of 8 rounds). Checked that a tagged process that detaches into its own session and keeps writing is stopped within 1s. Ran the full HTTP E2E app sequence 3 times on Linux (8 cores, cold .next for each app). Every iteration passed, and all warm-up checks passed. Typecheck and lint pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary CI: next dev spawns its telemetry flush detached, in a session of its own, even with telemetry disabled. That process outlived the app's session and wrote .next/dev/trace after stop-se...

X Description: Summary CI: next dev spawns its telemetry flush detached, in a session of its own, even with telemetry disabled. That process outlived the app's session and wrote .next/dev/trace after sto...

Opengraph URL: https://github.com/simstudioai/sim/pull/8706

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:44c1f0b0-13b0-256d-5a09-f9a651486a8f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC30C:22FE8E:CF82C3:125C60B:6AFB5F1B
html-safe-nonce411e539c51e63b61bb23a99c4c51afd18f8162ef745b9f93436ca9f72cb223c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzBDOjIyRkU4RTpDRjgyQzM6MTI1QzYwQjo2QUZCNUYxQiIsInZpc2l0b3JfaWQiOiI3NzIyODE2MTI1OTE3NjgzNDgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace7a33195e2b081963961c52c6fc534793442e629c7d49b85cb7c151a25d20dff
hovercard-subject-tagpull_request:4766232782
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8706/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary CI: next dev spawns its telemetry flush detached, in a session of its own, even with telemetry disabled. That process outlived the app's session and wrote .next/dev/trace after stop-se...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8706/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8706%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8706%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8706/files
Reloadhttps://github.com/simstudioai/sim/pull/8706/files
Reloadhttps://github.com/simstudioai/sim/pull/8706/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/http-e2e-review-nitshttps://github.com/simstudioai/sim/tree/fix/http-e2e-review-nits
Conversation 15 https://github.com/simstudioai/sim/pull/8706
Commits 3 https://github.com/simstudioai/sim/pull/8706/commits
Checks 33 https://github.com/simstudioai/sim/pull/8706/checks
Files changed https://github.com/simstudioai/sim/pull/8706/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8706/files
fix(ci): stop the detached telemetry flush too, re-signal stragglers on a monotonic clock, and report HTTP E2E failures by route https://github.com/simstudioai/sim/pull/8706/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8706/files
69d4126 fix(e2e): re-signal session stragglers on a monotonic clock and repor… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8706/commits/69d4126427686cde904e94188fb50f00d8ea913f
43bab1f fix(e2e): log a failed executor pull with its stack waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8706/commits/43bab1fdd8f46f40c2e8f0f2d0a7c9642c9d776b
aa43cdd fix(ci): also stop the detached telemetry flush an HTTP end-to-end ap… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8706/commits/aa43cdd2c510631a12d43b495f7d42e9aa79ae4e
Clear filters https://github.com/simstudioai/sim/pull/8706/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8706/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8706/files
stop-session.sh https://github.com/simstudioai/sim/pull/8706/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
test-build.yml https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
test-desktop-inbox-e2e.ts https://github.com/simstudioai/sim/pull/8706/files#diff-cccbeb979bb964bf8ba5b5fa155cdb4148fbdd1507bc21448e84f90cce430a69
test-workflow-version-compare-e2e.ts https://github.com/simstudioai/sim/pull/8706/files#diff-5d870c08849e0c3e27403c3c392d4e97cf63df31c904bc6dbd65dd796dbc8a3b
.github/scripts/stop-session.shhttps://github.com/simstudioai/sim/pull/8706/files#diff-ce5ccc41321bbbb8cc488d338318943c11c90eb387f9f9d7c67f432d69729cac
View file https://github.com/simstudioai/sim/blob/aa43cdd2c510631a12d43b495f7d42e9aa79ae4e/.github/scripts/stop-session.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8706/{{ revealButtonHref }}
.github/workflows/test-build.ymlhttps://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
View file https://github.com/simstudioai/sim/blob/aa43cdd2c510631a12d43b495f7d42e9aa79ae4e/.github/workflows/test-build.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8706/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/8706/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
apps/sim/scripts/test-desktop-inbox-e2e.tshttps://github.com/simstudioai/sim/pull/8706/files#diff-cccbeb979bb964bf8ba5b5fa155cdb4148fbdd1507bc21448e84f90cce430a69
View file https://github.com/simstudioai/sim/blob/aa43cdd2c510631a12d43b495f7d42e9aa79ae4e/apps/sim/scripts/test-desktop-inbox-e2e.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8706/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8706/files#diff-cccbeb979bb964bf8ba5b5fa155cdb4148fbdd1507bc21448e84f90cce430a69
https://github.com/simstudioai/sim/pull/8706/files#diff-cccbeb979bb964bf8ba5b5fa155cdb4148fbdd1507bc21448e84f90cce430a69
https://github.com/simstudioai/sim/pull/8706/files#diff-cccbeb979bb964bf8ba5b5fa155cdb4148fbdd1507bc21448e84f90cce430a69
apps/sim/scripts/test-workflow-version-compare-e2e.tshttps://github.com/simstudioai/sim/pull/8706/files#diff-5d870c08849e0c3e27403c3c392d4e97cf63df31c904bc6dbd65dd796dbc8a3b
View file https://github.com/simstudioai/sim/blob/aa43cdd2c510631a12d43b495f7d42e9aa79ae4e/apps/sim/scripts/test-workflow-version-compare-e2e.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8706/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8706/files#diff-5d870c08849e0c3e27403c3c392d4e97cf63df31c904bc6dbd65dd796dbc8a3b
https://github.com/simstudioai/sim/pull/8706/files#diff-5d870c08849e0c3e27403c3c392d4e97cf63df31c904bc6dbd65dd796dbc8a3b
Please reload this pagehttps://github.com/simstudioai/sim/pull/8706/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.