René's URL Explorer Experiment


Title: fix(desktop): run an agent command on tmux that cannot tag its pane, untracked by waleedlatif1 · Pull Request #8705 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): run an agent command on tmux that cannot tag its pane, untracked by waleedlatif1 · Pull Request #8705 · simstudioai/sim

X Title: fix(desktop): run an agent command on tmux that cannot tag its pane, untracked by waleedlatif1 · Pull Request #8705 · simstudioai/sim

Description: Summary Follow-up to #8668. To stop only its own commands, an agent run inside tmux tags its pane with a pane option (set-option -p). Pane options need tmux 3.0 or later. #8668 refused the command whenever tagging failed, so on older tmux every agent run failed, even with the background executor off. On tmux before 3.0, a run now goes ahead untracked. Such a tmux refuses set-option -p, and Sim recognises the refusal from the text real tmux 2.9a prints: its getopt's unknown option -- p, or illegal option -- p with BSD getopt on macOS, followed by set-option's usage line. A tmux that can tag panes but did not (it timed out, or failed otherwise) still gets the run refused, so no command starts that Stop and sign-out could never end. Stop, sign-out and switching Terminal off leave an untracked run alone, because nothing could tell its pane from one of the user's. A call stopped mid-wait reports such a run as running rather than completed, and keeps its files. An untracked run is reaped once it finishes or its pane is gone. Gone means tmux no longer has that pane, checked with #{pane_id}, a format every tmux knows; tmux 3.x answers for a missing pane with an empty line rather than an error. It is not kept as an orphan when its Sim terminal closes. A finished run's pane is closed, including when a run finishes after its call returned and is reaped later, so dead panes kept by remain-on-exit do not pile up. An untracked run's pane is closed only when tmux reports its start command (#{pane_start_command}, which old tmux has too) as the run's own script, so a user's pane that took the id after a tmux restart is never closed. Tagged runs behave as before. The start gate still holds every command until the tagging call has finished, so a tagged run's command never runs before a stop could recognise its pane. The pane field in a run result #8668 changed a run result's pane from the run's window id (@N) to its pane id (%N). I checked every consumer: Sim's web UI: nothing renders the field. The model: it may pass the value back as the pane argument of read, input, kill or close. All four hand it to tmux as -t, and tmux accepts a pane id there. A pane id is also more precise than a window id: @N meant whichever pane of that window was active, so a split could redirect the call. Docs: the protocol docs now describe both values. The generated tool catalog describes the pane argument as a session:window.pane target from panes; a run's pane id is still a valid target, so nothing there breaks. Format separator follow-up to #8720 The -F separator changes from |~sim~| to <~sim~>. |~sim~| began and ended with the same character, so a field ending in |~sim~ (a cwd or a window name) was misread rather than dropped. <~sim~> has no proper prefix that is also a suffix. It can only be found where Sim wrote it, or wholly inside a field, and that changes the line's field count, so the line is dropped. Tests Untagged run: on old tmux's real refusal (captured from tmux 2.9a, plus the BSD getopt wording), the run starts untracked, a stop sends tmux nothing, and the user's pane is untouched. Once the pane is gone (answered the 3.x way), it reads as gone. Refused run: on a timeout or any other tagging failure, the run is refused. Dead panes: a finished untracked run's pane is closed, and only once it has finished; a run reaped after it finished has its pane closed; a user's pane that took a finished run's id after a restart is left open. Real commands: they run whether or not tmux could tag the pane (the fake tmux actually executes the script). Gate: the fake tmux holds the tagging call until the test releases it. While it is held, the command has not run; once it is released, the command runs. Stop on an untracked run: a Stop mid-wait reports the run as still running and keeps its files, and the run is reaped once its status lands. Once its pane disappears, it reads as gone. Separator: a field that ends with all but the separator's last character parses intact, and a field holding the whole separator drops its line. The first test fails with |~sim~|. Real tmux: with real 2.9a, runs go ahead untracked, the command runs, and Stop leaves it alone. With real 3.4, runs are tagged, and Stop ends the run and closes its pane. listPanes parses on both. Red checks: With the old refusal pattern, five tests fail on 2.9a's real text. Against staging's tmux.ts, the first two tests fail. With the gate loop removed, the gate test fails. The gate test replaces a weak one, "never runs one it could not tag". That test passed because the run directory had been deleted, not because of the gate.

Open Graph Description: Summary Follow-up to #8668. To stop only its own commands, an agent run inside tmux tags its pane with a pane option (set-option -p). Pane options need tmux 3.0 or later. #8668 refused the command ...

X Description: Summary Follow-up to #8668. To stop only its own commands, an agent run inside tmux tags its pane with a pane option (set-option -p). Pane options need tmux 3.0 or later. #8668 refused the command ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8705

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b501d0fb-2cea-8cd0-590a-29b3ffa4dc66
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB4C:1E90AB:2D771F:400ED6:6AFB6F45
html-safe-nonce0d3e8fcfb4f810c3f8fcf511408efbb64e788a7ddc8b69b6160f71f8098ba4a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjRDOjFFOTBBQjoyRDc3MUY6NDAwRUQ2OjZBRkI2RjQ1IiwidmlzaXRvcl9pZCI6IjM5ODM4Nzc1NTUyMTA2NDUzMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac21ec21ccb7f228b3ccabecc8f9998622a1030246e6df1a2d25de58d952ff2015
hovercard-subject-tagpull_request:4766052040
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8705/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #8668. To stop only its own commands, an agent run inside tmux tags its pane with a pane option (set-option -p). Pane options need tmux 3.0 or later. #8668 refused the command ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8705/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8705%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8705%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8705/files
Reloadhttps://github.com/simstudioai/sim/pull/8705/files
Reloadhttps://github.com/simstudioai/sim/pull/8705/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/desktop-tmux-untagged-runshttps://github.com/simstudioai/sim/tree/fix/desktop-tmux-untagged-runs
Conversation 31 https://github.com/simstudioai/sim/pull/8705
Commits 5 https://github.com/simstudioai/sim/pull/8705/commits
Checks 36 https://github.com/simstudioai/sim/pull/8705/checks
Files changed https://github.com/simstudioai/sim/pull/8705/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8705/files
fix(desktop): run an agent command on tmux that cannot tag its pane, untracked https://github.com/simstudioai/sim/pull/8705/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/8705/files
8cc81f4 fix(desktop): run an agent command on tmux that cannot tag its pane, … waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8705/commits/8cc81f4e3da2c6036bb51e74435049c63e7d07ac
67b544b fix(desktop): report an untracked run a Stop could not end as still r… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8705/commits/67b544b448520e47d912c068031abd91a0fc54b2
1ce44c8 fix(desktop): run untracked only on tmux without pane options, and re… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8705/commits/1ce44c8c9536246df48f1cdfb7f77a291a793cd2
26c99a1 fix(desktop): close a finished untracked run's pane only when its sta… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8705/commits/26c99a133e4ddfeb6ae624fe2653dcbdda1eb7c6
8dddbd7 fix(desktop): recognise how real tmux before 3.0 refuses pane options… waleedlatif1 Oct 7, 2026 https://github.com/simstudioai/sim/pull/8705/commits/8dddbd7c18d25f360167caba62ace3b51132c499
Clear filters https://github.com/simstudioai/sim/pull/8705/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8705/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8705/files
index.ts https://github.com/simstudioai/sim/pull/8705/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
service.test.ts https://github.com/simstudioai/sim/pull/8705/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
tmux.test.ts https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
tmux.ts https://github.com/simstudioai/sim/pull/8705/files#diff-652e4176d404d3301f626ae13eeb492707d7d0161aaf3c54efc1299d5dac6ea7
index.ts https://github.com/simstudioai/sim/pull/8705/files#diff-40857e90d71f7cd2c6186f71ae8c99077cb41f1f08f1af89c87916b8d5145537
apps/desktop/src/main/terminal/index.tshttps://github.com/simstudioai/sim/pull/8705/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
View file https://github.com/simstudioai/sim/blob/8dddbd7c18d25f360167caba62ace3b51132c499/apps/desktop/src/main/terminal/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8705/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8705/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
Please reload this pagehttps://github.com/simstudioai/sim/pull/8705/files
https://github.com/simstudioai/sim/pull/8705/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
https://github.com/simstudioai/sim/pull/8705/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
https://github.com/simstudioai/sim/pull/8705/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
https://github.com/simstudioai/sim/pull/8705/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
apps/desktop/src/main/terminal/service.test.tshttps://github.com/simstudioai/sim/pull/8705/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
View file https://github.com/simstudioai/sim/blob/8dddbd7c18d25f360167caba62ace3b51132c499/apps/desktop/src/main/terminal/service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8705/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8705/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
https://github.com/simstudioai/sim/pull/8705/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
https://github.com/simstudioai/sim/pull/8705/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
https://github.com/simstudioai/sim/pull/8705/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
https://github.com/simstudioai/sim/pull/8705/files#diff-ccf1a39e658c6d2cc7398268ef30d8d5da1a8ac78f2c13fdc808e54926c575cb
apps/desktop/src/main/terminal/tmux.test.tshttps://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
View file https://github.com/simstudioai/sim/blob/8dddbd7c18d25f360167caba62ace3b51132c499/apps/desktop/src/main/terminal/tmux.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8705/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
https://github.com/simstudioai/sim/pull/8705/files#diff-6ff6f8f25063a7bb7477c857efbe224725787cdcf259553639a58961a2b07d79
Please reload this pagehttps://github.com/simstudioai/sim/pull/8705/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8705/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.