René's URL Explorer Experiment


Title: test(desktop): keep the SQL and TypeScript desktop-call classifiers in agreement by waleedlatif1 · Pull Request #8694 · simstudioai/sim · GitHub

Open Graph Title: test(desktop): keep the SQL and TypeScript desktop-call classifiers in agreement by waleedlatif1 · Pull Request #8694 · simstudioai/sim

X Title: test(desktop): keep the SQL and TypeScript desktop-call classifiers in agreement by waleedlatif1 · Pull Request #8694 · simstudioai/sim

Description: Summary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib/desktop/executor/repository.ts), so their limits apply only to calls the desktop runs. Only scattered tests tied the two together. A desktop tool added on one side only, such as a new argument-dependent one, would silently drop out of the inbox and the sweep, or let Sim-only calls crowd them. desktop-call-classifier.integration.ts runs one table of calls through both classifiers against real PostgreSQL and requires them to agree on every case. Each case is an offered, unclaimed call on a device-bound run, and the SQL verdict is read through listDesktopInboxRows, which returns exactly the rows the predicate admits. The table covers: every named desktop tool; read and grep under user-local/, exactly user-local, user-local/ with a trailing slash, a user-localX/ sibling, a user-local% LIKE-wildcard lookalike, and Sim's own files; glob patterns under, at and outside user-local, and the path under the other argument name; non-string (number, array, object, null) and missing arguments; non-desktop tools, including one with a local-looking path. A failure lists each disagreeing case with both verdicts. The test also requires both sides to admit more than the named tools, so agreement on "nothing" can't pass. Test plan The new test passes against the current code: the classifiers agree on every case. Red check: with the glob branch removed from the SQL predicate, it fails and names the two local glob cases (sql: false, typescript: true). Gate on the EC2 runner: lint, type-check, audits, migrations, docs, block registry, bun run test, and the full integration suite (the new file included) all pass. In bun run test, the route-inventory test timed out on its first run under load and passes run on its own.

Open Graph Description: Summary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib...

X Description: Summary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib...

Opengraph URL: https://github.com/simstudioai/sim/pull/8694

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7498ccdd-66ff-e0b3-9247-e382a45438ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA95A:3222E4:26F0CE:36D43F:6AFB528A
html-safe-nonce5fb753470c500a691efb9ca812bb0f9f6f28629beaca0e159aeb76de277d84fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTVBOjMyMjJFNDoyNkYwQ0U6MzZENDNGOjZBRkI1MjhBIiwidmlzaXRvcl9pZCI6IjI3MzM0NTg0NTA0NDM2MjEwMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac408c81858979fe11c61b374694c8edd2abfb18a509bc33cd55f172f0073bde17
hovercard-subject-tagpull_request:4764228417
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8694/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8694/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8694%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8694%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8694/files
Reloadhttps://github.com/simstudioai/sim/pull/8694/files
Reloadhttps://github.com/simstudioai/sim/pull/8694/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
test/desktop-call-classifier-parityhttps://github.com/simstudioai/sim/tree/test/desktop-call-classifier-parity
Conversation 5 https://github.com/simstudioai/sim/pull/8694
Commits 1 https://github.com/simstudioai/sim/pull/8694/commits
Checks 36 https://github.com/simstudioai/sim/pull/8694/checks
Files changed https://github.com/simstudioai/sim/pull/8694/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8694/files
test(desktop): keep the SQL and TypeScript desktop-call classifiers in agreement https://github.com/simstudioai/sim/pull/8694/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8694/files
ea85e0a test(desktop): keep the SQL and TypeScript desktop-call classifiers i… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8694/commits/ea85e0a19c0803637a1a7af6f00c3288bd5d2d81
Clear filters https://github.com/simstudioai/sim/pull/8694/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8694/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8694/files
apps/sim/lib/desktop/executor/desktop-call-classifier.integration.tshttps://github.com/simstudioai/sim/pull/8694/files#diff-936ce1411677cbdf743f2f5adf59a4bbdab500a102766c36bb851835be2db98f
View file https://github.com/simstudioai/sim/blob/ea85e0a19c0803637a1a7af6f00c3288bd5d2d81/apps/sim/lib/desktop/executor/desktop-call-classifier.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8694/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8694/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.