Title: test(desktop): keep the SQL and TypeScript desktop-call classifiers in agreement by waleedlatif1 · Pull Request #8694 · simstudioai/sim · GitHub
Open Graph Title: test(desktop): keep the SQL and TypeScript desktop-call classifiers in agreement by waleedlatif1 · Pull Request #8694 · simstudioai/sim
X Title: test(desktop): keep the SQL and TypeScript desktop-call classifiers in agreement by waleedlatif1 · Pull Request #8694 · simstudioai/sim
Description: Summary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib/desktop/executor/repository.ts), so their limits apply only to calls the desktop runs. Only scattered tests tied the two together. A desktop tool added on one side only, such as a new argument-dependent one, would silently drop out of the inbox and the sweep, or let Sim-only calls crowd them. desktop-call-classifier.integration.ts runs one table of calls through both classifiers against real PostgreSQL and requires them to agree on every case. Each case is an offered, unclaimed call on a device-bound run, and the SQL verdict is read through listDesktopInboxRows, which returns exactly the rows the predicate admits. The table covers: every named desktop tool; read and grep under user-local/, exactly user-local, user-local/ with a trailing slash, a user-localX/ sibling, a user-local% LIKE-wildcard lookalike, and Sim's own files; glob patterns under, at and outside user-local, and the path under the other argument name; non-string (number, array, object, null) and missing arguments; non-desktop tools, including one with a local-looking path. A failure lists each disagreeing case with both verdicts. The test also requires both sides to admit more than the named tools, so agreement on "nothing" can't pass. Test plan The new test passes against the current code: the classifiers agree on every case. Red check: with the glob branch removed from the SQL predicate, it fails and names the two local glob cases (sql: false, typescript: true). Gate on the EC2 runner: lint, type-check, audits, migrations, docs, block registry, bun run test, and the full integration suite (the new file included) all pass. In bun run test, the route-inventory test timed out on its first run under load and passes run on its own.
Open Graph Description: Summary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib...
X Description: Summary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib...
Opengraph URL: https://github.com/simstudioai/sim/pull/8694
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7498ccdd-66ff-e0b3-9247-e382a45438ea |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A95A:3222E4:26F0CE:36D43F:6AFB528A |
| html-safe-nonce | 5fb753470c500a691efb9ca812bb0f9f6f28629beaca0e159aeb76de277d84fa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTVBOjMyMjJFNDoyNkYwQ0U6MzZENDNGOjZBRkI1MjhBIiwidmlzaXRvcl9pZCI6IjI3MzM0NTg0NTA0NDM2MjEwMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 408c81858979fe11c61b374694c8edd2abfb18a509bc33cd55f172f0073bde17 |
| hovercard-subject-tag | pull_request:4764228417 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8694/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-up to #8685, from its review. Tests only, no production change. The desktop inbox and the overdue sweep filter calls with a SQL form of isDesktopToolCall (isDesktopToolCallRow in lib... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width