René's URL Explorer Experiment


Title: fix(mothership): keep a message the server never admitted instead of dropping it by waleedlatif1 · Pull Request #8674 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): keep a message the server never admitted instead of dropping it by waleedlatif1 · Pull Request #8674 · simstudioai/sim

X Title: fix(mothership): keep a message the server never admitted instead of dropping it by waleedlatif1 · Pull Request #8674 · simstudioai/sim

Description: Summary A send whose POST never got a response (offline, Wi-Fi drop, waking a laptop) reconnected to the stream it would have opened. That stream does not exist, so the 404 read as "finished": the turn finalized as a success and the message disappeared from the transcript with no error. A queued follow-up dispatched the same way was lost too. A send refused with 409 because another turn held the chat (started in another tab, or one this tab lost track of) reconnected to that turn under the new message's bubble, then vanished when that turn finished. Both now hand the message back under its id instead of consuming it: an unreachable send is held in the queue (not redispatched into the same failure) and goes out when the browser is back online, or when the user sends it; a send that found the chat busy waits in the queue behind the running turn, which the chat now shows as running, and goes out when it ends. Reusing the id keeps a retry deduplicated if the server did admit the first attempt. Type of Change Bug fix Testing New DOM regressions in use-chat.dom.test.tsx (offline send held then sent on online under the same id; queued follow-up whose dispatch could not reach the server; send refused by another tab's turn goes out after it). All three fail on staging. Browser E2E on a local Sim + worker stack with a scripted model: going offline, sending, coming back online now delivers the message and completes the turn (before: silently lost); a second tab that missed another tab's turn start now queues its message behind it (before: showed the other turn's answer under it, then lost it). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A send whose POST never got a response (offline, Wi-Fi drop, waking a laptop) reconnected to the stream it would have opened. That stream does not exist, so the 404 read as "finished&...

X Description: Summary A send whose POST never got a response (offline, Wi-Fi drop, waking a laptop) reconnected to the stream it would have opened. That stream does not exist, so the 404 read as "finis...

Opengraph URL: https://github.com/simstudioai/sim/pull/8674

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:30bd6cf5-d69e-7efc-7b3a-a98da515e0ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DF4:BD772:B537B0:F82071:6AFB52C4
html-safe-noncee56e0401374e9f16295e9ad4702927cb66c05a765683fb14fee4ae57612150e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REY0OkJENzcyOkI1MzdCMDpGODIwNzE6NkFGQjUyQzQiLCJ2aXNpdG9yX2lkIjoiMTA0NTg2Nzk0MzMxMDM0ODk5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8583047625c3a272fd431671265dd34d1fcd13076cb1029c6bcb2ddcdb8b1b68
hovercard-subject-tagpull_request:4761322873
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8674/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A send whose POST never got a response (offline, Wi-Fi drop, waking a laptop) reconnected to the stream it would have opened. That stream does not exist, so the 404 read as "finished&...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8674/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8674%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8674%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8674/files
Reloadhttps://github.com/simstudioai/sim/pull/8674/files
Reloadhttps://github.com/simstudioai/sim/pull/8674/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mothership-keep-unadmitted-sendshttps://github.com/simstudioai/sim/tree/fix/mothership-keep-unadmitted-sends
Conversation 47 https://github.com/simstudioai/sim/pull/8674
Commits 7 https://github.com/simstudioai/sim/pull/8674/commits
Checks 32 https://github.com/simstudioai/sim/pull/8674/checks
Files changed https://github.com/simstudioai/sim/pull/8674/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8674/files
fix(mothership): keep a message the server never admitted instead of dropping it https://github.com/simstudioai/sim/pull/8674/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/8674/files
e7e28ba fix(mothership): keep a message the server never admitted instead of … waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8674/commits/e7e28ba92682117d4415f1095117aeae1ee62bd6
9d3a096 fix(mothership): keep held and busy-refused sends exactly once across… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8674/commits/9d3a0967276c52f3b56acaf025a588be64035bcc
c8aa1d2 fix(mothership): send released held messages through the queue's own … waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8674/commits/c8aa1d2adc42156d194b3ecfb14e6208cf964583
81e8be0 fix(mothership): don't hold a send whose network returned while it wa… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8674/commits/81e8be02aaf3b90d42933618cdf097b4e5401c58
bb6f537 chore(mothership): name sign-out in desktop tool lease docs and say "… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8674/commits/bb6f5372df68aa2ee15178f71db5a3f9cafa53d0
852a03e fix(mothership): restore a withdrawn queued send even after the user … waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8674/commits/852a03e684112f85260e056dffe771c53b3565e3
fc5cbe6 fix(mothership): don't recreate a deleted chat's queue from a late re… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8674/commits/fc5cbe64ca28baaf967fda2e63edcc548442e02d
Clear filters https://github.com/simstudioai/sim/pull/8674/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8674/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8674/files
desktop-tool-lifetimes.ts https://github.com/simstudioai/sim/pull/8674/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/8674/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/8674/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
browser-tool-execution.test.ts https://github.com/simstudioai/sim/pull/8674/files#diff-c395e5360aa0e76912da9f12b41a11bbbbbaaa51564afd3dc799f0fa45b531c8
browser-tool-execution.ts https://github.com/simstudioai/sim/pull/8674/files#diff-8f905f5e874cb0a596f2b1d94ccaaf419d995620aec1a4a5d7e677e6190cbd8d
store.ts https://github.com/simstudioai/sim/pull/8674/files#diff-f9609bb09028d5fea616b8fbeca370d62c6a6d20f6dc460fed34a8a0594dce70
types.ts https://github.com/simstudioai/sim/pull/8674/files#diff-66995a79415f1ef4665bc2e86e1d1a9d3b0d0babf5f62114dc92f09880c1d1ae
apps/sim/app/workspace/[workspaceId]/home/hooks/desktop-tool-lifetimes.tshttps://github.com/simstudioai/sim/pull/8674/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
View file https://github.com/simstudioai/sim/blob/fc5cbe64ca28baaf967fda2e63edcc548442e02d/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/desktop-tool-lifetimes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8674/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8674/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
https://github.com/simstudioai/sim/pull/8674/files#diff-3574167671568f8f933fb8431cf1570cedb11cb8e345a2e2bfef5f91039057c3
Please reload this pagehttps://github.com/simstudioai/sim/pull/8674/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8674/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.