Title: feat(mothership): let the worker choose models when the model picker is off by waleedlatif1 · Pull Request #8669 · simstudioai/sim · GitHub
Open Graph Title: feat(mothership): let the worker choose models when the model picker is off by waleedlatif1 · Pull Request #8669 · simstudioai/sim
X Title: feat(mothership): let the worker choose models when the model picker is off by waleedlatif1 · Pull Request #8669 · simstudioai/sim
Description: Summary When the Mothership model picker is off, as it is on hosted prod, chats no longer send a hidden model selection. The worker now routes every model role itself. Paired worker PR: simstudioai/mothership#601. With it, the worker runs the main agent on GPT-6 Astra and subagents on GPT-6 Sol by default. Merge waits on an end-to-end benchmark. A small paired sample showed correctness 66.7% → 75.0% with 0 losses, cost −21% and wall time −23.5%. Both PRs merge only if a larger run confirms that. Why resolveMothershipModelSettings attached {gpt-6-astra, fastMode:false} to every non-assistant chat when the picker was off. The worker treats any selection as the user's explicit pick and runs both the main agent and subagents on it, so the server's role models (COPILOT_SUBAGENT_MODEL, and on self-host COPILOT_MODEL) never applied. This is the same problem that led withEnterpriseByokKey to remove the hidden default for BYOK workspaces. Server-side model routing is a Mothership rule, so a selection should only travel when someone made one. Changes resolveMothershipModelSettings. With the picker off it returns modelSelection: undefined. The effort clamps are unchanged. The key is still present, so Object.assign(body, …) at admission clears any stale selection a client sends. normalizeModelSelection. The Opus 5 → 5.5 and no-Fast-for-Opus normalization moved into its own function, which the store and the picker-on path both use. Model selector. Shows the model controls when a selection exists, which happens only with the picker on. Unchanged Picker-on chats, including one that has never been changed and is shown as Astra. The Sim Chat block, which has its own visible model field. Assistant/Search chats. BYOK handling. Compatibility New Sim with old worker. The worker uses COPILOT_MODEL for the main agent and COPILOT_SUBAGENT_MODEL ?? COPILOT_MODEL for subagents, which is Astra/Astra today. Hosted behavior does not change. Old Sim with new worker. The hidden selection still arrives as an explicit Astra pick, so behavior is Astra/Astra as today. Both new. Astra main agent with Sol subagents. Tests post.test.ts: the picker-off case serializes the request that admission hands to the stream lifecycle (the body sent to the worker). It asserts the request has no modelSelection, even when the client sent a Sol selection, and that it carries the clamped effort. On staging all 6 effort cases fail with the hidden { model: 'gpt-6-astra', fastMode: false }. Gate bun run lint, type-check, check:audits, docs-manifest:check and the block-registry check all pass. bun run test: 34772 pass. Four unrelated files failed under machine load: remark-plain-text, html-parser, copilot-route-inventory (60s timeout) and sso-trust. They pass when rerun together with lib/mothership and stores/mothership-effort: 2697 tests pass.
Open Graph Description: Summary When the Mothership model picker is off, as it is on hosted prod, chats no longer send a hidden model selection. The worker now routes every model role itself. Paired worker PR: simstudioai...
X Description: Summary When the Mothership model picker is off, as it is on hosted prod, chats no longer send a hidden model selection. The worker now routes every model role itself. Paired worker PR: simstudioai...
Opengraph URL: https://github.com/simstudioai/sim/pull/8669
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:446b9c2d-d4f1-5611-1dad-1ecd87371842 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C152:EA1A8:A86D61:E75371:6AFB517E |
| html-safe-nonce | 24568c6bedf10b636ea02d52aeac91c0fd4cc9a6216589df6c62e1f3e1e74660 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTUyOkVBMUE4OkE4NkQ2MTpFNzUzNzE6NkFGQjUxN0UiLCJ2aXNpdG9yX2lkIjoiNjU3MDg1MzIwMjE3NjcyNTM3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b7a56b05475f1de727b4a29df044983d7056bc3ab336cff60fb80ae339d1fb18 |
| hovercard-subject-tag | pull_request:4754986006 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8669/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary When the Mothership model picker is off, as it is on hosted prod, chats no longer send a hidden model selection. The worker now routes every model role itself. Paired worker PR: simstudioai... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width