René's URL Explorer Experiment


Title: fix(mothership): keep a new chat's effort pick changed while its first send is pending by waleedlatif1 · Pull Request #8662 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): keep a new chat's effort pick changed while its first send is pending by waleedlatif1 · Pull Request #8662 · simstudioai/sim

X Title: fix(mothership): keep a new chat's effort pick changed while its first send is pending by waleedlatif1 · Pull Request #8662 · simstudioai/sim

Description: Summary Raised by cubic on the release PR: #8654 (comment) On a new chat, the first send captures the effort pick (X) and the server stores it on the chat it opens. If the user changes the picker to Y while that send is still pending, the change goes to newChatEffort (there is no chat id yet). On admission, useChat adopted the captured X onto the new chat and cleared newChatEffort, so Y was lost: the picker showed X and the next turn ran at X. The dedup-conflict adoption (409 naming the chat the first attempt opened) had the same problem. Adopting newChatEffort ?? effortChoice locally is not enough on its own: admission already stored X on the server, so a reload would bring X back. Fix At admission, useChat reads the live new-chat pick. If it differs from the pick the send carried, it adopts it locally and saves it to the chat through the existing per-chat effort save (PUT /api/mothership/chats/[chatId]/effort), so local and server state agree. A failed save rolls back by pick token as before, falling back to the stored value. If the pick is unset or unchanged, behaviour is unchanged and no extra save fires. On a dedup conflict (409 naming the chat an earlier attempt opened), the client cannot know which pick that attempt stored, so it adopts the latest pick and always saves it. The effort mutation's options move into one factory. useSetMothershipChatEffort(chatId) is unchanged; a new saveMothershipChatEffort(queryClient, chatId, effort) runs the same mutation through a MutationObserver for a chat id learned mid-send. Both use the same per-chat scope, so the admission save and any later composer pick for that chat land in order, and other chats never wait on it. Test plan New use-chat.dom.test.tsx case: pick low, send, change the pick to high while the send is pending, admit. Asserts the chat keeps high and exactly one effort save goes to that chat. Fails on current staging (expected 'low' to be 'high'), passes with the fix. Same case with the pick unchanged asserts no effort save fires. New dedup case: a 409 naming the earlier attempt's chat adopts the latest pick and saves it to that chat. Also fails on current staging, passes with the fix. Existing effort mutation test passes unchanged. tsc --noEmit, biome, check:audits, and the home hooks, user-input, mothership-chats, effort store, and organization-home suites pass.

Open Graph Description: Summary Raised by cubic on the release PR: #8654 (comment) On a new chat, the first send captures the effort pick (X) and the server stores it on the chat it opens. If the user changes the picker t...

X Description: Summary Raised by cubic on the release PR: #8654 (comment) On a new chat, the first send captures the effort pick (X) and the server stores it on the chat it opens. If the user changes the picker t...

Opengraph URL: https://github.com/simstudioai/sim/pull/8662

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fa8a6385-30f1-8e1d-ee39-0b146a98bd48
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF26:160F17:27766D:375033:6AFB52C9
html-safe-nonce568bc2223ca3ff238341db54c23c8b048a60c6d9c9640f9346b49976c242bbf0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjI2OjE2MEYxNzoyNzc2NkQ6Mzc1MDMzOjZBRkI1MkM5IiwidmlzaXRvcl9pZCI6IjMzNDUxOTg3MDgzNjE0ODI5NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac830f6d3797c4334910670e3f7ba49e80ed74b21c25a93868abfe8312b36e36e7
hovercard-subject-tagpull_request:4753764861
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8662/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Raised by cubic on the release PR: #8654 (comment) On a new chat, the first send captures the effort pick (X) and the server stores it on the chat it opens. If the user changes the picker t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8662/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8662%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8662%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8662/files
Reloadhttps://github.com/simstudioai/sim/pull/8662/files
Reloadhttps://github.com/simstudioai/sim/pull/8662/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/effort-pick-pending-sendhttps://github.com/simstudioai/sim/tree/fix/effort-pick-pending-send
Conversation 26 https://github.com/simstudioai/sim/pull/8662
Commits 3 https://github.com/simstudioai/sim/pull/8662/commits
Checks 32 https://github.com/simstudioai/sim/pull/8662/checks
Files changed https://github.com/simstudioai/sim/pull/8662/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8662/files
fix(mothership): keep a new chat's effort pick changed while its first send is pending https://github.com/simstudioai/sim/pull/8662/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8662/files
da2c8f7 fix(mothership): keep a new chat's effort pick changed while its firs… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8662/commits/da2c8f75457f6123e4ee4cc17800ec16ed473a82
4cb509c fix(mothership): keep effort saves per chat and save the pick on dedu… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8662/commits/4cb509c78a9a93358b581e472e77dd47c997dac0
320f99f fix(mothership): detach the effort save observer once it settles waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8662/commits/320f99f5605799329309e6a8ed10153eeff5c46b
Clear filters https://github.com/simstudioai/sim/pull/8662/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8662/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8662/files
use-chat.dom.test.tsx https://github.com/simstudioai/sim/pull/8662/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
use-chat.ts https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
mothership-chats.ts https://github.com/simstudioai/sim/pull/8662/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.dom.test.tsxhttps://github.com/simstudioai/sim/pull/8662/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
View file https://github.com/simstudioai/sim/blob/320f99f5605799329309e6a8ed10153eeff5c46b/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.dom.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8662/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8662/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8662/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
https://github.com/simstudioai/sim/pull/8662/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
Please reload this pagehttps://github.com/simstudioai/sim/pull/8662/files
https://github.com/simstudioai/sim/pull/8662/files#diff-f13f1eaa18b785ec858b76bfef8952fc11d2c6730951634aad2c3bf4e167e62e
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.tshttps://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
View file https://github.com/simstudioai/sim/blob/320f99f5605799329309e6a8ed10153eeff5c46b/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8662/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8662/files
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8662/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
apps/sim/hooks/queries/mothership-chats.tshttps://github.com/simstudioai/sim/pull/8662/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
View file https://github.com/simstudioai/sim/blob/320f99f5605799329309e6a8ed10153eeff5c46b/apps/sim/hooks/queries/mothership-chats.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8662/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8662/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
https://github.com/simstudioai/sim/pull/8662/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
https://github.com/simstudioai/sim/pull/8662/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
https://github.com/simstudioai/sim/pull/8662/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
Please reload this pagehttps://github.com/simstudioai/sim/pull/8662/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.