René's URL Explorer Experiment


Title: fix(executor): unwrap boxed primitives by internal slot when checking JSON serializability by waleedlatif1 · Pull Request #8658 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): unwrap boxed primitives by internal slot when checking JSON serializability by waleedlatif1 · Pull Request #8658 · simstudioai/sim

X Title: fix(executor): unwrap boxed primitives by internal slot when checking JSON serializability by waleedlatif1 · Pull Request #8658 · simstudioai/sim

Description: Summary assertJsonSerializable (completed-run execution state) and getJsonByteSize (execution-log sizing) recognized primitive wrappers with instanceof, while JSON.stringify decides by internal slot. They disagreed with native serialization for objects that only inherit from a wrapper prototype (Object.create(BigInt.prototype) was rejected; Object.create(Number.prototype) hid its own properties, so a cycle or BigInt inside passed) and for wrappers whose prototype was swapped New unboxJsonPrimitive (lib/core/utils/boxed-primitives.ts) unwraps by slot via node:util types checks (no Proxy traps run): Number/String through ToNumber/ToString (unary + / template literal, which throw where JSON does), Boolean/BigInt by stored value. Both walkers use it Type of Change Bug fix Testing snapshot-serializer.test.ts: parity cases against the JSON-cloned pause state (an object that only inherits from BigInt serializes; a cycle in an object that only inherits from Number and a BigInt wrapper with a swapped prototype throw) — fail on staging, pass with the fix json-byte-size.test.ts: objects inheriting from wrapper prototypes and a Number wrapper with a swapped prototype measure exactly like JSON.stringify — fail on staging, pass with the fix Further parity cases: a BigInt wrapper with its prototype reset to Object.prototype, a Number wrapper converting to a BigInt, and a proxy whose getPrototypeOf trap throws getJsonByteSize on a 2.7 MB payload: within 1 ms of staging (min of interleaved runs) Root bun run test (all tests pass; timeouts under heavy local load re-run green in isolation), bun run lint, bun run type-check, bun run check:audits, check-block-registry.ts origin/staging, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary assertJsonSerializable (completed-run execution state) and getJsonByteSize (execution-log sizing) recognized primitive wrappers with instanceof, while JSON.stringify decides by internal sl...

X Description: Summary assertJsonSerializable (completed-run execution state) and getJsonByteSize (execution-log sizing) recognized primitive wrappers with instanceof, while JSON.stringify decides by internal sl...

Opengraph URL: https://github.com/simstudioai/sim/pull/8658

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eb71cf9c-61f3-b9de-106f-31d1406b42a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE258:1C88A1:9BA583:DCF112:6AFB51D6
html-safe-nonceabe89316649847c421c74cff97d49d043738a36d5c9303a7d879d22614f26b9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjU4OjFDODhBMTo5QkE1ODM6RENGMTEyOjZBRkI1MUQ2IiwidmlzaXRvcl9pZCI6IjgyNzg1Njg3MjM0NjgyMTA2NDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7d8c954afb3a6c9f7c335a3450be11e378fbc8a51220d8267dbef8acc05f2435
hovercard-subject-tagpull_request:4753625300
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8658/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary assertJsonSerializable (completed-run execution state) and getJsonByteSize (execution-log sizing) recognized primitive wrappers with instanceof, while JSON.stringify decides by internal sl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8658/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8658%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8658%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8658/files
Reloadhttps://github.com/simstudioai/sim/pull/8658/files
Reloadhttps://github.com/simstudioai/sim/pull/8658/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/json-walkers-boxed-slotshttps://github.com/simstudioai/sim/tree/fix/json-walkers-boxed-slots
Conversation 12 https://github.com/simstudioai/sim/pull/8658
Commits 2 https://github.com/simstudioai/sim/pull/8658/commits
Checks 33 https://github.com/simstudioai/sim/pull/8658/checks
Files changed https://github.com/simstudioai/sim/pull/8658/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8658/files
fix(executor): unwrap boxed primitives by internal slot when checking JSON serializability https://github.com/simstudioai/sim/pull/8658/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8658/files
a55d0c3 fix(executor): unwrap boxed primitives by internal slot when checking… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8658/commits/a55d0c3e3a2de364a9f8cb8eed3d6d0329aeb329
9d8378a fix(executor): check the boxed slot first and convert wrappers with T… waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8658/commits/9d8378aebbcae3c976ab4b9bda5178656aebab66
Clear filters https://github.com/simstudioai/sim/pull/8658/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8658/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8658/files
snapshot-serializer.test.ts https://github.com/simstudioai/sim/pull/8658/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
snapshot-serializer.ts https://github.com/simstudioai/sim/pull/8658/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
boxed-primitives.ts https://github.com/simstudioai/sim/pull/8658/files#diff-cd4e732763ebe2d6dd7cb2e62ad2430177a03b6921ca3a44ab92e2dd7fa5d5cf
json-byte-size.test.ts https://github.com/simstudioai/sim/pull/8658/files#diff-e59b4f896dde5ef1224a21efea22a37864e3f896c595493c7c230f9d41baadb7
json-byte-size.ts https://github.com/simstudioai/sim/pull/8658/files#diff-f4f9509e73bcf18b1655be4d4455d7c265f1959dd979a619ce8f4d0a34c3659e
apps/sim/executor/execution/snapshot-serializer.test.tshttps://github.com/simstudioai/sim/pull/8658/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
View file https://github.com/simstudioai/sim/blob/9d8378aebbcae3c976ab4b9bda5178656aebab66/apps/sim/executor/execution/snapshot-serializer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8658/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8658/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
https://github.com/simstudioai/sim/pull/8658/files#diff-cca2c61442682126a042f9f4c1960194d8d280b290a15d3418be3ab5d8a9e4c0
apps/sim/executor/execution/snapshot-serializer.tshttps://github.com/simstudioai/sim/pull/8658/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
View file https://github.com/simstudioai/sim/blob/9d8378aebbcae3c976ab4b9bda5178656aebab66/apps/sim/executor/execution/snapshot-serializer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8658/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8658/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
https://github.com/simstudioai/sim/pull/8658/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
https://github.com/simstudioai/sim/pull/8658/files#diff-286b94d0dccf44786a3521cfa8c89356d4c9527067384c199248493c4d6a9a9b
apps/sim/lib/core/utils/boxed-primitives.tshttps://github.com/simstudioai/sim/pull/8658/files#diff-cd4e732763ebe2d6dd7cb2e62ad2430177a03b6921ca3a44ab92e2dd7fa5d5cf
View file https://github.com/simstudioai/sim/blob/9d8378aebbcae3c976ab4b9bda5178656aebab66/apps/sim/lib/core/utils/boxed-primitives.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8658/{{ revealButtonHref }}
apps/sim/lib/logs/execution/json-byte-size.test.tshttps://github.com/simstudioai/sim/pull/8658/files#diff-e59b4f896dde5ef1224a21efea22a37864e3f896c595493c7c230f9d41baadb7
View file https://github.com/simstudioai/sim/blob/9d8378aebbcae3c976ab4b9bda5178656aebab66/apps/sim/lib/logs/execution/json-byte-size.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8658/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8658/files#diff-e59b4f896dde5ef1224a21efea22a37864e3f896c595493c7c230f9d41baadb7
https://github.com/simstudioai/sim/pull/8658/files#diff-e59b4f896dde5ef1224a21efea22a37864e3f896c595493c7c230f9d41baadb7
apps/sim/lib/logs/execution/json-byte-size.tshttps://github.com/simstudioai/sim/pull/8658/files#diff-f4f9509e73bcf18b1655be4d4455d7c265f1959dd979a619ce8f4d0a34c3659e
View file https://github.com/simstudioai/sim/blob/9d8378aebbcae3c976ab4b9bda5178656aebab66/apps/sim/lib/logs/execution/json-byte-size.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8658/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8658/files#diff-f4f9509e73bcf18b1655be4d4455d7c265f1959dd979a619ce8f4d0a34c3659e
https://github.com/simstudioai/sim/pull/8658/files#diff-f4f9509e73bcf18b1655be4d4455d7c265f1959dd979a619ce8f4d0a34c3659e
https://github.com/simstudioai/sim/pull/8658/files#diff-f4f9509e73bcf18b1655be4d4455d7c265f1959dd979a619ce8f4d0a34c3659e
Please reload this pagehttps://github.com/simstudioai/sim/pull/8658/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.