René's URL Explorer Experiment


Title: fix(mothership): roll back a failed effort save by pick, not by value by waleedlatif1 · Pull Request #8655 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): roll back a failed effort save by pick, not by value by waleedlatif1 · Pull Request #8655 · simstudioai/sim

X Title: fix(mothership): roll back a failed effort save by pick, not by value by waleedlatif1 · Pull Request #8655 · simstudioai/sim

Description: Summary Fixes the race cubic found on the release PR: #8654 (comment) useSetMothershipChatEffort runs one save per chat at a time through a mutation scope. TanStack still runs onMutate right away for a save that is queued behind that scope, so later picks write the store before the first request settles. onError then rolled the pick back by value: dropChatEffort cleared the store only when the stored effort equalled the failed one. Failure scenario: pick low (save 1 in flight), then high, then low. Save 1 fails. The store holds the newest low, which matches the failed value, so it is dropped. The picker falls back to the chat's stale server effort, and a send made then saves and runs that stale effort. It corrects itself once the queued saves succeed. Severity: low to medium. It needs a failed save plus a repeat pick inside the window, and it heals on its own. While it lasts, though, a turn can run at an effort the user did not pick. Fix The store now rolls a pick back by identity instead of by value. stores/mothership-effort/store.ts: each chatEfforts entry is { effort, pick }, where pick is a session-wide monotonic token. setChatEffort returns the token. dropChatEffort(chatId, pick) deletes the entry only while that token is still the stored one. adoptNewChatEffort also stamps a fresh token. Nothing new is persisted: partialize still stores only modelSelection. hooks/queries/mothership-chats.ts: onMutate returns { pick } as the mutation context, and onError drops context.pick. model-selector.tsx and use-chat.ts: the two readers now read chatEfforts[chatId]?.effort. Test plan store.test.ts: set low, high, low, then drop the first token; low remains. Dropping the current token deletes the entry. A stale token does not clear an adopted new-chat pick. mothership-chats.test.ts: drives the hook's real mutation options through a real TanStack MutationObserver with controlled request promises. It calls low, high, low, fails request 1, and asserts the pick is still low both then and after the queued saves settle. Both regression tests fail on the pre-fix code (expected undefined to be 'low'). bun run lint, bun run type-check and bun run check:audits (58/58) pass, along with the affected suites (composer, use-chat, user-input, the store and the hook).

Open Graph Description: Summary Fixes the race cubic found on the release PR: #8654 (comment) useSetMothershipChatEffort runs one save per chat at a time through a mutation scope. TanStack still runs onMutate right away f...

X Description: Summary Fixes the race cubic found on the release PR: #8654 (comment) useSetMothershipChatEffort runs one save per chat at a time through a mutation scope. TanStack still runs onMutate right away f...

Opengraph URL: https://github.com/simstudioai/sim/pull/8655

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a9ce0620-4c0c-963f-9c9b-7dfadca36746
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEB4:27DCD7:B7344C:FA79E3:6AFB515D
html-safe-nonce95965822e9e4b5e97f947e2310158b2e73cca66522041bd4597199486a03d42f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUI0OjI3RENENzpCNzM0NEM6RkE3OUUzOjZBRkI1MTVEIiwidmlzaXRvcl9pZCI6IjIwNzk0NDg4MzgwOTA0Nzc5MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacabd380cb3e9e96b6b2e71f6b455424a04709c562811711d58c1ec4323556840f
hovercard-subject-tagpull_request:4753471230
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8655/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Fixes the race cubic found on the release PR: #8654 (comment) useSetMothershipChatEffort runs one save per chat at a time through a mutation scope. TanStack still runs onMutate right away f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8655/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8655%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8655%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8655/files
Reloadhttps://github.com/simstudioai/sim/pull/8655/files
Reloadhttps://github.com/simstudioai/sim/pull/8655/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/effort-pick-rollback-identityhttps://github.com/simstudioai/sim/tree/fix/effort-pick-rollback-identity
Conversation 5 https://github.com/simstudioai/sim/pull/8655
Commits 1 https://github.com/simstudioai/sim/pull/8655/commits
Checks 32 https://github.com/simstudioai/sim/pull/8655/checks
Files changed https://github.com/simstudioai/sim/pull/8655/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8655/files
fix(mothership): roll back a failed effort save by pick, not by value https://github.com/simstudioai/sim/pull/8655/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8655/files
a18bbc8 fix(mothership): roll back a failed effort save by pick, not by value waleedlatif1 Oct 6, 2026 https://github.com/simstudioai/sim/pull/8655/commits/a18bbc8c7e0b15b03bd46944496ba3dfe8978fff
Clear filters https://github.com/simstudioai/sim/pull/8655/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8655/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8655/files
model-selector.tsx https://github.com/simstudioai/sim/pull/8655/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
use-chat.ts https://github.com/simstudioai/sim/pull/8655/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
mothership-chats.test.ts https://github.com/simstudioai/sim/pull/8655/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
mothership-chats.ts https://github.com/simstudioai/sim/pull/8655/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
store.test.ts https://github.com/simstudioai/sim/pull/8655/files#diff-9f25ce952c158c1b1d17b0ebd9896f8712df77bf546f281adf4da396fc747886
store.ts https://github.com/simstudioai/sim/pull/8655/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
.../sim/app/workspace/[workspaceId]/home/components/user-input/components/model-selector.tsxhttps://github.com/simstudioai/sim/pull/8655/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
View file https://github.com/simstudioai/sim/blob/a18bbc8c7e0b15b03bd46944496ba3dfe8978fff/apps/sim/app/workspace/%5BworkspaceId%5D/home/components/user-input/components/model-selector.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8655/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8655/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
https://github.com/simstudioai/sim/pull/8655/files#diff-5a757ddbae59660a55408f377bbb677b658adbbcff43675423dd03f39d5ffdd4
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.tshttps://github.com/simstudioai/sim/pull/8655/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
View file https://github.com/simstudioai/sim/blob/a18bbc8c7e0b15b03bd46944496ba3dfe8978fff/apps/sim/app/workspace/%5BworkspaceId%5D/home/hooks/use-chat.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8655/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8655/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
https://github.com/simstudioai/sim/pull/8655/files#diff-1a0584ccf9cc4bacd55ce19aeeea8d807c39f36c365fa5b6638587aad38c700d
apps/sim/hooks/queries/mothership-chats.test.tshttps://github.com/simstudioai/sim/pull/8655/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
View file https://github.com/simstudioai/sim/blob/a18bbc8c7e0b15b03bd46944496ba3dfe8978fff/apps/sim/hooks/queries/mothership-chats.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8655/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8655/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
https://github.com/simstudioai/sim/pull/8655/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
https://github.com/simstudioai/sim/pull/8655/files#diff-d98e509113958ce4f2b40df87695287e3b70124eb675fd7f2a6180dbde0b10ea
apps/sim/hooks/queries/mothership-chats.tshttps://github.com/simstudioai/sim/pull/8655/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
View file https://github.com/simstudioai/sim/blob/a18bbc8c7e0b15b03bd46944496ba3dfe8978fff/apps/sim/hooks/queries/mothership-chats.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8655/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8655/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
https://github.com/simstudioai/sim/pull/8655/files#diff-d93326dc7ad3c0d6856933a9ba910634ba50d1e7c3292f43f7aaa85ca2979311
apps/sim/stores/mothership-effort/store.test.tshttps://github.com/simstudioai/sim/pull/8655/files#diff-9f25ce952c158c1b1d17b0ebd9896f8712df77bf546f281adf4da396fc747886
View file https://github.com/simstudioai/sim/blob/a18bbc8c7e0b15b03bd46944496ba3dfe8978fff/apps/sim/stores/mothership-effort/store.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8655/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8655/files#diff-9f25ce952c158c1b1d17b0ebd9896f8712df77bf546f281adf4da396fc747886
apps/sim/stores/mothership-effort/store.tshttps://github.com/simstudioai/sim/pull/8655/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
View file https://github.com/simstudioai/sim/blob/a18bbc8c7e0b15b03bd46944496ba3dfe8978fff/apps/sim/stores/mothership-effort/store.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8655/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8655/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
https://github.com/simstudioai/sim/pull/8655/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
https://github.com/simstudioai/sim/pull/8655/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
https://github.com/simstudioai/sim/pull/8655/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
https://github.com/simstudioai/sim/pull/8655/files#diff-08089d9f00e9355828629c2237ef32b4a0f6def9914fde7ac99d982bcdd387c6
Please reload this pagehttps://github.com/simstudioai/sim/pull/8655/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.