René's URL Explorer Experiment


Title: fix(executor): fail a stop-after run whose routing skips the stop block by waleedlatif1 · Pull Request #8635 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): fail a stop-after run whose routing skips the stop block by waleedlatif1 · Pull Request #8635 · simstudioai/sim

X Title: fix(executor): fail a stop-after run whose routing skips the stop block by waleedlatif1 · Pull Request #8635 · simstudioai/sim

Description: Summary Follow-up to #8622. A stop-after run only stopped when the stop block completed. When a router, condition, or untaken error path routed the run away from that block, the stop never triggered. The run then finished every other branch and reported success as if it had stopped there. A check before the run can't see this. The engine now ends the run as soon as every path into the stop block has been deactivated, before any further block starts. It fails the run with Stop block "" () was not reached: no path this run took leads to it. The decision reuses the edge manager's own readiness state through the new EdgeManager.canNodeStillRun, so it is the same decision that would otherwise leave the block unqueued. Any run that ends without completing its stop block fails the same way. That covers a stop block missing from the executed graph, and a Response block that ended the run first (the error says so). A run whose stop block is proven unreachable fails even if another branch paused, so it can't resume past the stop block. A loop or parallel stop with nothing to run exits from its start sentinel, and its end sentinel never runs. That exit now counts as reaching the stop. Before, this case also ran the rest of the workflow. Callers: CLI --stop-after and the v2 API: get status: failed with the message, and the CLI exits non-zero. Copilot run_workflow_until_block: returns a failed tool result with the message, where it used to return success with stoppedAfterBlockId. UI "run until here": shows the run error in place of a silent full run. run_block (entry == stop): unchanged. The v2 contract description and the --stop-after help (plus generated OpenAPI and CLI docs) describe the failure. Type of Change Bug fix Testing executor/execution/engine.test.ts: new stop-after cases run the real DAG builder and edge manager: condition, router and untaken error path routing away from the stop block; a stop block missing from the graph; a Response block ending the run before the stop block; another branch pausing after the stop block is skipped; an empty loop as the stop block; positive controls: the stop block on the taken branch, a join with one skipped input, the entry as the stop block, and a loop stop block queued by a dead end inside the loop. Six of these failed on the pre-fix engine. I also reverted each guard on its own (the queued flag, the early stop, the final check, the Response mark, the empty-subflow exit), and each revert turned its named test red. scripts/test-workflow-stop-after-e2e.ts gains a condition fixture, run against a self-hosted app on a disposable Postgres: stop on the taken branch: completes; stop on the skipped branch: fails in under 2s, well before the other branch's 4s block would finish; the CLI exits non-zero for the same run. The new E2E check failed on the pre-fix engine: the run came back completed. All 11 checks pass with the fix. bun run lint, type-check, check:audits, docs-manifest:check, block-registry check: pass. bun run test: all workspaces pass. One unrelated markdown-parser test timed out under machine load and passes when run on its own. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #8622. A stop-after run only stopped when the stop block completed. When a router, condition, or untaken error path routed the run away from that block, the stop never trigger...

X Description: Summary Follow-up to #8622. A stop-after run only stopped when the stop block completed. When a router, condition, or untaken error path routed the run away from that block, the stop never trigger...

Opengraph URL: https://github.com/simstudioai/sim/pull/8635

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cf278522-fce8-b952-ec93-b9e710ba5cb2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8D2:2BF3D1:219D4A:2F1600:6AFB5139
html-safe-noncea7631a357eeb15e8bf74f99a5b35fab801fb1b0eea3fe1fc1e1cfb3e2a17c75d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEQyOjJCRjNEMToyMTlENEE6MkYxNjAwOjZBRkI1MTM5IiwidmlzaXRvcl9pZCI6IjgxNTM1MDcxNjk5NTg1ODA1MzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb0656366bf8054d8b7f4a09bbf340f1ac90f12c47ca6660774ee9e122ee32019
hovercard-subject-tagpull_request:4751355341
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8635/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #8622. A stop-after run only stopped when the stop block completed. When a router, condition, or untaken error path routed the run away from that block, the stop never trigger...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8635/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8635%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8635%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8635/files
Reloadhttps://github.com/simstudioai/sim/pull/8635/files
Reloadhttps://github.com/simstudioai/sim/pull/8635/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/stop-after-unreachedhttps://github.com/simstudioai/sim/tree/fix/stop-after-unreached
Conversation 14 https://github.com/simstudioai/sim/pull/8635
Commits 2 https://github.com/simstudioai/sim/pull/8635/commits
Checks 33 https://github.com/simstudioai/sim/pull/8635/checks
Files changed https://github.com/simstudioai/sim/pull/8635/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8635/files
fix(executor): fail a stop-after run whose routing skips the stop block https://github.com/simstudioai/sim/pull/8635/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8635/files
7f3d93c fix(executor): fail a stop-after run whose routing skips the stop block waleedlatif1 Oct 5, 2026 https://github.com/simstudioai/sim/pull/8635/commits/7f3d93c9685e9df2f0c6ade8550722b233bc51a0
f88df6f fix(executor): a skipped stop block fails a run another branch paused… waleedlatif1 Oct 5, 2026 https://github.com/simstudioai/sim/pull/8635/commits/f88df6fb0bd3ba88569a1166d0bbd524a6790a2d
Clear filters https://github.com/simstudioai/sim/pull/8635/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8635/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8635/files
reference.mdx https://github.com/simstudioai/sim/pull/8635/files#diff-2ef1dc35e44a2520b34fb146c4103e9d7cf235e4e4937315a5b40a7db6338406
workflows.mdx https://github.com/simstudioai/sim/pull/8635/files#diff-b38b4f49b582ee25593d5da516070296ade6a399be50daab25d6d8c050831863
openapi-v2-workflows.json https://github.com/simstudioai/sim/pull/8635/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
edge-manager.ts https://github.com/simstudioai/sim/pull/8635/files#diff-31af7b84e53d32b76100ab24c086787ba27a04b37bb5007839b1388f6fb518ec
engine.test.ts https://github.com/simstudioai/sim/pull/8635/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
engine.ts https://github.com/simstudioai/sim/pull/8635/files#diff-8fc33da0f336e4f8e9c4cef6bdcb2297ffb3bc693d739245b28cde225130de22
workflows.ts https://github.com/simstudioai/sim/pull/8635/files#diff-7c1b6e587b506ea981d107bc7496349fd5020fd823e34f9c13d70f6845829728
test-workflow-stop-after-e2e.ts https://github.com/simstudioai/sim/pull/8635/files#diff-46adaa7586b0c54606b35b539ca6155c1d25fedc8582f6d9792d3ca32a2650f7
workflow-run-follow.ts https://github.com/simstudioai/sim/pull/8635/files#diff-5795113268fa862ce81100d28510ba1b686a0118586407ceb5c7e569ab4ff5a5
apps/docs/content/docs/cli/reference.mdxhttps://github.com/simstudioai/sim/pull/8635/files#diff-2ef1dc35e44a2520b34fb146c4103e9d7cf235e4e4937315a5b40a7db6338406
View file https://github.com/simstudioai/sim/blob/f88df6fb0bd3ba88569a1166d0bbd524a6790a2d/apps/docs/content/docs/cli/reference.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8635/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8635/files#diff-2ef1dc35e44a2520b34fb146c4103e9d7cf235e4e4937315a5b40a7db6338406
https://github.com/simstudioai/sim/pull/8635/files#diff-2ef1dc35e44a2520b34fb146c4103e9d7cf235e4e4937315a5b40a7db6338406
apps/docs/content/docs/cli/workflows.mdxhttps://github.com/simstudioai/sim/pull/8635/files#diff-b38b4f49b582ee25593d5da516070296ade6a399be50daab25d6d8c050831863
View file https://github.com/simstudioai/sim/blob/f88df6fb0bd3ba88569a1166d0bbd524a6790a2d/apps/docs/content/docs/cli/workflows.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8635/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8635/files#diff-b38b4f49b582ee25593d5da516070296ade6a399be50daab25d6d8c050831863
https://github.com/simstudioai/sim/pull/8635/files#diff-b38b4f49b582ee25593d5da516070296ade6a399be50daab25d6d8c050831863
apps/docs/openapi-v2-workflows.jsonhttps://github.com/simstudioai/sim/pull/8635/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
View file https://github.com/simstudioai/sim/blob/f88df6fb0bd3ba88569a1166d0bbd524a6790a2d/apps/docs/openapi-v2-workflows.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8635/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8635/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
https://github.com/simstudioai/sim/pull/8635/files#diff-811f737e7f97ec52156a37e71892822626b5b4de295efebd20992198d162149b
apps/sim/executor/execution/edge-manager.tshttps://github.com/simstudioai/sim/pull/8635/files#diff-31af7b84e53d32b76100ab24c086787ba27a04b37bb5007839b1388f6fb518ec
View file https://github.com/simstudioai/sim/blob/f88df6fb0bd3ba88569a1166d0bbd524a6790a2d/apps/sim/executor/execution/edge-manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8635/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8635/files#diff-31af7b84e53d32b76100ab24c086787ba27a04b37bb5007839b1388f6fb518ec
https://github.com/simstudioai/sim/pull/8635/files#diff-31af7b84e53d32b76100ab24c086787ba27a04b37bb5007839b1388f6fb518ec
apps/sim/executor/execution/engine.test.tshttps://github.com/simstudioai/sim/pull/8635/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
View file https://github.com/simstudioai/sim/blob/f88df6fb0bd3ba88569a1166d0bbd524a6790a2d/apps/sim/executor/execution/engine.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8635/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8635/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
https://github.com/simstudioai/sim/pull/8635/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
https://github.com/simstudioai/sim/pull/8635/files#diff-8a7dc7d2027ef09942b6480f995b1175f4f22ecbd015133850cb9f2dbc3df51e
Please reload this pagehttps://github.com/simstudioai/sim/pull/8635/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8635/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.