René's URL Explorer Experiment


Title: fix(mcp): restrict MCP server destination changes to admins by TheodoreSpeaks · Pull Request #8629 · simstudioai/sim · GitHub

Open Graph Title: fix(mcp): restrict MCP server destination changes to admins by TheodoreSpeaks · Pull Request #8629 · simstudioai/sim

X Title: fix(mcp): restrict MCP server destination changes to admins by TheodoreSpeaks · Pull Request #8629 · simstudioai/sim

Description: Summary Changing an MCP server's destination (origin or path) now requires workspace admin; query-string edits and every other field stay at write Enforced in updateMcpServer via a required allowDestinationChange flag, so the settings PATCH route, the Copilot edit, and the v2 update all hit the same check Use cases authorize the new admin-only mcp_servers.change_destination operation before writing; the legacy route derives the flag from the caller's role Registering a server whose hashed id collides with an existing row at a different destination is now refused instead of repointing that row Type of Change Bug fix Testing Unit tests for writer refusal, admin path, query-string-only edits, route role mapping, and the id-collision refusal bun run lint, bun run check:audits, block registry and docs-manifest checks pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code https://claude.ai/code/session_01QFCu7AdYKDS9qmX4qaJg2e

Open Graph Description: Summary Changing an MCP server's destination (origin or path) now requires workspace admin; query-string edits and every other field stay at write Enforced in updateMcpServer via a required al...

X Description: Summary Changing an MCP server's destination (origin or path) now requires workspace admin; query-string edits and every other field stay at write Enforced in updateMcpServer via a require...

Opengraph URL: https://github.com/simstudioai/sim/pull/8629

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a308074e-58d9-12d4-2e87-8cf8d2714965
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8E8:375283:220EF2:2F9A33:6AFB513D
html-safe-nonce45b954c85e99736d2cfe02fefed776aa33de23648f11ce423b2eae1119ad4cb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEU4OjM3NTI4MzoyMjBFRjI6MkY5QTMzOjZBRkI1MTNEIiwidmlzaXRvcl9pZCI6IjExNjE3MDM0MDAyNjIwMjk2MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2a0c3b69aacb7aecb7e4519e954c153d502475dc84a2095b667f9ad9d5537bbc
hovercard-subject-tagpull_request:4749173799
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8629/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary Changing an MCP server's destination (origin or path) now requires workspace admin; query-string edits and every other field stay at write Enforced in updateMcpServer via a required al...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8629/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8629%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8629%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8629/files
Reloadhttps://github.com/simstudioai/sim/pull/8629/files
Reloadhttps://github.com/simstudioai/sim/pull/8629/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
TheodoreSpeakshttps://github.com/TheodoreSpeaks
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mcp-secret-exfilhttps://github.com/simstudioai/sim/tree/fix/mcp-secret-exfil
Conversation 41 https://github.com/simstudioai/sim/pull/8629
Commits 6 https://github.com/simstudioai/sim/pull/8629/commits
Checks 32 https://github.com/simstudioai/sim/pull/8629/checks
Files changed https://github.com/simstudioai/sim/pull/8629/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8629/files
fix(mcp): restrict MCP server destination changes to admins https://github.com/simstudioai/sim/pull/8629/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/8629/files
c49185e fix(mcp): restrict MCP server destination changes to admins TheodoreSpeaks Oct 5, 2026 https://github.com/simstudioai/sim/pull/8629/commits/c49185e335703afc7c58e1cc86fa06e3fffa2625
b2d3e67 fix(mcp): compare exact MCP paths and guard concurrent URL changes TheodoreSpeaks Oct 5, 2026 https://github.com/simstudioai/sim/pull/8629/commits/b2d3e673e723fbb943dde4fe3b9daa57bbd01077
1fce014 fix(mcp): treat setting a URL on a URL-less server as a destination c… TheodoreSpeaks Oct 5, 2026 https://github.com/simstudioai/sim/pull/8629/commits/1fce0141db72c7dd7b9caa407a70de6d7eb4425d
850a0e1 fix(mcp): guard re-registration against concurrent URL changes TheodoreSpeaks Oct 5, 2026 https://github.com/simstudioai/sim/pull/8629/commits/850a0e1edcf05b552cdcd07fbb894945c6bcacf3
7609e3d fix(mcp): narrow re-registration URL before the guarded update TheodoreSpeaks Oct 5, 2026 https://github.com/simstudioai/sim/pull/8629/commits/7609e3dcdf6d54eb261ebab5893087cf1bd24043
fd39edd chore(mcp): use absolute import in utils test TheodoreSpeaks Oct 5, 2026 https://github.com/simstudioai/sim/pull/8629/commits/fd39eddcb8b870be68a7d75d656778076df0bd61
Clear filters https://github.com/simstudioai/sim/pull/8629/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8629/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8629/files
route.ts https://github.com/simstudioai/sim/pull/8629/files#diff-5a62b860ebf77872185f9b923884f3b74a93d7d39c9575ee53c892b6e0070bac
operations.test.ts https://github.com/simstudioai/sim/pull/8629/files#diff-a2e06e0a6f163fd46c6ff8b5fe496e9462d084d0ce391b20eaf24747b8bc3a23
operations.ts https://github.com/simstudioai/sim/pull/8629/files#diff-c9350c388c0e53d823cdd1f08f7a0d904d568d3faa279b2a79c0c6da9c183d00
use-cases.test.ts https://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
use-cases.ts https://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
server-lifecycle.test.ts https://github.com/simstudioai/sim/pull/8629/files#diff-67f6d21d4ca70f641992cb737b97f58b22cdbe2c804878d6fb2cc2e77bebbc50
server-lifecycle.ts https://github.com/simstudioai/sim/pull/8629/files#diff-0680f8bc617e13ef336c024a3a18671af0b7fd2658f55f5de274b33a97de9581
utils.test.ts https://github.com/simstudioai/sim/pull/8629/files#diff-9513abf5f55ac7ccad8953c0baee77dbc7122bd798fbb36133ec7941c7e34173
utils.ts https://github.com/simstudioai/sim/pull/8629/files#diff-3e3a2ab59257f1f643c0bfcbb46e4acb6a9ac29cb0906aa9c4d9d9a05e8852a4
check-unused-exports.baseline.json https://github.com/simstudioai/sim/pull/8629/files#diff-4b59a8526a4f226dffb0fbf6b8ec25d3082ab45da697f584eaaca4bd483c928f
apps/sim/app/api/mcp/servers/[id]/route.tshttps://github.com/simstudioai/sim/pull/8629/files#diff-5a62b860ebf77872185f9b923884f3b74a93d7d39c9575ee53c892b6e0070bac
View file https://github.com/simstudioai/sim/blob/fd39eddcb8b870be68a7d75d656778076df0bd61/apps/sim/app/api/mcp/servers/%5Bid%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8629/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8629/files#diff-5a62b860ebf77872185f9b923884f3b74a93d7d39c9575ee53c892b6e0070bac
https://github.com/simstudioai/sim/pull/8629/files#diff-5a62b860ebf77872185f9b923884f3b74a93d7d39c9575ee53c892b6e0070bac
https://github.com/simstudioai/sim/pull/8629/files#diff-5a62b860ebf77872185f9b923884f3b74a93d7d39c9575ee53c892b6e0070bac
https://github.com/simstudioai/sim/pull/8629/files#diff-5a62b860ebf77872185f9b923884f3b74a93d7d39c9575ee53c892b6e0070bac
apps/sim/lib/mcp/application/operations.test.tshttps://github.com/simstudioai/sim/pull/8629/files#diff-a2e06e0a6f163fd46c6ff8b5fe496e9462d084d0ce391b20eaf24747b8bc3a23
View file https://github.com/simstudioai/sim/blob/fd39eddcb8b870be68a7d75d656778076df0bd61/apps/sim/lib/mcp/application/operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8629/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8629/files#diff-a2e06e0a6f163fd46c6ff8b5fe496e9462d084d0ce391b20eaf24747b8bc3a23
https://github.com/simstudioai/sim/pull/8629/files#diff-a2e06e0a6f163fd46c6ff8b5fe496e9462d084d0ce391b20eaf24747b8bc3a23
apps/sim/lib/mcp/application/operations.tshttps://github.com/simstudioai/sim/pull/8629/files#diff-c9350c388c0e53d823cdd1f08f7a0d904d568d3faa279b2a79c0c6da9c183d00
View file https://github.com/simstudioai/sim/blob/fd39eddcb8b870be68a7d75d656778076df0bd61/apps/sim/lib/mcp/application/operations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8629/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8629/files#diff-c9350c388c0e53d823cdd1f08f7a0d904d568d3faa279b2a79c0c6da9c183d00
https://github.com/simstudioai/sim/pull/8629/files#diff-c9350c388c0e53d823cdd1f08f7a0d904d568d3faa279b2a79c0c6da9c183d00
apps/sim/lib/mcp/application/use-cases.test.tshttps://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
View file https://github.com/simstudioai/sim/blob/fd39eddcb8b870be68a7d75d656778076df0bd61/apps/sim/lib/mcp/application/use-cases.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8629/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
https://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
https://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
https://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
https://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
https://github.com/simstudioai/sim/pull/8629/files#diff-7d5036981793e08692d33fc52edcb05fbd3921307b6eae1a203db9eac77a7d8d
apps/sim/lib/mcp/application/use-cases.tshttps://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
View file https://github.com/simstudioai/sim/blob/fd39eddcb8b870be68a7d75d656778076df0bd61/apps/sim/lib/mcp/application/use-cases.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8629/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
https://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
https://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
https://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
https://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
Please reload this pagehttps://github.com/simstudioai/sim/pull/8629/files
https://github.com/simstudioai/sim/pull/8629/files#diff-35be730cbfeea492e794ed88cbcc97422fd7fd3aecc227c7972a8f6e81296cc9
Please reload this pagehttps://github.com/simstudioai/sim/pull/8629/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8629/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.