René's URL Explorer Experiment


Title: fix(code-placeholders): reject shell arithmetic placeholders by icecrasher321 · Pull Request #8628 · simstudioai/sim · GitHub

Open Graph Title: fix(code-placeholders): reject shell arithmetic placeholders by icecrasher321 · Pull Request #8628 · simstudioai/sim

X Title: fix(code-placeholders): reject shell arithmetic placeholders by icecrasher321 · Pull Request #8628 · simstudioai/sim

Description: Summary Reject resolved shell placeholders inside $((...)), $[...], and ((...)) (including arithmetic for headers) before sandbox execution, where Bash recursively evaluates operand text. Track these explicit arithmetic frames and their nested substitutions in the shared placeholder compiler. Preserve literal shell text and analysis-only variable discovery. Scope: this is a defense-in-depth syntax guard, not a complete prohibition on evaluating bound data. let, numeric [[ ... ]] comparisons, array subscripts, integer assignments, and values assigned elsewhere before arithmetic evaluation remain outside this change. The demonstrated path uses environment values available to the shell author; no additional privilege boundary is crossed. Type of Change Bug fix Testing All 13 arithmetic rejection cases fail with the guard removed. Compiler, resolver, and Function execution tests: 316 passed on the staging base. bun run lint, bun run type-check, all 58 repository audits, docs-manifest check, and the staging-based block-registry check passed. Full repository test run on Node 24: app suite had 34,713 passes and one timeout in the existing executor/execution/executor.test.ts case "does not run a stale branch inside a loop"; all 18 other test tasks passed. The timeout also reproduces with this patch removed on clean staging. Local compiler-to-Bash reproduction verified before the fix and rejected after it; no hosted sandbox run. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Reject resolved shell placeholders inside $((...)), $[...], and ((...)) (including arithmetic for headers) before sandbox execution, where Bash recursively evaluates operand text. Track th...

X Description: Summary Reject resolved shell placeholders inside $((...)), $[...], and ((...)) (including arithmetic for headers) before sandbox execution, where Bash recursively evaluates operand text. Track th...

Opengraph URL: https://github.com/simstudioai/sim/pull/8628

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8c554c65-64f4-068d-7764-5e1bac718ddb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A6A:330459:8FABCF:CBE5A2:6AFB513E
html-safe-nonce90edb5c421ed727747e8f4cda65e8db5bdae24ad98b4d52eb404abdb299a0568
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTZBOjMzMDQ1OTo4RkFCQ0Y6Q0JFNUEyOjZBRkI1MTNFIiwidmlzaXRvcl9pZCI6IjUyOTg5MTI2MzA0Njk3NzU2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac909848913e32693518ce3c0cd6cc0b2425ce048f99793627249bcb5da8941438
hovercard-subject-tagpull_request:4748946893
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8628/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Reject resolved shell placeholders inside $((...)), $[...], and ((...)) (including arithmetic for headers) before sandbox execution, where Bash recursively evaluates operand text. Track th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8628/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8628%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8628%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8628/files
Reloadhttps://github.com/simstudioai/sim/pull/8628/files
Reloadhttps://github.com/simstudioai/sim/pull/8628/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
codex/shell-arithmetic-guardhttps://github.com/simstudioai/sim/tree/codex/shell-arithmetic-guard
Conversation 12 https://github.com/simstudioai/sim/pull/8628
Commits 1 https://github.com/simstudioai/sim/pull/8628/commits
Checks 33 https://github.com/simstudioai/sim/pull/8628/checks
Files changed https://github.com/simstudioai/sim/pull/8628/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8628/files
fix(code-placeholders): reject shell arithmetic placeholders https://github.com/simstudioai/sim/pull/8628/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8628/files
4c9ea92 fix(code-placeholders): reject shell arithmetic placeholders Oct 5, 2026 https://github.com/simstudioai/sim/pull/8628/commits/4c9ea92e99bfd12615dc3921b0f87e9873c333d4
Clear filters https://github.com/simstudioai/sim/pull/8628/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8628/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8628/files
compiler.test.ts https://github.com/simstudioai/sim/pull/8628/files#diff-017a536756b490e26e857f52da5c4af8fad3c4b2d3b7cd4b02fd28434d0bb1fb
shell.ts https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
apps/sim/lib/execution/code-placeholders/compiler.test.tshttps://github.com/simstudioai/sim/pull/8628/files#diff-017a536756b490e26e857f52da5c4af8fad3c4b2d3b7cd4b02fd28434d0bb1fb
View file https://github.com/simstudioai/sim/blob/4c9ea92e99bfd12615dc3921b0f87e9873c333d4/apps/sim/lib/execution/code-placeholders/compiler.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8628/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8628/files#diff-017a536756b490e26e857f52da5c4af8fad3c4b2d3b7cd4b02fd28434d0bb1fb
https://github.com/simstudioai/sim/pull/8628/files#diff-017a536756b490e26e857f52da5c4af8fad3c4b2d3b7cd4b02fd28434d0bb1fb
apps/sim/lib/execution/code-placeholders/shell.tshttps://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
View file https://github.com/simstudioai/sim/blob/4c9ea92e99bfd12615dc3921b0f87e9873c333d4/apps/sim/lib/execution/code-placeholders/shell.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8628/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
Please reload this pagehttps://github.com/simstudioai/sim/pull/8628/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8628/files
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
https://github.com/simstudioai/sim/pull/8628/files#diff-69d4ae387611651fe49aafbb8208d088e22fb8ced81c1160eb3193e57f36a1ca
Please reload this pagehttps://github.com/simstudioai/sim/pull/8628/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.