René's URL Explorer Experiment


Title: fix(executor): stop retaining duplicate copies of loop block outputs by waleedlatif1 · Pull Request #8618 · simstudioai/sim · GitHub

Open Graph Title: fix(executor): stop retaining duplicate copies of loop block outputs by waleedlatif1 · Pull Request #8618 · simstudioai/sim

X Title: fix(executor): stop retaining duplicate copies of loop block outputs by waleedlatif1 · Pull Request #8618 · simstudioai/sim

Description: Summary Long-running loops grew the worker heap linearly with block executions until the process was OOM-killed. Each iteration's output was retained as separate structural copies for the whole run: blockLog.output (a deep copy made only to drop the rarely-present childTraceSpans key) and the loop's allIterationOutputs (a second rebuild by compactSubflowResults of an output that compactBlockOutput had already compacted) filterHiddenOutputKeys is now copy-on-write: an unchanged plain object/array is returned as-is and a copy starts only at the first changed child. Non-plain prototypes (Date, class instances, null-prototype objects) are still rebuilt, so the output is unchanged compactEntries reuses unchanged plain subtrees only for compactSubflowResults, whose inputs are already-compacted state outputs. Reusing everywhere was measured and rejected: retaining raw handler (JSON.parse) objects instead of the rebuilt ones costs ~4x heap on wide rows getJsonByteSize (moved to lib/logs/execution/json-byte-size.ts) tracks ancestors only. Its never-cleared seen-set counted a shared subtree once while JSON.stringify writes it per occurrence, so with shared outputs the 3 MB inline execution-data check would have undercounted displayOutput for block-complete callbacks reuses blockLog.output via a shallow copy instead of re-walking the output (top level stays separate because streaming later writes token/cost keys onto the log) Type of Change Bug fix Testing Executor-level benchmark (real DAGExecutor, for loop, mocked handler returning fresh table-shaped output; GC-forced live heap at the last iteration, repeated runs identical): 40 cols × 360 rows, 150 iterations: 44 MB → 19–23 MB 400 cols × 144 rows, 40 iterations: 31 MB → 9–12 MB 10 cols × 1440 rows, 150 iterations: 84 MB → 42–45 MB; wall time 9.4s → 8.5s Equivalence checks against the previous implementations (27 cases: Date, Map/Set, Buffer/typed arrays, class instances with getters, null-prototype, own __proto__ key, sparse arrays, symbol/non-enumerable keys, hidden keys at any depth, UserFile base64 stripping, nested finalBlockLogs): identical JSON and structure New json-byte-size.test.ts: shared-subtree cases fail on the pre-fix seen-set and pass after Root bun run test (all workspaces), bun run lint, bun run type-check, bun run check:audits, check-block-registry.ts origin/staging, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Long-running loops grew the worker heap linearly with block executions until the process was OOM-killed. Each iteration's output was retained as separate structural copies for the whol...

X Description: Summary Long-running loops grew the worker heap linearly with block executions until the process was OOM-killed. Each iteration's output was retained as separate structural copies for the ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8618

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:107c2be0-f9d0-e31a-3b10-7b244ef98fa2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE992:3BD2EB:4D99EE:6D2F28:6AFB5DCA
html-safe-nonced2ae7d25f5c65b121220fb76f4db997133d18f979158b61704b5700db1df1bc5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTkyOjNCRDJFQjo0RDk5RUU6NkQyRjI4OjZBRkI1RENBIiwidmlzaXRvcl9pZCI6IjQ3NTkyODUzNjMwNzgwMjg3NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac40097f9ff140bf64071ddd941570dfa01a6dd4028e81df269fb12c539704ec99
hovercard-subject-tagpull_request:4742374601
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8618/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Long-running loops grew the worker heap linearly with block executions until the process was OOM-killed. Each iteration's output was retained as separate structural copies for the whol...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8618/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8618%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8618%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8618/files
Reloadhttps://github.com/simstudioai/sim/pull/8618/files
Reloadhttps://github.com/simstudioai/sim/pull/8618/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/executor-loop-log-output-sharinghttps://github.com/simstudioai/sim/tree/fix/executor-loop-log-output-sharing
Conversation 33 https://github.com/simstudioai/sim/pull/8618
Commits 5 https://github.com/simstudioai/sim/pull/8618/commits
Checks 32 https://github.com/simstudioai/sim/pull/8618/checks
Files changed https://github.com/simstudioai/sim/pull/8618/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8618/files
fix(executor): stop retaining duplicate copies of loop block outputs https://github.com/simstudioai/sim/pull/8618/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/8618/files
3a50783 fix(executor): stop retaining duplicate copies of loop block outputs waleedlatif1 Oct 5, 2026 https://github.com/simstudioai/sim/pull/8618/commits/3a50783b6abe4fd06bc12b3a3ec3965b579a73bf
029f803 test(executor): guard output sharing in block logs and loop aggregates waleedlatif1 Oct 5, 2026 https://github.com/simstudioai/sim/pull/8618/commits/029f803b4c74ff45d6f583896c3ee57681f12d52
d53f368 fix(logs): size execution data the way JSON.stringify writes it waleedlatif1 Oct 5, 2026 https://github.com/simstudioai/sim/pull/8618/commits/d53f368f69c2cac6f000e0edd9ee6a8cf92475d3
f63445b fix(logs): count JSON string bytes without copying and unbox primitiv… waleedlatif1 Oct 5, 2026 https://github.com/simstudioai/sim/pull/8618/commits/f63445b2f16a6e63cc5915eb72ba09df167638c8
546b030 fix(logs): measure execution data iteratively and apply toJSON on fun… waleedlatif1 Oct 5, 2026 https://github.com/simstudioai/sim/pull/8618/commits/546b030c7fd03d8a80b905c9b810f0735761dc34
Clear filters https://github.com/simstudioai/sim/pull/8618/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8618/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8618/files
block-executor.ts https://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
output-filter.test.ts https://github.com/simstudioai/sim/pull/8618/files#diff-c7008b886582903dfa460d7a14e7310f5b9c638f66475fef2425cca458c845e7
bounded-json.ts https://github.com/simstudioai/sim/pull/8618/files#diff-69d5426556658000a42c127020f665bcb0817e21498d49f225db80cd25b15126
serializer.test.ts https://github.com/simstudioai/sim/pull/8618/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
serializer.ts https://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
json-byte-size.test.ts https://github.com/simstudioai/sim/pull/8618/files#diff-e59b4f896dde5ef1224a21efea22a37864e3f896c595493c7c230f9d41baadb7
json-byte-size.ts https://github.com/simstudioai/sim/pull/8618/files#diff-f4f9509e73bcf18b1655be4d4455d7c265f1959dd979a619ce8f4d0a34c3659e
logger.ts https://github.com/simstudioai/sim/pull/8618/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
trace-spans.ts https://github.com/simstudioai/sim/pull/8618/files#diff-19aca28e4e62e1654fb5192529de671700f8a1c8a6f84585e09f8b300f297e56
apps/sim/executor/execution/block-executor.tshttps://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
View file https://github.com/simstudioai/sim/blob/546b030c7fd03d8a80b905c9b810f0735761dc34/apps/sim/executor/execution/block-executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8618/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8618/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
apps/sim/executor/utils/output-filter.test.tshttps://github.com/simstudioai/sim/pull/8618/files#diff-c7008b886582903dfa460d7a14e7310f5b9c638f66475fef2425cca458c845e7
View file https://github.com/simstudioai/sim/blob/546b030c7fd03d8a80b905c9b810f0735761dc34/apps/sim/executor/utils/output-filter.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8618/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8618/files#diff-c7008b886582903dfa460d7a14e7310f5b9c638f66475fef2425cca458c845e7
apps/sim/lib/core/utils/bounded-json.tshttps://github.com/simstudioai/sim/pull/8618/files#diff-69d5426556658000a42c127020f665bcb0817e21498d49f225db80cd25b15126
View file https://github.com/simstudioai/sim/blob/546b030c7fd03d8a80b905c9b810f0735761dc34/apps/sim/lib/core/utils/bounded-json.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8618/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8618/files#diff-69d5426556658000a42c127020f665bcb0817e21498d49f225db80cd25b15126
apps/sim/lib/execution/payloads/serializer.test.tshttps://github.com/simstudioai/sim/pull/8618/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
View file https://github.com/simstudioai/sim/blob/546b030c7fd03d8a80b905c9b810f0735761dc34/apps/sim/lib/execution/payloads/serializer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8618/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8618/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
https://github.com/simstudioai/sim/pull/8618/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
apps/sim/lib/execution/payloads/serializer.tshttps://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
View file https://github.com/simstudioai/sim/blob/546b030c7fd03d8a80b905c9b810f0735761dc34/apps/sim/lib/execution/payloads/serializer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8618/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
https://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
https://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
https://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
https://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
Please reload this pagehttps://github.com/simstudioai/sim/pull/8618/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8618/files
https://github.com/simstudioai/sim/pull/8618/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
apps/sim/lib/logs/execution/json-byte-size.test.tshttps://github.com/simstudioai/sim/pull/8618/files#diff-e59b4f896dde5ef1224a21efea22a37864e3f896c595493c7c230f9d41baadb7
View file https://github.com/simstudioai/sim/blob/546b030c7fd03d8a80b905c9b810f0735761dc34/apps/sim/lib/logs/execution/json-byte-size.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8618/{{ revealButtonHref }}
apps/sim/lib/logs/execution/json-byte-size.tshttps://github.com/simstudioai/sim/pull/8618/files#diff-f4f9509e73bcf18b1655be4d4455d7c265f1959dd979a619ce8f4d0a34c3659e
View file https://github.com/simstudioai/sim/blob/546b030c7fd03d8a80b905c9b810f0735761dc34/apps/sim/lib/logs/execution/json-byte-size.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8618/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8618/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8618/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.