René's URL Explorer Experiment


Title: fix(knowledge): scope list counts to selected knowledge bases by icecrasher321 · Pull Request #8575 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): scope list counts to selected knowledge bases by icecrasher321 · Pull Request #8575 · simstudioai/sim

X Title: fix(knowledge): scope list counts to selected knowledge bases by icecrasher321 · Pull Request #8575 · simstudioai/sim

Description: Summary Select the knowledge-base page before computing document and token totals, so shared ACL tokens cannot make a small list scan unrelated documents. Count the selected KB IDs in one query using the existing large-array helper, preserving permission filters, empty bases, and pagination without per-batch round trips for unpaged lists. Type of Change Bug fix Testing Real PostgreSQL regression coverage verifies selective page scans, bounded round trips for a synthetic 10,001-base unpaged list, pagination, lifecycle filters, and permission-filtered totals. Both regressions fail before their respective fixes. Knowledge-list and API/UI permission integration suites: 13 tests pass. Existing knowledge-service tests pass. Full repository tests pass under Node 24. Repository type-check, lint, all 58 audits, docs-manifest check, and staging-based block-registry check pass. JSON test reports and query plans recorded locally; CI discovers the integration suite and uploads its test report. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Select the knowledge-base page before computing document and token totals, so shared ACL tokens cannot make a small list scan unrelated documents. Count the selected KB IDs in one query us...

X Description: Summary Select the knowledge-base page before computing document and token totals, so shared ACL tokens cannot make a small list scan unrelated documents. Count the selected KB IDs in one query us...

Opengraph URL: https://github.com/simstudioai/sim/pull/8575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2d289a1f-dd12-8c89-7b16-b5474b1e1e06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9E2:14C9D4:1173CA:188C29:6AFB4C85
html-safe-nonce17c6f1fa178294f8eea30ca5abafd0ad7cc4e37a0e61a1f8de79d0d4326acdea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUUyOjE0QzlENDoxMTczQ0E6MTg4QzI5OjZBRkI0Qzg1IiwidmlzaXRvcl9pZCI6IjIwMDMyOTQwNTU3MDU1NjIyNDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3908874219d63d68936d8849b7bcd15d397999e626c09b61386bcb7ac6c620c8
hovercard-subject-tagpull_request:4719597681
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8575/files
twitter:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17950982?s=400&v=4
og:image:altSummary Select the knowledge-base page before computing document and token totals, so shared ACL tokens cannot make a small list scan unrelated documents. Count the selected KB IDs in one query us...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8575/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8575%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8575%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8575/files
Reloadhttps://github.com/simstudioai/sim/pull/8575/files
Reloadhttps://github.com/simstudioai/sim/pull/8575/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
icecrasher321https://github.com/icecrasher321
staginghttps://github.com/simstudioai/sim/tree/staging
codex/kb-list-count-scopehttps://github.com/simstudioai/sim/tree/codex/kb-list-count-scope
Conversation 16 https://github.com/simstudioai/sim/pull/8575
Commits 2 https://github.com/simstudioai/sim/pull/8575/commits
Checks 33 https://github.com/simstudioai/sim/pull/8575/checks
Files changed https://github.com/simstudioai/sim/pull/8575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8575/files
fix(knowledge): scope list counts to selected knowledge bases https://github.com/simstudioai/sim/pull/8575/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8575/files
ba07b4e fix(knowledge): scope list counts to selected knowledge bases Oct 2, 2026 https://github.com/simstudioai/sim/pull/8575/commits/ba07b4e4da148399206a91d3a20a9468f2661153
2a16f91 fix(knowledge): avoid count-query fan-out for unpaged lists Oct 2, 2026 https://github.com/simstudioai/sim/pull/8575/commits/2a16f914c3db1d35a7f53abbdb10758803bc040b
Clear filters https://github.com/simstudioai/sim/pull/8575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8575/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8575/files
knowledge-base-list.integration.ts https://github.com/simstudioai/sim/pull/8575/files#diff-6da0c32138094e247673dc0f0d61020702c1e8b06cbe194c178e12debabbc723
service.test.ts https://github.com/simstudioai/sim/pull/8575/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
service.ts https://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
apps/sim/lib/knowledge/__integration__/knowledge-base-list.integration.tshttps://github.com/simstudioai/sim/pull/8575/files#diff-6da0c32138094e247673dc0f0d61020702c1e8b06cbe194c178e12debabbc723
View file https://github.com/simstudioai/sim/blob/2a16f914c3db1d35a7f53abbdb10758803bc040b/apps/sim/lib/knowledge/__integration__/knowledge-base-list.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8575/{{ revealButtonHref }}
greptile-appshttps://github.com/apps/greptile-apps
Oct 2, 2026https://github.com/simstudioai/sim/pull/8575/files#r4169099840
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/simstudioai/sim/pull/8575/files
sourcehttps://github.com/simstudioai/sim/blob/main/CLAUDE.md
Please reload this pagehttps://github.com/simstudioai/sim/pull/8575/files
icecrasher321https://github.com/icecrasher321
Oct 2, 2026https://github.com/simstudioai/sim/pull/8575/files#r4169175434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/simstudioai/sim/pull/8575/files
icecrasher321https://github.com/icecrasher321
Oct 2, 2026https://github.com/simstudioai/sim/pull/8575/files#r4169254702
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
3f453e1https://github.com/simstudioai/sim/commit/3f453e145ce9021cb4d1144ddb7c30b235382357
Please reload this pagehttps://github.com/simstudioai/sim/pull/8575/files
apps/sim/lib/knowledge/service.test.tshttps://github.com/simstudioai/sim/pull/8575/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
View file https://github.com/simstudioai/sim/blob/2a16f914c3db1d35a7f53abbdb10758803bc040b/apps/sim/lib/knowledge/service.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8575/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8575/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
https://github.com/simstudioai/sim/pull/8575/files#diff-5856177786ea5bfaddee3756ec5ac692c1e3e97c332ec370f6c31f401649abb8
apps/sim/lib/knowledge/service.tshttps://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
View file https://github.com/simstudioai/sim/blob/2a16f914c3db1d35a7f53abbdb10758803bc040b/apps/sim/lib/knowledge/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8575/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
https://github.com/simstudioai/sim/pull/8575/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
Please reload this pagehttps://github.com/simstudioai/sim/pull/8575/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.