Title: fix(db): pin the primary-key plan in the search retirement read-bound test by waleedlatif1 · Pull Request #8556 · simstudioai/sim · GitHub
Open Graph Title: fix(db): pin the primary-key plan in the search retirement read-bound test by waleedlatif1 · Pull Request #8556 · simstudioai/sim
X Title: fix(db): pin the primary-key plan in the search retirement read-bound test by waleedlatif1 · Pull Request #8556 · simstudioai/sim
Description: Summary Fix the flaky bounds the IDs each page reads by the row limit once the limit shrinks test in 0027_retire_search_embeddings.integration.ts (failing staging CI with expected 199619 to be less than 90000) Root cause: the test disabled only sequential scans, so on its small fixture table the planner could still answer each page with a bitmap scan that reads every remaining row. Which plan it picked depended on whether autovacuum had analyzed the freshly inserted rows, so CI flipped between passing and a deterministic ~200k reads Fix: ANALYZE document and also SET enable_bitmapscan = off (reset afterwards), pinning the primary-key walk production uses. Test-only; the migration is unchanged Type of Change Bug fix (test flake) Testing Reproduced the mechanism locally: forcing the planner off the ordered index scan gives the same failure (213355 reads) Fixed test passes 5/5 repeated runs and the full packages/db integration suite (17 files) against a CI-equivalent pgvector pg17 database provisioned with db:push Mutation check: making the migration use a fixed 25,000-ID scan window still fails the test (213499 reads), so it keeps guarding the real regression Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code
Open Graph Description: Summary Fix the flaky bounds the IDs each page reads by the row limit once the limit shrinks test in 0027_retire_search_embeddings.integration.ts (failing staging CI with expected 199619 to be les...
X Description: Summary Fix the flaky bounds the IDs each page reads by the row limit once the limit shrinks test in 0027_retire_search_embeddings.integration.ts (failing staging CI with expected 199619 to be les...
Opengraph URL: https://github.com/simstudioai/sim/pull/8556
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:66026727-2508-1326-9175-265c4342a785 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F88:5A71D:BE130E:10420DE:6AFB533F |
| html-safe-nonce | 48451de169f3c1ccdda719ff97fa2deb9fbbb6b1aa79575c65428e1e904af827 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Rjg4OjVBNzFEOkJFMTMwRToxMDQyMERFOjZBRkI1MzNGIiwidmlzaXRvcl9pZCI6IjEzMTg2MjEwNDQwMzM2NzE5OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 83ea044e4ba9ab6b567667f44ff913b330a87c2c4869f7bc7d12279a185d942d |
| hovercard-subject-tag | pull_request:4712164276 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8556/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Fix the flaky bounds the IDs each page reads by the row limit once the limit shrinks test in 0027_retire_search_embeddings.integration.ts (failing staging CI with expected 199619 to be les... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width