René's URL Explorer Experiment


Title: fix(slack): honor implicit Search approval during authorization by waleedlatif1 · Pull Request #8548 · simstudioai/sim · GitHub

Open Graph Title: fix(slack): honor implicit Search approval during authorization by waleedlatif1 · Pull Request #8548 · simstudioai/sim

X Title: fix(slack): honor implicit Search approval during authorization by waleedlatif1 · Pull Request #8548 · simstudioai/sim

Description: Summary Use the shared Search approval policy when choosing and verifying Slack OAuth scopes. Existing live sources retain implicit approval; explicit denial stays authoritative and detached sources no longer grant approval. Serialize OAuth completion with explicit approval decisions, source creation/removal, and index archive/restore using the existing transaction advisory-lock helper. Acquire the organization lock before resource row locks. Type of Change Bug fix Testing 38 real PostgreSQL/Redis integration tests pass. Regressions reproduce stale implicit approval, retained-document removal, and concurrent source/index/approval changes; independent negative controls verify the new guards. JSON reports generated. 172 focused tests pass across Slack authorization, connector/index lifecycle, Search approvals, and account access. Type-check, lint, all 54 audits, block-registry audit, and docs-manifest check pass. Committed-artifact generators completed. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Use the shared Search approval policy when choosing and verifying Slack OAuth scopes. Existing live sources retain implicit approval; explicit denial stays authoritative and detached sourc...

X Description: Summary Use the shared Search approval policy when choosing and verifying Slack OAuth scopes. Existing live sources retain implicit approval; explicit denial stays authoritative and detached sourc...

Opengraph URL: https://github.com/simstudioai/sim/pull/8548

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:405d84a0-f25c-c536-3668-cb3fa481ae39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB63A:3454BD:8E371A:CA1F66:6AFB5079
html-safe-nonce8bb09b852c935bfdfba2c844515dcd823cff39f48456ba78cf4dc2755492fd99
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjNBOjM0NTRCRDo4RTM3MUE6Q0ExRjY2OjZBRkI1MDc5IiwidmlzaXRvcl9pZCI6IjM3NDA4NzQ4NzI2MDc5NTMwMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacda821a35a6841a77353f514fe9593e4c13287b6a56556d7d3b18800f36f9ac11
hovercard-subject-tagpull_request:4710349177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8548/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Use the shared Search approval policy when choosing and verifying Slack OAuth scopes. Existing live sources retain implicit approval; explicit denial stays authoritative and detached sourc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8548/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8548%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8548%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8548/files
Reloadhttps://github.com/simstudioai/sim/pull/8548/files
Reloadhttps://github.com/simstudioai/sim/pull/8548/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
codex/fix-slack-implicit-search-approvalhttps://github.com/simstudioai/sim/tree/codex/fix-slack-implicit-search-approval
Conversation 15 https://github.com/simstudioai/sim/pull/8548
Commits 2 https://github.com/simstudioai/sim/pull/8548/commits
Checks 33 https://github.com/simstudioai/sim/pull/8548/checks
Files changed https://github.com/simstudioai/sim/pull/8548/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
fix(slack): honor implicit Search approval during authorization https://github.com/simstudioai/sim/pull/8548/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8548/files
6a277b7 fix(slack): honor implicit Search approval during authorization waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8548/commits/6a277b78535b5304553afa17c6ecf5d01807486f
d424921 fix(slack): serialize Search approval changes with consent waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8548/commits/d4249215d43f24dd26c9b470ac182d5e3e11508c
Clear filters https://github.com/simstudioai/sim/pull/8548/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
slack-managed-users.ts https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
search-mcp-setup.integration.ts https://github.com/simstudioai/sim/pull/8548/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
search-integrations.ts https://github.com/simstudioai/sim/pull/8548/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
connectors.ts https://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
integration-policy.ts https://github.com/simstudioai/sim/pull/8548/files#diff-927e4f0408c1e8c8de4064de190084e06b816a238d77bdfdaa67a0930caf780d
service.ts https://github.com/simstudioai/sim/pull/8548/files#diff-6978b26968fd05cf5c7635c366c8c806693b6145235f476627302fb402f32d18
knowledge-search-integration-policy.mock.ts https://github.com/simstudioai/sim/pull/8548/files#diff-a5b103e15b7e5b79ac2c692de04af880bfa3f14c0ee4890f9b37e1722479cba6
apps/sim/lib/credential-groups/slack-managed-users.tshttps://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
View file https://github.com/simstudioai/sim/blob/d4249215d43f24dd26c9b470ac182d5e3e11508c/apps/sim/lib/credential-groups/slack-managed-users.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8548/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
https://github.com/simstudioai/sim/pull/8548/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
apps/sim/lib/knowledge/__integration__/search-mcp-setup.integration.tshttps://github.com/simstudioai/sim/pull/8548/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
View file https://github.com/simstudioai/sim/blob/d4249215d43f24dd26c9b470ac182d5e3e11508c/apps/sim/lib/knowledge/__integration__/search-mcp-setup.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8548/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8548/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
https://github.com/simstudioai/sim/pull/8548/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
https://github.com/simstudioai/sim/pull/8548/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
https://github.com/simstudioai/sim/pull/8548/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
apps/sim/lib/knowledge/application/search-integrations.tshttps://github.com/simstudioai/sim/pull/8548/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
View file https://github.com/simstudioai/sim/blob/d4249215d43f24dd26c9b470ac182d5e3e11508c/apps/sim/lib/knowledge/application/search-integrations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8548/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8548/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
https://github.com/simstudioai/sim/pull/8548/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
https://github.com/simstudioai/sim/pull/8548/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
https://github.com/simstudioai/sim/pull/8548/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
apps/sim/lib/knowledge/orchestration/connectors.tshttps://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
View file https://github.com/simstudioai/sim/blob/d4249215d43f24dd26c9b470ac182d5e3e11508c/apps/sim/lib/knowledge/orchestration/connectors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8548/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8548/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8548/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.