René's URL Explorer Experiment


Title: fix(slack): verify Search permissions before changing active grants by waleedlatif1 · Pull Request #8545 · simstudioai/sim · GitHub

Open Graph Title: fix(slack): verify Search permissions before changing active grants by waleedlatif1 · Pull Request #8545 · simstudioai/sim

X Title: fix(slack): verify Search permissions before changing active grants by waleedlatif1 · Pull Request #8545 · simstudioai/sim

Description: Summary Preserve active Slack connections while Search permissions await verification, including cancellation and incomplete consent. Commit verified permissions atomically and reject callbacks after approval changes in either direction without dropping existing workflow or custom scopes. Show when Search permissions still need verification and keep workflow-only setup usable. Type of Change Bug fix Testing search-mcp-setup.integration.ts: 29 tests passed against disposable PostgreSQL and Redis with Slack HTTP fixtures; JSON integration report generated. Regression cases fail before the fix, and each new guard was independently disabled to verify its regression. 75 tests passed across service.test.ts, slack-managed-users.test.ts (manager and application), organization-provider-setup.test.ts, slack-provider.test.ts, live-search-settings.test.tsx, and live-member-integrations.test.tsx. bun run type-check, bun run lint, all 54 check:audits, block registry audit, and docs-manifest:check passed. Committed-artifact generators ran successfully. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Preserve active Slack connections while Search permissions await verification, including cancellation and incomplete consent. Commit verified permissions atomically and reject callbacks af...

X Description: Summary Preserve active Slack connections while Search permissions await verification, including cancellation and incomplete consent. Commit verified permissions atomically and reject callbacks af...

Opengraph URL: https://github.com/simstudioai/sim/pull/8545

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a4c45cbb-b307-2fd7-2a13-b8d510038b72
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5C6:11DC7C:1360A55:1A6F7F4:6AFB6F23
html-safe-nonce1971e75e3f5a40f81a6e7534be112c6ac4d001fd1c1a7d11a82f04e0d8daef33
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUM2OjExREM3QzoxMzYwQTU1OjFBNkY3RjQ6NkFGQjZGMjMiLCJ2aXNpdG9yX2lkIjoiMjg4NDgwODMxNzY1NjA2Nzg3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac76cb4a65ca9d63f3ff70a7a16eba7beb457777b57199a6a6cdf9dce911fad544
hovercard-subject-tagpull_request:4709832533
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8545/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Preserve active Slack connections while Search permissions await verification, including cancellation and incomplete consent. Commit verified permissions atomically and reject callbacks af...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecca289ecd54650fcf3c0b037a58b97186dee2cc4406819d87fab93728fd83700
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release88808b1fae5ab8a526a73e7ce5542a10eb9d6971
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8545/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8545%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8545%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8545/files
Reloadhttps://github.com/simstudioai/sim/pull/8545/files
Reloadhttps://github.com/simstudioai/sim/pull/8545/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
codex/fix-slack-search-permission-upgradehttps://github.com/simstudioai/sim/tree/codex/fix-slack-search-permission-upgrade
Conversation 27 https://github.com/simstudioai/sim/pull/8545
Commits 3 https://github.com/simstudioai/sim/pull/8545/commits
Checks 33 https://github.com/simstudioai/sim/pull/8545/checks
Files changed https://github.com/simstudioai/sim/pull/8545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8545/files
fix(slack): verify Search permissions before changing active grants https://github.com/simstudioai/sim/pull/8545/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8545/files
328a37b fix(slack): verify Search permissions before changing active grants waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8545/commits/328a37b735732ab0945a4c02b4b0ddfe8d6a2b9a
c765a57 fix(slack): bind authorization to every Search approval state waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8545/commits/c765a57cce5761b1a57a78aafb81ae9e08754e1d
f66dd3f chore(tests): require Redis for Slack authorization integration waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8545/commits/f66dd3fee47c1ef779402e97ca8a81330615c1d8
Clear filters https://github.com/simstudioai/sim/pull/8545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8545/files
live-member-integrations.tsx https://github.com/simstudioai/sim/pull/8545/files#diff-be11b6a50872d14f32d53ff65377bb840f42af80c014e7aec882cba575d89f5c
live-search-settings.test.tsx https://github.com/simstudioai/sim/pull/8545/files#diff-e1a05ba6434fe7a58af9b77da81009e2111f2a7db5e75fef3e76e4302f6daf46
live-search-settings.tsx https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
slack-managed-users-modal.tsx https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
slack-managed-users.ts https://github.com/simstudioai/sim/pull/8545/files#diff-e118fbff685e1ee2b0948e6fa63aa2a553968e236d65442278e0e7261c239a84
service.ts https://github.com/simstudioai/sim/pull/8545/files#diff-21e59a9fe4ec28abf5dc891799c328a539a0a134477e1cdf6ead09f71bab62ef
slack-managed-user-scopes.ts https://github.com/simstudioai/sim/pull/8545/files#diff-c0324bd53c1edfa5b02ffdfdb08ca2d4c7a4815890d89c10f986b3c86f62f2a3
slack-managed-users.ts https://github.com/simstudioai/sim/pull/8545/files#diff-220df4c221b1a1e3a42f13c2c088342c19411d0bc11d1fdac52285f4aca87bdc
search-mcp-setup.integration.ts https://github.com/simstudioai/sim/pull/8545/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
apps/sim/app/o/[organizationId]/integrations/live-member-integrations.tsxhttps://github.com/simstudioai/sim/pull/8545/files#diff-be11b6a50872d14f32d53ff65377bb840f42af80c014e7aec882cba575d89f5c
View file https://github.com/simstudioai/sim/blob/f66dd3fee47c1ef779402e97ca8a81330615c1d8/apps/sim/app/o/%5BorganizationId%5D/integrations/live-member-integrations.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8545/files#diff-be11b6a50872d14f32d53ff65377bb840f42af80c014e7aec882cba575d89f5c
https://github.com/simstudioai/sim/pull/8545/files#diff-be11b6a50872d14f32d53ff65377bb840f42af80c014e7aec882cba575d89f5c
https://github.com/simstudioai/sim/pull/8545/files#diff-be11b6a50872d14f32d53ff65377bb840f42af80c014e7aec882cba575d89f5c
...sim/app/o/[organizationId]/settings/components/integrations/live-search-settings.test.tsxhttps://github.com/simstudioai/sim/pull/8545/files#diff-e1a05ba6434fe7a58af9b77da81009e2111f2a7db5e75fef3e76e4302f6daf46
View file https://github.com/simstudioai/sim/blob/f66dd3fee47c1ef779402e97ca8a81330615c1d8/apps/sim/app/o/%5BorganizationId%5D/settings/components/integrations/live-search-settings.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8545/files#diff-e1a05ba6434fe7a58af9b77da81009e2111f2a7db5e75fef3e76e4302f6daf46
https://github.com/simstudioai/sim/pull/8545/files#diff-e1a05ba6434fe7a58af9b77da81009e2111f2a7db5e75fef3e76e4302f6daf46
apps/sim/app/o/[organizationId]/settings/components/integrations/live-search-settings.tsxhttps://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
View file https://github.com/simstudioai/sim/blob/f66dd3fee47c1ef779402e97ca8a81330615c1d8/apps/sim/app/o/%5BorganizationId%5D/settings/components/integrations/live-search-settings.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
https://github.com/simstudioai/sim/pull/8545/files#diff-f2e0a33c521a6ff5e70ad3a429a8d907f55c3f4638f4fc956d8be88533a22039
apps/sim/ee/credential-groups/components/slack-managed-users-modal.tsxhttps://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
View file https://github.com/simstudioai/sim/blob/f66dd3fee47c1ef779402e97ca8a81330615c1d8/apps/sim/ee/credential-groups/components/slack-managed-users-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
https://github.com/simstudioai/sim/pull/8545/files#diff-b26677f0eb081e76590f4c0b4308407c53414570204354f9ebb650c93d9e60de
apps/sim/lib/credential-groups/application/slack-managed-users.tshttps://github.com/simstudioai/sim/pull/8545/files#diff-e118fbff685e1ee2b0948e6fa63aa2a553968e236d65442278e0e7261c239a84
View file https://github.com/simstudioai/sim/blob/f66dd3fee47c1ef779402e97ca8a81330615c1d8/apps/sim/lib/credential-groups/application/slack-managed-users.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8545/files#diff-e118fbff685e1ee2b0948e6fa63aa2a553968e236d65442278e0e7261c239a84
https://github.com/simstudioai/sim/pull/8545/files#diff-e118fbff685e1ee2b0948e6fa63aa2a553968e236d65442278e0e7261c239a84
apps/sim/lib/credential-groups/service.tshttps://github.com/simstudioai/sim/pull/8545/files#diff-21e59a9fe4ec28abf5dc891799c328a539a0a134477e1cdf6ead09f71bab62ef
View file https://github.com/simstudioai/sim/blob/f66dd3fee47c1ef779402e97ca8a81330615c1d8/apps/sim/lib/credential-groups/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8545/files#diff-21e59a9fe4ec28abf5dc891799c328a539a0a134477e1cdf6ead09f71bab62ef
https://github.com/simstudioai/sim/pull/8545/files#diff-21e59a9fe4ec28abf5dc891799c328a539a0a134477e1cdf6ead09f71bab62ef
https://github.com/simstudioai/sim/pull/8545/files#diff-21e59a9fe4ec28abf5dc891799c328a539a0a134477e1cdf6ead09f71bab62ef
https://github.com/simstudioai/sim/pull/8545/files#diff-21e59a9fe4ec28abf5dc891799c328a539a0a134477e1cdf6ead09f71bab62ef
apps/sim/lib/credential-groups/slack-managed-user-scopes.tshttps://github.com/simstudioai/sim/pull/8545/files#diff-c0324bd53c1edfa5b02ffdfdb08ca2d4c7a4815890d89c10f986b3c86f62f2a3
View file https://github.com/simstudioai/sim/blob/f66dd3fee47c1ef779402e97ca8a81330615c1d8/apps/sim/lib/credential-groups/slack-managed-user-scopes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8545/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8545/files#diff-c0324bd53c1edfa5b02ffdfdb08ca2d4c7a4815890d89c10f986b3c86f62f2a3
https://github.com/simstudioai/sim/pull/8545/files#diff-c0324bd53c1edfa5b02ffdfdb08ca2d4c7a4815890d89c10f986b3c86f62f2a3
Please reload this pagehttps://github.com/simstudioai/sim/pull/8545/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8545/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.