René's URL Explorer Experiment


Title: fix(mothership): stop duplicating chat resource tabs in workspace chats by waleedlatif1 · Pull Request #8537 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): stop duplicating chat resource tabs in workspace chats by waleedlatif1 · Pull Request #8537 · simstudioai/sim

X Title: fix(mothership): stop duplicating chat resource tabs in workspace chats by waleedlatif1 · Pull Request #8537 · simstudioai/sim

Description: Summary Chat resource tabs are keyed by workspaceId when it's present, and workspace chats leave it out (message tab attachments, the sandbox transport, the client). Three server writers stamped it unconditionally, so the same workflow/file/table got stored and rendered as two tabs Agent CLI effects now stamp the workspace only in organization chats, matching sandbox-resource-transport open_resource no longer emits workspaceId; the tool executor already stamps the target workspace for organization chats handleResourceSideEffects takes the chat owner and stamps the workspace only in organization chats Existing duplicated rows are left as-is Type of Change Bug fix Testing resource-owner.test.ts now asserts a workspace-chat agent effect and open_resource produce the same key as an open tab; it fails on the pre-fix code bun run --cwd apps/sim test on lib/mothership/agent-cli, tools/server/open-resource, tools/registry, request/tools (562 passed); wider lib/mothership + copilot/mothership routes + home stream hooks (3,280 passed) bun run type-check, bun run lint, check:audits (54 audits), docs-manifest:check resources.test.ts covers both owners of handleResourceSideEffects; the workspace-chat case fails with the guard reverted Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Chat resource tabs are keyed by workspaceId when it's present, and workspace chats leave it out (message tab attachments, the sandbox transport, the client). Three server writers stamp...

X Description: Summary Chat resource tabs are keyed by workspaceId when it's present, and workspace chats leave it out (message tab attachments, the sandbox transport, the client). Three server writers s...

Opengraph URL: https://github.com/simstudioai/sim/pull/8537

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5e2d6c93-3152-d299-d81d-aac2cbc1b9ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC508:AF687:AF976F:F16197:6AFB509E
html-safe-nonce6eecdd4d77891ea2fa67e84fb99fcae7922706703c49acbec1bbf5c5eae702b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTA4OkFGNjg3OkFGOTc2RjpGMTYxOTc6NkFGQjUwOUUiLCJ2aXNpdG9yX2lkIjoiNjk5ODY1NDU1MjUzOTk5Nzc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac01b1b93bb38c878d286cf97ceffda9d5b07dcfc002315da7d6494ee400ea7c6e
hovercard-subject-tagpull_request:4708644736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8537/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Chat resource tabs are keyed by workspaceId when it's present, and workspace chats leave it out (message tab attachments, the sandbox transport, the client). Three server writers stamp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8537/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8537%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8537%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8537/files
Reloadhttps://github.com/simstudioai/sim/pull/8537/files
Reloadhttps://github.com/simstudioai/sim/pull/8537/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chat-resource-tab-identityhttps://github.com/simstudioai/sim/tree/fix/chat-resource-tab-identity
Conversation 15 https://github.com/simstudioai/sim/pull/8537
Commits 3 https://github.com/simstudioai/sim/pull/8537/commits
Checks 31 https://github.com/simstudioai/sim/pull/8537/checks
Files changed https://github.com/simstudioai/sim/pull/8537/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8537/files
fix(mothership): stop duplicating chat resource tabs in workspace chats https://github.com/simstudioai/sim/pull/8537/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8537/files
6bfce16 fix(mothership): stop duplicating chat resource tabs in workspace chats waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8537/commits/6bfce16fdfa0880572659e18a5c426e1d04d88ef
8d2759c fix(mothership): scope tool side-effect resources inside handleResour… waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8537/commits/8d2759ce69e2748eb0b46a92f6dea355f3bcf434
9f74b68 fix(mothership): assert emitted resource events instead of mock calls waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8537/commits/9f74b68d18f2f3adc3f82482b58442a944939de4
Clear filters https://github.com/simstudioai/sim/pull/8537/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8537/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8537/files
mothership-resource-tools.ts https://github.com/simstudioai/sim/pull/8537/files#diff-5c4114b634bd64309606ca4b21b1c50b6dbdfc320892af6e287a1a461fffd086
index.ts https://github.com/simstudioai/sim/pull/8537/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
resource-owner.test.ts https://github.com/simstudioai/sim/pull/8537/files#diff-bd9863d912a956527e301b5fd51b240792151e20d55595d000a0b7c3563bf54d
executor.ts https://github.com/simstudioai/sim/pull/8537/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
resources.test.ts https://github.com/simstudioai/sim/pull/8537/files#diff-2504c6da07da771061e711d4a7d3b3d53236c7c80979df3ca17106fe79e6c750
resources.ts https://github.com/simstudioai/sim/pull/8537/files#diff-b729cdfd0afe30852a53657c417a28834afa0085c24d9002db8dd027d07322fe
server-tool-adapter.test.ts https://github.com/simstudioai/sim/pull/8537/files#diff-1790db5587ce4b2342ccf5365c70cec1127e3418e7da5ef718e2089fabcd84c6
open-resource.test.ts https://github.com/simstudioai/sim/pull/8537/files#diff-372f9710be0eba8312bdbeb507d6543a166c1f1313f8f51362fdada3be217072
open-resource.ts https://github.com/simstudioai/sim/pull/8537/files#diff-47b57b2ed49629e7a0369c72d77dad793999a340c7a6cb7e27d8944e3957d84b
apps/sim/lib/api/contracts/mothership-resource-tools.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-5c4114b634bd64309606ca4b21b1c50b6dbdfc320892af6e287a1a461fffd086
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/api/contracts/mothership-resource-tools.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-5c4114b634bd64309606ca4b21b1c50b6dbdfc320892af6e287a1a461fffd086
https://github.com/simstudioai/sim/pull/8537/files#diff-5c4114b634bd64309606ca4b21b1c50b6dbdfc320892af6e287a1a461fffd086
apps/sim/lib/mothership/agent-cli/index.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/agent-cli/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
https://github.com/simstudioai/sim/pull/8537/files#diff-47b01f359bdc1851c02b08d41af3e3215aabe3de12b61bba9c2e8ec103a8d308
apps/sim/lib/mothership/agent-cli/resource-owner.test.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-bd9863d912a956527e301b5fd51b240792151e20d55595d000a0b7c3563bf54d
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/agent-cli/resource-owner.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-bd9863d912a956527e301b5fd51b240792151e20d55595d000a0b7c3563bf54d
https://github.com/simstudioai/sim/pull/8537/files#diff-bd9863d912a956527e301b5fd51b240792151e20d55595d000a0b7c3563bf54d
https://github.com/simstudioai/sim/pull/8537/files#diff-bd9863d912a956527e301b5fd51b240792151e20d55595d000a0b7c3563bf54d
apps/sim/lib/mothership/request/tools/executor.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/request/tools/executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
https://github.com/simstudioai/sim/pull/8537/files#diff-42b57bff4502cb04d3c049cc5137e7208b20a861400af267c0f15f773633f6ab
apps/sim/lib/mothership/request/tools/resources.test.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-2504c6da07da771061e711d4a7d3b3d53236c7c80979df3ca17106fe79e6c750
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/request/tools/resources.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-2504c6da07da771061e711d4a7d3b3d53236c7c80979df3ca17106fe79e6c750
https://github.com/simstudioai/sim/pull/8537/files#diff-2504c6da07da771061e711d4a7d3b3d53236c7c80979df3ca17106fe79e6c750
https://github.com/simstudioai/sim/pull/8537/files#diff-2504c6da07da771061e711d4a7d3b3d53236c7c80979df3ca17106fe79e6c750
https://github.com/simstudioai/sim/pull/8537/files#diff-2504c6da07da771061e711d4a7d3b3d53236c7c80979df3ca17106fe79e6c750
apps/sim/lib/mothership/request/tools/resources.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-b729cdfd0afe30852a53657c417a28834afa0085c24d9002db8dd027d07322fe
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/request/tools/resources.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-b729cdfd0afe30852a53657c417a28834afa0085c24d9002db8dd027d07322fe
https://github.com/simstudioai/sim/pull/8537/files#diff-b729cdfd0afe30852a53657c417a28834afa0085c24d9002db8dd027d07322fe
apps/sim/lib/mothership/tools/registry/server-tool-adapter.test.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-1790db5587ce4b2342ccf5365c70cec1127e3418e7da5ef718e2089fabcd84c6
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/tools/registry/server-tool-adapter.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-1790db5587ce4b2342ccf5365c70cec1127e3418e7da5ef718e2089fabcd84c6
https://github.com/simstudioai/sim/pull/8537/files#diff-1790db5587ce4b2342ccf5365c70cec1127e3418e7da5ef718e2089fabcd84c6
apps/sim/lib/mothership/tools/server/open-resource.test.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-372f9710be0eba8312bdbeb507d6543a166c1f1313f8f51362fdada3be217072
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/tools/server/open-resource.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-372f9710be0eba8312bdbeb507d6543a166c1f1313f8f51362fdada3be217072
https://github.com/simstudioai/sim/pull/8537/files#diff-372f9710be0eba8312bdbeb507d6543a166c1f1313f8f51362fdada3be217072
apps/sim/lib/mothership/tools/server/open-resource.tshttps://github.com/simstudioai/sim/pull/8537/files#diff-47b57b2ed49629e7a0369c72d77dad793999a340c7a6cb7e27d8944e3957d84b
View file https://github.com/simstudioai/sim/blob/9f74b68d18f2f3adc3f82482b58442a944939de4/apps/sim/lib/mothership/tools/server/open-resource.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8537/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8537/files#diff-47b57b2ed49629e7a0369c72d77dad793999a340c7a6cb7e27d8944e3957d84b
https://github.com/simstudioai/sim/pull/8537/files#diff-47b57b2ed49629e7a0369c72d77dad793999a340c7a6cb7e27d8944e3957d84b
Please reload this pagehttps://github.com/simstudioai/sim/pull/8537/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.