René's URL Explorer Experiment


Title: fix(billing): build the mid-run usage card from the admitted payer and model the empty new-turn 402 by waleedlatif1 · Pull Request #8502 · simstudioai/sim · GitHub

Open Graph Title: fix(billing): build the mid-run usage card from the admitted payer and model the empty new-turn 402 by waleedlatif1 · Pull Request #8502 · simstudioai/sim

X Title: fix(billing): build the mid-run usage card from the admitted payer and model the empty new-turn 402 by waleedlatif1 · Pull Request #8502 · simstudioai/sim

Description: Summary Addresses two minor findings from the release review of the mid-run usage gate. 1. Mid-run upgrade card named the actor's plan, not the admitted payer's (release review threads on usage-upgrade.ts / update-cost / validate) Root cause. resolveUsageUpgradePayload picks the card from the attribution snapshot when a run is attributed. Otherwise it falls back to getHighestPrioritySubscription(userId), the actor's current subscription. Two mid-run callers reach that fallback for direct-v1 runs even though they already hold the payer the verdict was read for: the cost callback (readUsageStanding in app/api/billing/update-cost/route.ts) the continuation re-check in app/api/copilot/api-keys/validate/route.ts Whether the run pauses was always correct, because the verdict reads the payer's own usage. But if the actor's subscription or organization membership changed mid-run, the card could show the wrong action (upgrade_plan instead of increase_limit) or the wrong wording ("ask your admin" instead of "billing settings"). Fix. readMidRunAccountUsageVerdict already loads the payer's billing entity and subscription to read usage. An exceeded verdict now carries them as payer. resolveUsageUpgradePayload takes a UsageUpgradePayer ({ billingEntity, payerSubscription }). An attribution snapshot already has that shape, so attributed runs are unchanged. Both mid-run callers pass the attribution or, for direct-v1 runs, verdict.payer. This removes the second subscription read. The card is now decided without a query on both mid-run paths, so the 1 s card-read deadline in the cost callback can no longer fire. It is removed, along with its test. The verdict-read deadline is unchanged. Behaviour change. A direct-v1 run that goes over its limit mid-run gets the card for the payer it was admitted under. Admission and new-turn paths are unchanged. 2. The contract's 402 schema required a body the new-turn refusal never sends Root cause. validateCopilotApiKeyContract.response.statusSchemas[402] declared validateCopilotApiKeyRefusalSchema, but a new turn's usage refusal is an empty 402. This has been unchanged since before the release, and the schema's own TSDoc already says so. Continuations do send a body. Fix. Make the 402 schema .optional() so the contract describes both shapes. No runtime behaviour changes: no consumer validates this response against the contract. Findings judged not worth changing here Settle window assumes a run deadline (USAGE_SETTLE_MS). This is pre-existing, already documented in its TSDoc, and affects only the cached usage analytics. It matters only if the worker's run deadline is disabled; invoices, threshold billing and the gate read live sums. It is left for the change that removes the deadline. Test plan New tests fail on origin/staging source and pass with the fix (checked by reverting the source files only): update-cost route test: a direct-v1 run whose payer is an organization on a paid plan, while the actor's personal plan differs, gets increase_limit with organization wording. validate route test: a direct-v1 continuation refusal gets its admitted payer's card. validate route test: a new turn's empty 402 parses against the contract's declared 402 schema. vitest over app/api/billing, lib/billing, app/api/copilot, lib/mothership (one unrelated agent-cli test flaked under load and passes alone) bun run lint bun run type-check (apps/sim) bun run check:audits test:integration: not run, because no DB or Redis behaviour changes

Open Graph Description: Summary Addresses two minor findings from the release review of the mid-run usage gate. 1. Mid-run upgrade card named the actor's plan, not the admitted payer's (release review threads on u...

X Description: Summary Addresses two minor findings from the release review of the mid-run usage gate. 1. Mid-run upgrade card named the actor's plan, not the admitted payer's (release review thre...

Opengraph URL: https://github.com/simstudioai/sim/pull/8502

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7396097e-34a4-989b-b0af-a4a4fc5af09f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC716:186510:1B908E1:25740CB:6AFB912B
html-safe-nonce6c81e92a8a74a5286e8664f56085814db614c738c67000cec744a5f6b4dbddac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzE2OjE4NjUxMDoxQjkwOEUxOjI1NzQwQ0I6NkFGQjkxMkIiLCJ2aXNpdG9yX2lkIjoiNjcxNTk4NDk3ODk0Njc4OTY3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9d6852783d0404e311cab03c6722eee8b01f96a3684d6cf3881a4c03d61696af
hovercard-subject-tagpull_request:4698036385
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8502/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Addresses two minor findings from the release review of the mid-run usage gate. 1. Mid-run upgrade card named the actor's plan, not the admitted payer's (release review threads on u...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4f01efe06174a5ba6342fd58e42d02295e0675bedbb465d6bef2dbaec8e46556
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea52db8866b6543b4e83730cd6a6b1360f1a9e4dc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8502/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8502%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8502%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8502/files
Reloadhttps://github.com/simstudioai/sim/pull/8502/files
Reloadhttps://github.com/simstudioai/sim/pull/8502/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/midrun-usage-card-payer-and-402-contracthttps://github.com/simstudioai/sim/tree/fix/midrun-usage-card-payer-and-402-contract
Conversation 12 https://github.com/simstudioai/sim/pull/8502
Commits 3 https://github.com/simstudioai/sim/pull/8502/commits
Checks 31 https://github.com/simstudioai/sim/pull/8502/checks
Files changed https://github.com/simstudioai/sim/pull/8502/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8502/files
fix(billing): build the mid-run usage card from the admitted payer and model the empty new-turn 402 https://github.com/simstudioai/sim/pull/8502/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8502/files
bcda2e5 fix(billing): build the mid-run usage card from the admitted payer an… waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8502/commits/bcda2e5d1675105e19defff9bb294445f5f89729
132ad0c fix(billing): drop the unreachable card-read deadline from the usage … waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8502/commits/132ad0cada8e7887802a4caa66aeea6d6a699598
f0611c3 test(copilot): pin the new-turn usage refusal to an empty 402 waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8502/commits/f0611c3243f33766015744fc0b1a55cd86bba310
Clear filters https://github.com/simstudioai/sim/pull/8502/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8502/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8502/files
route.test.ts https://github.com/simstudioai/sim/pull/8502/files#diff-677bfcaef15030c7faf8ec352470f5316a835307b7e997ca1fac1a9e357b1d59
route.ts https://github.com/simstudioai/sim/pull/8502/files#diff-f3ec9e3eecbe194c2377f2e873f10be432af241ae9be88b693e9fec6699f335b
route.test.ts https://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
route.ts https://github.com/simstudioai/sim/pull/8502/files#diff-11279d916ce2d7a7a6c2ab9d16a47e66ac95888511d8dbd22152011c075cabf9
copilot.ts https://github.com/simstudioai/sim/pull/8502/files#diff-8b5dc9d30733bae6d14041b210bc4a1aacaa52829dcb1341289cf86395178fd0
mid-run-usage.ts https://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
usage-upgrade.ts https://github.com/simstudioai/sim/pull/8502/files#diff-7ead4da0c3d0a477558a9c09aae4281b2d1d36362712829d1f100f3830886364
apps/sim/app/api/billing/update-cost/route.test.tshttps://github.com/simstudioai/sim/pull/8502/files#diff-677bfcaef15030c7faf8ec352470f5316a835307b7e997ca1fac1a9e357b1d59
View file https://github.com/simstudioai/sim/blob/f0611c3243f33766015744fc0b1a55cd86bba310/apps/sim/app/api/billing/update-cost/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8502/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8502/files#diff-677bfcaef15030c7faf8ec352470f5316a835307b7e997ca1fac1a9e357b1d59
https://github.com/simstudioai/sim/pull/8502/files#diff-677bfcaef15030c7faf8ec352470f5316a835307b7e997ca1fac1a9e357b1d59
apps/sim/app/api/billing/update-cost/route.tshttps://github.com/simstudioai/sim/pull/8502/files#diff-f3ec9e3eecbe194c2377f2e873f10be432af241ae9be88b693e9fec6699f335b
View file https://github.com/simstudioai/sim/blob/f0611c3243f33766015744fc0b1a55cd86bba310/apps/sim/app/api/billing/update-cost/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8502/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8502/files#diff-f3ec9e3eecbe194c2377f2e873f10be432af241ae9be88b693e9fec6699f335b
https://github.com/simstudioai/sim/pull/8502/files#diff-f3ec9e3eecbe194c2377f2e873f10be432af241ae9be88b693e9fec6699f335b
https://github.com/simstudioai/sim/pull/8502/files#diff-f3ec9e3eecbe194c2377f2e873f10be432af241ae9be88b693e9fec6699f335b
https://github.com/simstudioai/sim/pull/8502/files#diff-f3ec9e3eecbe194c2377f2e873f10be432af241ae9be88b693e9fec6699f335b
apps/sim/app/api/copilot/api-keys/validate/route.test.tshttps://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
View file https://github.com/simstudioai/sim/blob/f0611c3243f33766015744fc0b1a55cd86bba310/apps/sim/app/api/copilot/api-keys/validate/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8502/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
https://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
https://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
Please reload this pagehttps://github.com/simstudioai/sim/pull/8502/files
https://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
https://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
https://github.com/simstudioai/sim/pull/8502/files#diff-5f87cf2acbc6646b935f3ead5fee036c12372aac4eb69c4bd164cf27f6d9d7a4
apps/sim/app/api/copilot/api-keys/validate/route.tshttps://github.com/simstudioai/sim/pull/8502/files#diff-11279d916ce2d7a7a6c2ab9d16a47e66ac95888511d8dbd22152011c075cabf9
View file https://github.com/simstudioai/sim/blob/f0611c3243f33766015744fc0b1a55cd86bba310/apps/sim/app/api/copilot/api-keys/validate/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8502/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8502/files#diff-11279d916ce2d7a7a6c2ab9d16a47e66ac95888511d8dbd22152011c075cabf9
https://github.com/simstudioai/sim/pull/8502/files#diff-11279d916ce2d7a7a6c2ab9d16a47e66ac95888511d8dbd22152011c075cabf9
apps/sim/lib/api/contracts/copilot.tshttps://github.com/simstudioai/sim/pull/8502/files#diff-8b5dc9d30733bae6d14041b210bc4a1aacaa52829dcb1341289cf86395178fd0
View file https://github.com/simstudioai/sim/blob/f0611c3243f33766015744fc0b1a55cd86bba310/apps/sim/lib/api/contracts/copilot.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8502/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8502/files#diff-8b5dc9d30733bae6d14041b210bc4a1aacaa52829dcb1341289cf86395178fd0
https://github.com/simstudioai/sim/pull/8502/files#diff-8b5dc9d30733bae6d14041b210bc4a1aacaa52829dcb1341289cf86395178fd0
apps/sim/lib/billing/core/mid-run-usage.tshttps://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
View file https://github.com/simstudioai/sim/blob/f0611c3243f33766015744fc0b1a55cd86bba310/apps/sim/lib/billing/core/mid-run-usage.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8502/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
https://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
https://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
https://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
https://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
https://github.com/simstudioai/sim/pull/8502/files#diff-875018a4710b7addc2df798782b921db6296a69c53c395dd3bdd3ad755189a66
apps/sim/lib/billing/usage-upgrade.tshttps://github.com/simstudioai/sim/pull/8502/files#diff-7ead4da0c3d0a477558a9c09aae4281b2d1d36362712829d1f100f3830886364
View file https://github.com/simstudioai/sim/blob/f0611c3243f33766015744fc0b1a55cd86bba310/apps/sim/lib/billing/usage-upgrade.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8502/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8502/files#diff-7ead4da0c3d0a477558a9c09aae4281b2d1d36362712829d1f100f3830886364
https://github.com/simstudioai/sim/pull/8502/files#diff-7ead4da0c3d0a477558a9c09aae4281b2d1d36362712829d1f100f3830886364
Please reload this pagehttps://github.com/simstudioai/sim/pull/8502/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.