Title: fix(search): close Slack and desktop source-connect review gaps by waleedlatif1 · Pull Request #8500 · simstudioai/sim · GitHub
Open Graph Title: fix(search): close Slack and desktop source-connect review gaps by waleedlatif1 · Pull Request #8500 · simstudioai/sim
X Title: fix(search): close Slack and desktop source-connect review gaps by waleedlatif1 · Pull Request #8500 · simstudioai/sim
Description: Summary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/slack-search.ts). The browser branch of useStartSlackSearchOAuth dropped the signal the mutation accepts, so closing or unmounting the wizard could not cancel an in-flight start. It is now forwarded to requestJson, matching the desktop branch and the personal-search hook. Signed-out managed Slack callback showed the generic failure (release review: app/credential-groups/slack-complete/page.tsx). The managed-users callback redirected with reason=unauthenticated, but the completion page and the desktop handoff (lib/desktop/source-browser.ts, lib/desktop/source-connect.ts) only recognize signin_required. The callback now sends signin_required, so a signed-out user gets the sign-in-and-restart guidance. The only other 'unauthenticated' consumer (hooks/mcp/use-mcp-oauth-popup.ts) belongs to the MCP popup and is unaffected. Desktop source-connect parsed up to the global JSON limit (release review: app/api/desktop/source-connect/route.ts). The route parsed bodies up to the default 50 MiB before the use case applied its 32 KiB ticket limit. It now sets parseOptions.maxBodyBytes: 64 * 1024, so oversized bodies get a 413 at the parser. Valid requests are well under that limit and behave the same. Not changed Zoom rollout skips workspaces without an organization (lib/sim-search/live/provider-rollout.ts). Not a real issue. Every Zoom Search path runs through connected accounts (credential groups). resolveCredentialGroupsAvailability in lib/credential-groups/availability.ts returns feature_disabled for any scope without an organization, so evaluating the Zoom flag globally for those workspaces could never enable anything. Desktop connect can start twice before inventory reflects completion (hooks/use-search-integration-connection.ts). Not a real issue. On desktop, mutateAsync resolves only after OAuth completes. isPending guards the click while it is in flight. TanStack Query awaits the mutation's onSettled before it resolves mutateAsync (query-core Mutation.execute), and that onSettled awaits the inventory invalidation. So by the time the click guard is released, connected already reflects the new account. The Zoom approval recheck, bounded MCP serialization, and ZOOM_SEARCH in .env.example are handled in #8496 and are left out here to avoid overlap. Type of Change Bug fix Testing Three new regression tests: the signed-out managed Slack callback redirects with signin_required, a 256 KiB source-connect body gets a 413, and aborting the signal rejects an in-flight browser Slack OAuth start. With each source fix reverted, its test fails. Restored, all three pass. bun run lint, bun run type-check (apps/sim), bun run check:audits (52/52) Manual desktop and Slack sign-in run-through (not performed) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/s...
X Description: Summary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/s...
Opengraph URL: https://github.com/simstudioai/sim/pull/8500
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3ef2a72b-54dc-0364-05f8-d2b5ce334caf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF52:B85F4:1BFDB4B:25F85EE:6AFB90E6 |
| html-safe-nonce | 279fdf7a6306a74c25cca5f6271510b662964b40e0e14202c60c1b6e95697645 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjUyOkI4NUY0OjFCRkRCNEI6MjVGODVFRTo2QUZCOTBFNiIsInZpc2l0b3JfaWQiOiI5OTQ5NDU4MjMyMDY1MTA4MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6a58b8034bd79da7fc5d4dda5a2ed90ccb9c14752c8aace1779c9711d5516496 |
| hovercard-subject-tag | pull_request:4697996495 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8500/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/s... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4f01efe06174a5ba6342fd58e42d02295e0675bedbb465d6bef2dbaec8e46556 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a52db8866b6543b4e83730cd6a6b1360f1a9e4dc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width