René's URL Explorer Experiment


Title: fix(search): close Slack and desktop source-connect review gaps by waleedlatif1 · Pull Request #8500 · simstudioai/sim · GitHub

Open Graph Title: fix(search): close Slack and desktop source-connect review gaps by waleedlatif1 · Pull Request #8500 · simstudioai/sim

X Title: fix(search): close Slack and desktop source-connect review gaps by waleedlatif1 · Pull Request #8500 · simstudioai/sim

Description: Summary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/slack-search.ts). The browser branch of useStartSlackSearchOAuth dropped the signal the mutation accepts, so closing or unmounting the wizard could not cancel an in-flight start. It is now forwarded to requestJson, matching the desktop branch and the personal-search hook. Signed-out managed Slack callback showed the generic failure (release review: app/credential-groups/slack-complete/page.tsx). The managed-users callback redirected with reason=unauthenticated, but the completion page and the desktop handoff (lib/desktop/source-browser.ts, lib/desktop/source-connect.ts) only recognize signin_required. The callback now sends signin_required, so a signed-out user gets the sign-in-and-restart guidance. The only other 'unauthenticated' consumer (hooks/mcp/use-mcp-oauth-popup.ts) belongs to the MCP popup and is unaffected. Desktop source-connect parsed up to the global JSON limit (release review: app/api/desktop/source-connect/route.ts). The route parsed bodies up to the default 50 MiB before the use case applied its 32 KiB ticket limit. It now sets parseOptions.maxBodyBytes: 64 * 1024, so oversized bodies get a 413 at the parser. Valid requests are well under that limit and behave the same. Not changed Zoom rollout skips workspaces without an organization (lib/sim-search/live/provider-rollout.ts). Not a real issue. Every Zoom Search path runs through connected accounts (credential groups). resolveCredentialGroupsAvailability in lib/credential-groups/availability.ts returns feature_disabled for any scope without an organization, so evaluating the Zoom flag globally for those workspaces could never enable anything. Desktop connect can start twice before inventory reflects completion (hooks/use-search-integration-connection.ts). Not a real issue. On desktop, mutateAsync resolves only after OAuth completes. isPending guards the click while it is in flight. TanStack Query awaits the mutation's onSettled before it resolves mutateAsync (query-core Mutation.execute), and that onSettled awaits the inventory invalidation. So by the time the click guard is released, connected already reflects the new account. The Zoom approval recheck, bounded MCP serialization, and ZOOM_SEARCH in .env.example are handled in #8496 and are left out here to avoid overlap. Type of Change Bug fix Testing Three new regression tests: the signed-out managed Slack callback redirects with signin_required, a 256 KiB source-connect body gets a 413, and aborting the signal rejects an in-flight browser Slack OAuth start. With each source fix reverted, its test fails. Restored, all three pass. bun run lint, bun run type-check (apps/sim), bun run check:audits (52/52) Manual desktop and Slack sign-in run-through (not performed) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/s...

X Description: Summary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/s...

Opengraph URL: https://github.com/simstudioai/sim/pull/8500

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3ef2a72b-54dc-0364-05f8-d2b5ce334caf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF52:B85F4:1BFDB4B:25F85EE:6AFB90E6
html-safe-nonce279fdf7a6306a74c25cca5f6271510b662964b40e0e14202c60c1b6e95697645
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjUyOkI4NUY0OjFCRkRCNEI6MjVGODVFRTo2QUZCOTBFNiIsInZpc2l0b3JfaWQiOiI5OTQ5NDU4MjMyMDY1MTA4MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6a58b8034bd79da7fc5d4dda5a2ed90ccb9c14752c8aace1779c9711d5516496
hovercard-subject-tagpull_request:4697996495
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8500/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups to the release review for the Slack Search, managed Slack, and desktop source-connect paths. Fixed Slack Search OAuth start ignored cancellation (release review: hooks/queries/s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4f01efe06174a5ba6342fd58e42d02295e0675bedbb465d6bef2dbaec8e46556
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea52db8866b6543b4e83730cd6a6b1360f1a9e4dc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8500/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8500%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8500%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8500/files
Reloadhttps://github.com/simstudioai/sim/pull/8500/files
Reloadhttps://github.com/simstudioai/sim/pull/8500/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/search-and-desktop-review-followupshttps://github.com/simstudioai/sim/tree/fix/search-and-desktop-review-followups
Conversation 12 https://github.com/simstudioai/sim/pull/8500
Commits 1 https://github.com/simstudioai/sim/pull/8500/commits
Checks 34 https://github.com/simstudioai/sim/pull/8500/checks
Files changed https://github.com/simstudioai/sim/pull/8500/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8500/files
fix(search): close Slack and desktop source-connect review gaps https://github.com/simstudioai/sim/pull/8500/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8500/files
cbab86c fix(search): close Slack and desktop source-connect review gaps waleedlatif1 Oct 1, 2026 https://github.com/simstudioai/sim/pull/8500/commits/cbab86cd423beb7baf793f54e1c5cdf9090ee3ad
Clear filters https://github.com/simstudioai/sim/pull/8500/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8500/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8500/files
route.test.ts https://github.com/simstudioai/sim/pull/8500/files#diff-8b2409b6c30ba93aac5faad908ccbde386073d0bdf5678dac212bd1f1244368f
route.ts https://github.com/simstudioai/sim/pull/8500/files#diff-e17b78ed506635f4a4aaced7dcdd75ad467ced3fe3e1641a3c6be29263196a1d
route.test.ts https://github.com/simstudioai/sim/pull/8500/files#diff-98aba48b3eb44de723bf5eb22fcb43a0c2b133fa6dd4846e2375cddb8adcf602
route.ts https://github.com/simstudioai/sim/pull/8500/files#diff-18e29d1e38bb6e41558a8cd7bae180839a3243a9f1408a688b6fbb31f9ab4402
slack-search.test.tsx https://github.com/simstudioai/sim/pull/8500/files#diff-935fd151dcba02d7b4d0f52eaa4b9bbba9f6c7a0576b01949fc3ee729e272e22
slack-search.ts https://github.com/simstudioai/sim/pull/8500/files#diff-5e1ecba894db5b83332958e4d6953011304ccfabaaebcbac3e58e9cde8da7970
apps/sim/app/api/credential-groups/slack-managed-users/callback/route.test.tshttps://github.com/simstudioai/sim/pull/8500/files#diff-8b2409b6c30ba93aac5faad908ccbde386073d0bdf5678dac212bd1f1244368f
View file https://github.com/simstudioai/sim/blob/cbab86cd423beb7baf793f54e1c5cdf9090ee3ad/apps/sim/app/api/credential-groups/slack-managed-users/callback/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8500/{{ revealButtonHref }}
apps/sim/app/api/credential-groups/slack-managed-users/callback/route.tshttps://github.com/simstudioai/sim/pull/8500/files#diff-e17b78ed506635f4a4aaced7dcdd75ad467ced3fe3e1641a3c6be29263196a1d
View file https://github.com/simstudioai/sim/blob/cbab86cd423beb7baf793f54e1c5cdf9090ee3ad/apps/sim/app/api/credential-groups/slack-managed-users/callback/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8500/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8500/files#diff-e17b78ed506635f4a4aaced7dcdd75ad467ced3fe3e1641a3c6be29263196a1d
https://github.com/simstudioai/sim/pull/8500/files#diff-e17b78ed506635f4a4aaced7dcdd75ad467ced3fe3e1641a3c6be29263196a1d
apps/sim/app/api/desktop/source-connect/route.test.tshttps://github.com/simstudioai/sim/pull/8500/files#diff-98aba48b3eb44de723bf5eb22fcb43a0c2b133fa6dd4846e2375cddb8adcf602
View file https://github.com/simstudioai/sim/blob/cbab86cd423beb7baf793f54e1c5cdf9090ee3ad/apps/sim/app/api/desktop/source-connect/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8500/{{ revealButtonHref }}
apps/sim/app/api/desktop/source-connect/route.tshttps://github.com/simstudioai/sim/pull/8500/files#diff-18e29d1e38bb6e41558a8cd7bae180839a3243a9f1408a688b6fbb31f9ab4402
View file https://github.com/simstudioai/sim/blob/cbab86cd423beb7baf793f54e1c5cdf9090ee3ad/apps/sim/app/api/desktop/source-connect/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8500/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8500/files#diff-18e29d1e38bb6e41558a8cd7bae180839a3243a9f1408a688b6fbb31f9ab4402
https://github.com/simstudioai/sim/pull/8500/files#diff-18e29d1e38bb6e41558a8cd7bae180839a3243a9f1408a688b6fbb31f9ab4402
apps/sim/hooks/queries/slack-search.test.tsxhttps://github.com/simstudioai/sim/pull/8500/files#diff-935fd151dcba02d7b4d0f52eaa4b9bbba9f6c7a0576b01949fc3ee729e272e22
View file https://github.com/simstudioai/sim/blob/cbab86cd423beb7baf793f54e1c5cdf9090ee3ad/apps/sim/hooks/queries/slack-search.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8500/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8500/files
apps/sim/hooks/queries/slack-search.tshttps://github.com/simstudioai/sim/pull/8500/files#diff-5e1ecba894db5b83332958e4d6953011304ccfabaaebcbac3e58e9cde8da7970
View file https://github.com/simstudioai/sim/blob/cbab86cd423beb7baf793f54e1c5cdf9090ee3ad/apps/sim/hooks/queries/slack-search.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8500/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8500/files#diff-5e1ecba894db5b83332958e4d6953011304ccfabaaebcbac3e58e9cde8da7970
https://github.com/simstudioai/sim/pull/8500/files#diff-5e1ecba894db5b83332958e4d6953011304ccfabaaebcbac3e58e9cde8da7970
Please reload this pagehttps://github.com/simstudioai/sim/pull/8500/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.