René's URL Explorer Experiment


Title: fix(mothership): never sweep a Chat run while one of its Sim tools is executing by waleedlatif1 · Pull Request #8482 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): never sweep a Chat run while one of its Sim tools is executing by waleedlatif1 · Pull Request #8482 · simstudioai/sim

X Title: fix(mothership): never sweep a Chat run while one of its Sim tools is executing by waleedlatif1 · Pull Request #8482 · simstudioai/sim

Description: Summary Problem. The orphaned-run sweep could settle a Chat run as interrupted while one of its Sim tools was still executing, which closes tool admission under a worker that still holds the run. Root cause. The sweep treats a leased run as orphaned once it has gone past the recovery window (ORPHANED_RUN_GRACE_MS, one hour) without a status write and no controller holds its chat lock. A Sim tool call writes nothing to its run while it executes. The only sign that it is alive is its execution lease heartbeat, and the sweep never checked it. A tool call that runs longer than the window, such as a long workflow run, therefore looked idle. The default one-hour run deadline hid this. Fix. The leased-run candidate predicate now excludes any run that has an unsettled, unrevoked tool execution whose lease has not expired (execution_lease_expires_at > clock_timestamp()). The same predicate guards both candidate selection and the guarded settle update. settleRuns now locks the candidate run rows (in id order, after the chat rows, matching the controller claim's lock order) before the guarded update. Tool admission locks its run row, so an admission racing the sweep either commits a lease that the update then sees, or finds the run already settled and is refused. settleRuns then locks the candidate runs' unsettled tool execution rows, after the run rows. A lease heartbeat writes only the tool row, so a renewal that commits first is seen by the guarded update, and a later heartbeat finds the lease expired. Behaviour changes A Chat run whose Sim tool holds a live execution lease is no longer swept, however long the tool runs. It becomes eligible once the lease expires, is revoked, or settles, and the run has been idle for the recovery window. The sweep adds one row lock per candidate run inside its existing transaction. The lock order is unchanged relative to controller claims (chats first, then runs, both by id). Legacy-run handling is unchanged. Test plan New integration test: a run idle past the window with a live tool execution lease is not settled (orphaned-runs.integration.ts) New integration test: a tool admitted while the sweep waits on the run's lock is seen, and the run is not settled New integration test: never settles a run whose Sim tool lease a heartbeat renewed as the sweep settled it The new tests fail on the pre-fix orphaned-runs.ts and pass with the fix (confirmed red, then green) The full orphaned-runs integration suite passes (20/20) against disposable Postgres and Redis (bun run test:integration lib/mothership/async-runs/orphaned-runs) bun run type-check (apps/sim), biome, check:test-patterns Staging: a Chat run with a Sim tool call running longer than an hour completes without being settled as interrupted

Open Graph Description: Summary Problem. The orphaned-run sweep could settle a Chat run as interrupted while one of its Sim tools was still executing, which closes tool admission under a worker that still holds the run. R...

X Description: Summary Problem. The orphaned-run sweep could settle a Chat run as interrupted while one of its Sim tools was still executing, which closes tool admission under a worker that still holds the run. R...

Opengraph URL: https://github.com/simstudioai/sim/pull/8482

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a118aa9-c61b-5e93-8237-5fd6f8b2705e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC988:E4B58:3EC6F2:560DEB:6AFB9975
html-safe-nonce9fffb801c82ba95fc1348eb4ff68cfb95b5a963c6e134c951014d9975b33b050
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTg4OkU0QjU4OjNFQzZGMjo1NjBERUI6NkFGQjk5NzUiLCJ2aXNpdG9yX2lkIjoiMTg0MzMxNDkyOTE4MDU4MDIxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace3cd0b8c7aab80c05299dc5630dcc971df92f8f001a1737a604930f3a0b0d479
hovercard-subject-tagpull_request:4696585681
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8482/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Problem. The orphaned-run sweep could settle a Chat run as interrupted while one of its Sim tools was still executing, which closes tool admission under a worker that still holds the run. R...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8482/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8482%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8482%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8482/files
Reloadhttps://github.com/simstudioai/sim/pull/8482/files
Reloadhttps://github.com/simstudioai/sim/pull/8482/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/orphaned-run-sweep-live-tool-leasehttps://github.com/simstudioai/sim/tree/fix/orphaned-run-sweep-live-tool-lease
Conversation 21 https://github.com/simstudioai/sim/pull/8482
Commits 2 https://github.com/simstudioai/sim/pull/8482/commits
Checks 33 https://github.com/simstudioai/sim/pull/8482/checks
Files changed https://github.com/simstudioai/sim/pull/8482/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8482/files
fix(mothership): never sweep a Chat run while one of its Sim tools is executing https://github.com/simstudioai/sim/pull/8482/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8482/files
246c0ef fix(mothership): never sweep a Chat run while one of its Sim tools is… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8482/commits/246c0ef9940c03837be0b133a4ddc5a4d214fe87
53ece36 fix(mothership): lock a run's unsettled tool executions before the sw… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8482/commits/53ece36113ac21e42382a64caf056e4b8623c098
Clear filters https://github.com/simstudioai/sim/pull/8482/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8482/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8482/files
orphaned-runs.integration.ts https://github.com/simstudioai/sim/pull/8482/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
orphaned-runs.ts https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
apps/sim/lib/mothership/async-runs/orphaned-runs.integration.tshttps://github.com/simstudioai/sim/pull/8482/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
View file https://github.com/simstudioai/sim/blob/53ece36113ac21e42382a64caf056e4b8623c098/apps/sim/lib/mothership/async-runs/orphaned-runs.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8482/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8482/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
https://github.com/simstudioai/sim/pull/8482/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
https://github.com/simstudioai/sim/pull/8482/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
Please reload this pagehttps://github.com/simstudioai/sim/pull/8482/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8482/files
https://github.com/simstudioai/sim/pull/8482/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
https://github.com/simstudioai/sim/pull/8482/files#diff-ec44c1c6e5915437ecd7e01af1911844cdd02ebc730abd5c8c8fb34498fdbb07
apps/sim/lib/mothership/async-runs/orphaned-runs.tshttps://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
View file https://github.com/simstudioai/sim/blob/53ece36113ac21e42382a64caf056e4b8623c098/apps/sim/lib/mothership/async-runs/orphaned-runs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8482/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
Please reload this pagehttps://github.com/simstudioai/sim/pull/8482/files
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
https://github.com/simstudioai/sim/pull/8482/files#diff-384a5854871f26d3d52fc6cf89369ea8fe0ad64d1870bcbd403a08053f4e1482
Please reload this pagehttps://github.com/simstudioai/sim/pull/8482/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.