René's URL Explorer Experiment


Title: fix(mothership): explain a Chat turn the worker ends without a reason by waleedlatif1 · Pull Request #8478 · simstudioai/sim · GitHub

Open Graph Title: fix(mothership): explain a Chat turn the worker ends without a reason by waleedlatif1 · Pull Request #8478 · simstudioai/sim

X Title: fix(mothership): explain a Chat turn the worker ends without a reason by waleedlatif1 · Pull Request #8478 · simstudioai/sim

Description: Summary Problem. When a resume or reattach reaches a Chat run that has already ended (for example at its deadline), the turn failed with the generic "An unexpected error occurred while processing the response." and gave no hint of what happened. Root cause. When the worker replays an ended run from its log, it sends an error terminal with no error event, because that replay does not carry the run's stored reason. runCopilotLifecycle saw completionStatus === error with an empty context.errors, so no specific message was set and callers fell back to the generic one. Fix. runCopilotLifecycle now detects that exact shape (error terminal, no reported error, no replay refusal, not aborted) and sets a surface-neutral message: "This run had already ended before it could continue." A reason the worker reports, a replay refusal, and a user Stop all still take precedence. The refusal wins by an explicit guard, not by spread order. Also: The Go stream's error text is now logged under errorMessage / detail, so it no longer overwrites the log line's own message field (go/stream.ts, session/buffer.ts). STREAM_TIMEOUT_MS is renamed CHAT_RUN_DEADLINE_MS and documented as the worker's default run deadline. Sim does not enforce it; it is only the base of USAGE_SETTLE_MS. The byte-budget doc now says a reader behind the replay-ring trim is re-synced from the worker log, and gets replay_gap only when that log cannot serve it. Behaviour changes A turn that reattaches to an already-ended run now shows "This run had already ended before it could continue." instead of the generic unexpected-error message. This applies to Chat, workflow execute, and inbox. Runs that fail with a worker-reported reason, runs refused on replay, and runs the user stopped behave as before. Log field names change for two Go-stream error log lines (message → errorMessage / detail). No change to billing values: USAGE_SETTLE_MS keeps the same number. Test plan lib/mothership/request/lifecycle/run.test.ts: new cases for an error terminal with no reason (gets the ended-run message), a replay refusal combined with a reasonless error terminal (refusal wins), and a Stop with a reasonless error terminal (stays a cancellation). Removing the fallback turns the ended-run case red; restoring it turns it green. lib/mothership/request/lifecycle and lib/mothership/request/go suites pass (185 tests). bun run type-check in apps/sim Biome check on changed files Staging: reattach to a Chat run past its deadline and confirm the new message

Open Graph Description: Summary Problem. When a resume or reattach reaches a Chat run that has already ended (for example at its deadline), the turn failed with the generic "An unexpected error occurred while process...

X Description: Summary Problem. When a resume or reattach reaches a Chat run that has already ended (for example at its deadline), the turn failed with the generic "An unexpected error occurred while pro...

Opengraph URL: https://github.com/simstudioai/sim/pull/8478

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:774875be-df0a-910b-c5e7-e298356c1823
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8B4:122EE4:4373F3:5BF242:6AFB9B5E
html-safe-nonce16cd3933272a7786a7530e69fd5bc05a02badc656646918c97a0bea464c057bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEI0OjEyMkVFNDo0MzczRjM6NUJGMjQyOjZBRkI5QjVFIiwidmlzaXRvcl9pZCI6IjM2MDU5MDExNDQ0NjQ1MzAyNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac41f2e1ae17892bbfb92e0751c6a431a2b422d444608176710acc30aa3866827e
hovercard-subject-tagpull_request:4696546188
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8478/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Problem. When a resume or reattach reaches a Chat run that has already ended (for example at its deadline), the turn failed with the generic "An unexpected error occurred while process...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3cefd19a936819d82cfb5279d50fb56fe79cb9ec30f0f807e04e89b0c58ffae1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release606800bdb1b81d125fc845bdcc262c9fe063fc8f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8478/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8478%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8478%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8478/files
Reloadhttps://github.com/simstudioai/sim/pull/8478/files
Reloadhttps://github.com/simstudioai/sim/pull/8478/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/chat-ended-run-terminal-messagehttps://github.com/simstudioai/sim/tree/fix/chat-ended-run-terminal-message
Conversation 15 https://github.com/simstudioai/sim/pull/8478
Commits 4 https://github.com/simstudioai/sim/pull/8478/commits
Checks 31 https://github.com/simstudioai/sim/pull/8478/checks
Files changed https://github.com/simstudioai/sim/pull/8478/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8478/files
fix(mothership): explain a Chat turn the worker ends without a reason https://github.com/simstudioai/sim/pull/8478/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8478/files
e35bb91 fix(mothership): explain a Chat turn the worker ends without a reason waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8478/commits/e35bb916af3a7f4e682beedc6c60971a3deb573e
b499e5f fix(mothership): keep the ended-run message surface-neutral and below… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8478/commits/b499e5fce5519e16c7528842a3593f4ff9caccc3
5a34b3e refactor(mothership): drop the unreachable refusal guard and reuse th… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8478/commits/5a34b3e64ca057e6c396dba74b9cd19967853031
183d321 Merge remote-tracking branch 'origin/staging' into fix/chat-ended-run… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8478/commits/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2
Clear filters https://github.com/simstudioai/sim/pull/8478/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8478/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8478/files
usage-analytics.ts https://github.com/simstudioai/sim/pull/8478/files#diff-e45fb96628aca131706ef3499776fd65ccfef3227afc613ab41e019499d2cebb
byte-budget.server.ts https://github.com/simstudioai/sim/pull/8478/files#diff-d27f814dc324ffc076144a10984df0e0d5434afda975f4f477f349730bd60d55
constants.ts https://github.com/simstudioai/sim/pull/8478/files#diff-3006a2807412edb7e9234dc3c5abd62fb755a80eadd17b7527846bd68dee47af
stream.ts https://github.com/simstudioai/sim/pull/8478/files#diff-29dd4793ccaeab3c3931ea582b0e129dd0fbc698931f516382d41b3f1ef51793
run.test.ts https://github.com/simstudioai/sim/pull/8478/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
run.ts https://github.com/simstudioai/sim/pull/8478/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
buffer.ts https://github.com/simstudioai/sim/pull/8478/files#diff-3523442e19f7ca7ea7476233be9cb95707b375b5cc5164fc889a592fedbbc44f
apps/sim/lib/billing/core/usage-analytics.tshttps://github.com/simstudioai/sim/pull/8478/files#diff-e45fb96628aca131706ef3499776fd65ccfef3227afc613ab41e019499d2cebb
View file https://github.com/simstudioai/sim/blob/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2/apps/sim/lib/billing/core/usage-analytics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8478/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8478/files#diff-e45fb96628aca131706ef3499776fd65ccfef3227afc613ab41e019499d2cebb
https://github.com/simstudioai/sim/pull/8478/files#diff-e45fb96628aca131706ef3499776fd65ccfef3227afc613ab41e019499d2cebb
https://github.com/simstudioai/sim/pull/8478/files#diff-e45fb96628aca131706ef3499776fd65ccfef3227afc613ab41e019499d2cebb
https://github.com/simstudioai/sim/pull/8478/files#diff-e45fb96628aca131706ef3499776fd65ccfef3227afc613ab41e019499d2cebb
apps/sim/lib/core/redis/byte-budget.server.tshttps://github.com/simstudioai/sim/pull/8478/files#diff-d27f814dc324ffc076144a10984df0e0d5434afda975f4f477f349730bd60d55
View file https://github.com/simstudioai/sim/blob/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2/apps/sim/lib/core/redis/byte-budget.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8478/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8478/files#diff-d27f814dc324ffc076144a10984df0e0d5434afda975f4f477f349730bd60d55
https://github.com/simstudioai/sim/pull/8478/files#diff-d27f814dc324ffc076144a10984df0e0d5434afda975f4f477f349730bd60d55
apps/sim/lib/mothership/constants.tshttps://github.com/simstudioai/sim/pull/8478/files#diff-3006a2807412edb7e9234dc3c5abd62fb755a80eadd17b7527846bd68dee47af
View file https://github.com/simstudioai/sim/blob/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2/apps/sim/lib/mothership/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8478/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8478/files#diff-3006a2807412edb7e9234dc3c5abd62fb755a80eadd17b7527846bd68dee47af
https://github.com/simstudioai/sim/pull/8478/files#diff-3006a2807412edb7e9234dc3c5abd62fb755a80eadd17b7527846bd68dee47af
apps/sim/lib/mothership/request/go/stream.tshttps://github.com/simstudioai/sim/pull/8478/files#diff-29dd4793ccaeab3c3931ea582b0e129dd0fbc698931f516382d41b3f1ef51793
View file https://github.com/simstudioai/sim/blob/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2/apps/sim/lib/mothership/request/go/stream.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8478/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8478/files#diff-29dd4793ccaeab3c3931ea582b0e129dd0fbc698931f516382d41b3f1ef51793
https://github.com/simstudioai/sim/pull/8478/files#diff-29dd4793ccaeab3c3931ea582b0e129dd0fbc698931f516382d41b3f1ef51793
https://github.com/simstudioai/sim/pull/8478/files#diff-29dd4793ccaeab3c3931ea582b0e129dd0fbc698931f516382d41b3f1ef51793
https://github.com/simstudioai/sim/pull/8478/files#diff-29dd4793ccaeab3c3931ea582b0e129dd0fbc698931f516382d41b3f1ef51793
apps/sim/lib/mothership/request/lifecycle/run.test.tshttps://github.com/simstudioai/sim/pull/8478/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
View file https://github.com/simstudioai/sim/blob/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2/apps/sim/lib/mothership/request/lifecycle/run.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8478/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8478/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
https://github.com/simstudioai/sim/pull/8478/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
https://github.com/simstudioai/sim/pull/8478/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
https://github.com/simstudioai/sim/pull/8478/files#diff-0391696e45945f80cdf49dc490d5bed440504197fb63965c30be6871e2eed616
apps/sim/lib/mothership/request/lifecycle/run.tshttps://github.com/simstudioai/sim/pull/8478/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
View file https://github.com/simstudioai/sim/blob/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2/apps/sim/lib/mothership/request/lifecycle/run.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8478/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8478/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
https://github.com/simstudioai/sim/pull/8478/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
https://github.com/simstudioai/sim/pull/8478/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
https://github.com/simstudioai/sim/pull/8478/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
https://github.com/simstudioai/sim/pull/8478/files#diff-42286b1c13539c62ff83806b87ad5eb1669e4ce1e893862f952cf81cdc440573
apps/sim/lib/mothership/request/session/buffer.tshttps://github.com/simstudioai/sim/pull/8478/files#diff-3523442e19f7ca7ea7476233be9cb95707b375b5cc5164fc889a592fedbbc44f
View file https://github.com/simstudioai/sim/blob/183d3219f4bc0881c4b397fe8ccde0c0de92c4e2/apps/sim/lib/mothership/request/session/buffer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8478/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8478/files#diff-3523442e19f7ca7ea7476233be9cb95707b375b5cc5164fc889a592fedbbc44f
https://github.com/simstudioai/sim/pull/8478/files#diff-3523442e19f7ca7ea7476233be9cb95707b375b5cc5164fc889a592fedbbc44f
Please reload this pagehttps://github.com/simstudioai/sim/pull/8478/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.