René's URL Explorer Experiment


Title: fix(logs): record a run's cost before it reads finished, and hold sync execute responses until the log is final by waleedlatif1 · Pull Request #8473 · simstudioai/sim · GitHub

Open Graph Title: fix(logs): record a run's cost before it reads finished, and hold sync execute responses until the log is final by waleedlatif1 · Pull Request #8473 · simstudioai/sim

X Title: fix(logs): record a run's cost before it reads finished, and hold sync execute responses until the log is final by waleedlatif1 · Pull Request #8473 · simstudioai/sim

Description: Summary completeWorkflowExecution committed a run's terminal status and cost_total, and only then read the payer's usage and wrote its usage_log ledger. In that window a finished run had no ledger rows, and buildCostLedger reports that as cost.items: null, which the logs contract defines as "this run has no ledger" (#8354) The ledger is now written before the terminal commit, together with the pre-increment usage reads the threshold email needs. The email is sent after the commit, as before cost_total keeps its current final value: when the ledger write sets the exact reconciled sum, the terminal commit leaves it alone; otherwise it applies the same GREATEST as before The billing safety net collapses to a single ledger write. recordExecutionUsage never throws, so a failed threshold read no longer needs a second attempt The internal /api/workflows/{id}/execute non-SSE sync path now waits for the background log finalizer before responding, so a caller that reads the log right after the response sees it final. #8369 does the same for v2 sync execute; together they close #8354 Type of Change Bug fix Testing New real-Postgres completion-ledger-order.integration.ts: across 20 real completions, a concurrent reader never sees a finished run without its ledger, and the ledger and cost_total both match the charge. On the original code it fails in all 20 runs (a local diagnostic saw the gap last up to 15 ms) New route test: the sync response is not sent until the log finalizer settles. It fails without the change Unit: lib/logs, lib/billing, execute routes (internal + v2), lib/workflows/executor, background — 1718 passed Integration: usage-threshold-email, usage-log, usage-reservation, pause-persistence, start-execution, secret-provenance, execution-archive-provenance, reporting-usage-cache, usage-analytics-queries, organization-activity, service-store — 99 passed bun run type-check, bun run lint, block-registry check, bun run check:audits, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary completeWorkflowExecution committed a run's terminal status and cost_total, and only then read the payer's usage and wrote its usage_log ledger. In that window a finished run had n...

X Description: Summary completeWorkflowExecution committed a run's terminal status and cost_total, and only then read the payer's usage and wrote its usage_log ledger. In that window a finished r...

Opengraph URL: https://github.com/simstudioai/sim/pull/8473

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:947e94f9-8cfd-1298-bac7-c8817b87edb4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEAC:11DC7C:1407490:1B4F9B5:6AFB7163
html-safe-noncef39b4f4ee7ec9c3e7aecb43fec9224dd7a5f71d5aeb8d3e045ef8d8ed2c42790
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUFDOjExREM3QzoxNDA3NDkwOjFCNEY5QjU6NkFGQjcxNjMiLCJ2aXNpdG9yX2lkIjoiMzM0MjI1ODQyMDk5NTI4OTQ0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb81eacba499b7036541bccbab4e54ecde2c9e70f7c625f664e42d3ceed805c35
hovercard-subject-tagpull_request:4693730016
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8473/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary completeWorkflowExecution committed a run's terminal status and cost_total, and only then read the payer's usage and wrote its usage_log ledger. In that window a finished run had n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8473/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8473%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8473%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8473/files
Reloadhttps://github.com/simstudioai/sim/pull/8473/files
Reloadhttps://github.com/simstudioai/sim/pull/8473/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests198 (198)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/log-ledger-before-terminalhttps://github.com/simstudioai/sim/tree/fix/log-ledger-before-terminal
Conversation 37 https://github.com/simstudioai/sim/pull/8473
Commits 6 https://github.com/simstudioai/sim/pull/8473/commits
Checks 31 https://github.com/simstudioai/sim/pull/8473/checks
Files changed https://github.com/simstudioai/sim/pull/8473/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8473/files
fix(logs): record a run's cost before it reads finished, and hold sync execute responses until the log is final https://github.com/simstudioai/sim/pull/8473/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/8473/files
ee376e6 fix(logs): record a run's cost before it reads finished, and hold syn… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8473/commits/ee376e66f75a6e8be0f6e6d3da6705266a880bf3
7e0af7b fix(logs): stop the ledger-order reader when a completion throws waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8473/commits/7e0af7b654320e480622961216e927738ef4cfcd
dca0465 fix(logs): keep a completion failure visible when the ledger-order re… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8473/commits/dca04658f140867f981ea80f96cfb666a9203eb9
ec69d07 fix(logs): let the ledger-order reader observe every finished run waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8473/commits/ec69d07bb263637911a0b48077b355c006ea3fbd
1ece8aa fix(logs): assert ledger-before-terminal ordering deterministically a… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8473/commits/1ece8aa4cd05d522883f2ccb77c15df5220a0dbf
4a3b2c0 fix(logs): scope the ledger-lock waiter to the execution and surface … waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8473/commits/4a3b2c0f5d23adc2dfa7f385dc7d4fd6db2ee062
Clear filters https://github.com/simstudioai/sim/pull/8473/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8473/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8473/files
route.test.ts https://github.com/simstudioai/sim/pull/8473/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
route.ts https://github.com/simstudioai/sim/pull/8473/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
completion-ledger-order.integration.ts https://github.com/simstudioai/sim/pull/8473/files#diff-91e033ddcea6f8d6498f46c18720220e976929a87b90c3fff6f3545924baddd0
logger.test.ts https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
logger.ts https://github.com/simstudioai/sim/pull/8473/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
apps/sim/app/api/workflows/[id]/execute/route.test.tshttps://github.com/simstudioai/sim/pull/8473/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
View file https://github.com/simstudioai/sim/blob/4a3b2c0f5d23adc2dfa7f385dc7d4fd6db2ee062/apps/sim/app/api/workflows/%5Bid%5D/execute/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8473/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8473/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
https://github.com/simstudioai/sim/pull/8473/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
https://github.com/simstudioai/sim/pull/8473/files#diff-0de39cc2f188cd7076e0fcd44c964c59166e8b00cfba3cfa16c6ffc1e3a4a177
apps/sim/app/api/workflows/[id]/execute/route.tshttps://github.com/simstudioai/sim/pull/8473/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
View file https://github.com/simstudioai/sim/blob/4a3b2c0f5d23adc2dfa7f385dc7d4fd6db2ee062/apps/sim/app/api/workflows/%5Bid%5D/execute/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8473/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8473/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
Please reload this pagehttps://github.com/simstudioai/sim/pull/8473/files
https://github.com/simstudioai/sim/pull/8473/files#diff-66f204feb589208a932d4b6c514237d545b8f1e9746092bbc35345f49570a9be
apps/sim/lib/logs/execution/completion-ledger-order.integration.tshttps://github.com/simstudioai/sim/pull/8473/files#diff-91e033ddcea6f8d6498f46c18720220e976929a87b90c3fff6f3545924baddd0
View file https://github.com/simstudioai/sim/blob/4a3b2c0f5d23adc2dfa7f385dc7d4fd6db2ee062/apps/sim/lib/logs/execution/completion-ledger-order.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8473/{{ revealButtonHref }}
apps/sim/lib/logs/execution/logger.test.tshttps://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
View file https://github.com/simstudioai/sim/blob/4a3b2c0f5d23adc2dfa7f385dc7d4fd6db2ee062/apps/sim/lib/logs/execution/logger.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8473/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
https://github.com/simstudioai/sim/pull/8473/files#diff-8c4f5ac108be5428c5d49656f82f56b6b45192e331adf3e402db58e1cda8e064
Please reload this pagehttps://github.com/simstudioai/sim/pull/8473/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8473/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.