René's URL Explorer Experiment


Title: fix(sim-cli): report an embedded SimApiError with its own exit code by waleedlatif1 · Pull Request #8462 · simstudioai/sim · GitHub

Open Graph Title: fix(sim-cli): report an embedded SimApiError with its own exit code by waleedlatif1 · Pull Request #8462 · simstudioai/sim

X Title: fix(sim-cli): report an embedded SimApiError with its own exit code by waleedlatif1 · Pull Request #8462 · simstudioai/sim

Description: Summary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for every SimApiError and ignored error.exitCode. The terminal renderer (terminal.ts) returns it. So when a workspace operation wait timed out (exit 4, OPERATION_WAIT_TIMEOUT) or the operation needed destination configuration (exit 3, REQUIRES_CONFIGURATION), an in-process run reported a generic failure. The installed CLI reported the real outcome. Now both report the same code. The stderr text is unchanged. Exit codes this surfaces The only SimApiErrors that carry a code other than 1 are the workspace-operation outcomes in workspace-operation-wait.ts: 3 when the operation requires configuration; 4 when the wait times out. Wrappers that rethrow an error keep its code. Soft exits such as workflows runs wait (0/1/2/3/4) already reached embedded callers through the embed context and are unaffected. Consumers Every caller of runEmbeddedCli branches only on zero vs non-zero: the Sim sim_cli tool handler; agent-CLI sink and curation; the Chat worker's result shaping and pipeline stages. A 3 or 4 that used to arrive as 1 is still a failure to each of them. A caller that wants to tell the outcomes apart, such as a wait that continues after "still running", can now read the real code. Test plan New embed test: an operation wait that times out returns exit 4, the operation receipt on stdout, and OPERATION_WAIT_TIMEOUT on stderr. It failed with exit 1 before the fix and passes after. sim-cli suite, bun run lint, type-check (sim-cli and apps/sim), bun run check:audits, and the apps/sim agent-CLI and tool-handler suites. Follow-ups (not in this PR) Detached synchronous runs. A workflows run that submits and then polls in bounded slices, so no single request stays open for the whole run. It is not built on async: true, because a queued run is a different run from a synchronous one: it gets the async execution timeout instead of the plan's synchronous limit; it uses the async rate-limit bucket and queue concurrency; a time-based pause keeps polling instead of returning; the run resource carries no output for a failed or paused run, while the synchronous response carries the partial output. It needs: a server option to queue a run under the caller's synchronous execution limits and rate bucket; the run resource returning partial output for failed and paused runs. The CLI would then submit with that option, poll with the loop workflows runs wait uses, print exactly what a synchronous run prints when it settles, and on timeout print the run record with exit 4. Block attribution on the v2 run resource. The polled run resource reclassifies a failed run's stored error string, so it reports no failing block, and a timeout or usage-limit failure known only from its HTTP status is not recognized. Recording the classification (code, plus the block when one is to blame) with the log at error finalization, and applying it on read, would make it match the synchronous response. That change also needs: updated public contract descriptions for code, blockId/blockName/blockType, and the run error (runs logged earlier and the resume response keep reclassifying); tests that fail when the classification is dropped by log compaction or skipped on the background-execution fallback path.

Open Graph Description: Summary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for every ...

X Description: Summary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for ev...

Opengraph URL: https://github.com/simstudioai/sim/pull/8462

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1db7e387-a14e-9171-1692-acb3a51c2ab0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFCE:394173:1B5D6BF:252D070:6AFB8E7C
html-safe-noncedea8e7ee4253226355993394cb4a7d200c2291565adc50664f4c3a998b1efc21
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkNFOjM5NDE3MzoxQjVENkJGOjI1MkQwNzA6NkFGQjhFN0MiLCJ2aXNpdG9yX2lkIjoiNzY4MjA1MjUzNTQ3Njc4NDc2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacee82494318449f32f10967449db5571c75f52cd60b60ac44933669fa06008075
hovercard-subject-tagpull_request:4689164766
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8462/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for every ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9694464143465782ecae2a97650b2a2b0708d5c31c74f41ee86da57e315e2735
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release05d967182208691fc7f2e6af52e82fa7fabf6bd5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8462/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8462%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8462%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8462/files
Reloadhttps://github.com/simstudioai/sim/pull/8462/files
Reloadhttps://github.com/simstudioai/sim/pull/8462/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/cli-embedded-exit-codeshttps://github.com/simstudioai/sim/tree/fix/cli-embedded-exit-codes
Conversation 8 https://github.com/simstudioai/sim/pull/8462
Commits 2 https://github.com/simstudioai/sim/pull/8462/commits
Checks 31 https://github.com/simstudioai/sim/pull/8462/checks
Files changed https://github.com/simstudioai/sim/pull/8462/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8462/files
fix(sim-cli): report an embedded SimApiError with its own exit code https://github.com/simstudioai/sim/pull/8462/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8462/files
0e30738 fix(sim-cli): report an embedded SimApiError with its own exit code waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8462/commits/0e30738f28008709b58bdf9b6fa6b93fa221d6ff
1634d0c test(sim-cli): make the embedded wait-timeout test independent of run… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8462/commits/1634d0c0cc31c5e5edc9ee6fde9b377ed7884293
Clear filters https://github.com/simstudioai/sim/pull/8462/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8462/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8462/files
embed.test.ts https://github.com/simstudioai/sim/pull/8462/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
embed.ts https://github.com/simstudioai/sim/pull/8462/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
packages/sim-cli/src/embed.test.tshttps://github.com/simstudioai/sim/pull/8462/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
View file https://github.com/simstudioai/sim/blob/1634d0c0cc31c5e5edc9ee6fde9b377ed7884293/packages/sim-cli/src/embed.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8462/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8462/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
https://github.com/simstudioai/sim/pull/8462/files#diff-d376751b5a131e777db6866118246a930897dc9633a27fdb24ddcc7a989406c9
packages/sim-cli/src/embed.tshttps://github.com/simstudioai/sim/pull/8462/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
View file https://github.com/simstudioai/sim/blob/1634d0c0cc31c5e5edc9ee6fde9b377ed7884293/packages/sim-cli/src/embed.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8462/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8462/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
https://github.com/simstudioai/sim/pull/8462/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
https://github.com/simstudioai/sim/pull/8462/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
https://github.com/simstudioai/sim/pull/8462/files#diff-b529d2a35d8e00b69ae4c44c43553d53785a20821e5d47abfea015cc6fcd3583
Please reload this pagehttps://github.com/simstudioai/sim/pull/8462/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.