Title: fix(sim-cli): report an embedded SimApiError with its own exit code by waleedlatif1 · Pull Request #8462 · simstudioai/sim · GitHub
Open Graph Title: fix(sim-cli): report an embedded SimApiError with its own exit code by waleedlatif1 · Pull Request #8462 · simstudioai/sim
X Title: fix(sim-cli): report an embedded SimApiError with its own exit code by waleedlatif1 · Pull Request #8462 · simstudioai/sim
Description: Summary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for every SimApiError and ignored error.exitCode. The terminal renderer (terminal.ts) returns it. So when a workspace operation wait timed out (exit 4, OPERATION_WAIT_TIMEOUT) or the operation needed destination configuration (exit 3, REQUIRES_CONFIGURATION), an in-process run reported a generic failure. The installed CLI reported the real outcome. Now both report the same code. The stderr text is unchanged. Exit codes this surfaces The only SimApiErrors that carry a code other than 1 are the workspace-operation outcomes in workspace-operation-wait.ts: 3 when the operation requires configuration; 4 when the wait times out. Wrappers that rethrow an error keep its code. Soft exits such as workflows runs wait (0/1/2/3/4) already reached embedded callers through the embed context and are unaffected. Consumers Every caller of runEmbeddedCli branches only on zero vs non-zero: the Sim sim_cli tool handler; agent-CLI sink and curation; the Chat worker's result shaping and pipeline stages. A 3 or 4 that used to arrive as 1 is still a failure to each of them. A caller that wants to tell the outcomes apart, such as a wait that continues after "still running", can now read the real code. Test plan New embed test: an operation wait that times out returns exit 4, the operation receipt on stdout, and OPERATION_WAIT_TIMEOUT on stderr. It failed with exit 1 before the fix and passes after. sim-cli suite, bun run lint, type-check (sim-cli and apps/sim), bun run check:audits, and the apps/sim agent-CLI and tool-handler suites. Follow-ups (not in this PR) Detached synchronous runs. A workflows run that submits and then polls in bounded slices, so no single request stays open for the whole run. It is not built on async: true, because a queued run is a different run from a synchronous one: it gets the async execution timeout instead of the plan's synchronous limit; it uses the async rate-limit bucket and queue concurrency; a time-based pause keeps polling instead of returning; the run resource carries no output for a failed or paused run, while the synchronous response carries the partial output. It needs: a server option to queue a run under the caller's synchronous execution limits and rate bucket; the run resource returning partial output for failed and paused runs. The CLI would then submit with that option, poll with the loop workflows runs wait uses, print exactly what a synchronous run prints when it settles, and on timeout print the run record with exit 4. Block attribution on the v2 run resource. The polled run resource reclassifies a failed run's stored error string, so it reports no failing block, and a timeout or usage-limit failure known only from its HTTP status is not recognized. Recording the classification (code, plus the block when one is to blame) with the log at error finalization, and applying it on read, would make it match the synchronous response. That change also needs: updated public contract descriptions for code, blockId/blockName/blockType, and the run error (runs logged earlier and the resume response keep reclassifying); tests that fail when the classification is dropped by log compaction or skipped on the background-execution fallback path.
Open Graph Description: Summary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for every ...
X Description: Summary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for ev...
Opengraph URL: https://github.com/simstudioai/sim/pull/8462
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1db7e387-a14e-9171-1692-acb3a51c2ab0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DFCE:394173:1B5D6BF:252D070:6AFB8E7C |
| html-safe-nonce | dea8e7ee4253226355993394cb4a7d200c2291565adc50664f4c3a998b1efc21 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkNFOjM5NDE3MzoxQjVENkJGOjI1MkQwNzA6NkFGQjhFN0MiLCJ2aXNpdG9yX2lkIjoiNzY4MjA1MjUzNTQ3Njc4NDc2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ee82494318449f32f10967449db5571c75f52cd60b60ac44933669fa06008075 |
| hovercard-subject-tag | pull_request:4689164766 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8462/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The embedded CLI now reports a SimApiError with that error's own exit code, as the installed CLI already does. renderEmbeddedError in packages/sim-cli/src/embed.ts returned 1 for every ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9694464143465782ecae2a97650b2a2b0708d5c31c74f41ee86da57e315e2735 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 05d967182208691fc7f2e6af52e82fa7fabf6bd5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width