René's URL Explorer Experiment


Title: fix(uploads): sign S3-compatible upload metadata as headers and allow S3_ENDPOINT in CSP by waleedlatif1 · Pull Request #8449 · simstudioai/sim · GitHub

Open Graph Title: fix(uploads): sign S3-compatible upload metadata as headers and allow S3_ENDPOINT in CSP by waleedlatif1 · Pull Request #8449 · simstudioai/sim

X Title: fix(uploads): sign S3-compatible upload metadata as headers and allow S3_ENDPOINT in CSP by waleedlatif1 · Pull Request #8449 · simstudioai/sim

Description: Summary With S3_ENDPOINT set, sign x-amz-meta-* upload metadata as headers (unhoistableHeaders) and return them for the uploader to send, instead of letting the presigner hoist them into the query string. S3-compatible stores such as OVHcloud, SeaweedFS, and RustFS ignore query-string metadata, so the object landed without uploadId and completion failed with "missing required provider metadata". Signed-header metadata is what the other official AWS SDKs do and works on every store checked AWS (no S3_ENDPOINT) keeps the query-string form unchanged, so existing bucket CORS rules can't regress Add the S3_ENDPOINT origin (port kept) to connect-src in both build-time and runtime CSP, plus *.host for virtual-hosted addressing (skipped for S3_FORCE_PATH_STYLE and IP hosts, which the SDK always addresses path-style). Previously the browser blocked every direct upload to a custom endpoint Docs: S3-compatible buckets need CORS AllowedHeaders: ["*"] (or Content-Type, If-None-Match, and the x-amz-meta-* headers) Fixes #8378 Type of Change Bug fix Testing presigned-upload.test.ts runs the real SigV4 presigner (local, no network): metadata is signed as headers for a custom endpoint, stays in the query for AWS, and every signed header the uploader controls is supplied with nothing both hoisted and sent csp.test.ts: virtual-hosted, path-style + port, IP host, scheme-less endpoint, and build-time policy New-behavior tests fail with the fix reverted; AWS-unchanged guards pass before and after bun run lint, type-check, check:audits (52/52), docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary With S3_ENDPOINT set, sign x-amz-meta-* upload metadata as headers (unhoistableHeaders) and return them for the uploader to send, instead of letting the presigner hoist them into the query...

X Description: Summary With S3_ENDPOINT set, sign x-amz-meta-* upload metadata as headers (unhoistableHeaders) and return them for the uploader to send, instead of letting the presigner hoist them into the query...

Opengraph URL: https://github.com/simstudioai/sim/pull/8449

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:93e7537e-b132-56a6-3a3b-1f9099e746e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE50:1BB96C:B13884:F2D4A1:6AFB5163
html-safe-nonce9438df46c9f32ef3ba1006c6563a2aa3f8c5c3c13c2c18fb16b6666d5858646d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTUwOjFCQjk2QzpCMTM4ODQ6RjJENEExOjZBRkI1MTYzIiwidmlzaXRvcl9pZCI6IjQ1NzczODgwNDI0NTc3ODc4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6bc696f7a1769852e887d0542e2d9962c1e0de0bcb9b55e6c3d11553b7f9f469
hovercard-subject-tagpull_request:4685881066
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8449/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary With S3_ENDPOINT set, sign x-amz-meta-* upload metadata as headers (unhoistableHeaders) and return them for the uploader to send, instead of letting the presigner hoist them into the query...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8449/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8449%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8449%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8449/files
Reloadhttps://github.com/simstudioai/sim/pull/8449/files
Reloadhttps://github.com/simstudioai/sim/pull/8449/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/s3-compatible-direct-uploadshttps://github.com/simstudioai/sim/tree/fix/s3-compatible-direct-uploads
Conversation 10 https://github.com/simstudioai/sim/pull/8449
Commits 2 https://github.com/simstudioai/sim/pull/8449/commits
Checks 31 https://github.com/simstudioai/sim/pull/8449/checks
Files changed https://github.com/simstudioai/sim/pull/8449/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8449/files
fix(uploads): sign S3-compatible upload metadata as headers and allow S3_ENDPOINT in CSP https://github.com/simstudioai/sim/pull/8449/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8449/files
48b27fc fix(uploads): sign S3-compatible upload metadata as headers and allow… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8449/commits/48b27fc816b9ab01ae20df4ce6677f7d99235efb
f069624 test(csp): pin S3_FORCE_PATH_STYLE unset in the CSP test env waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8449/commits/f06962435ede7a26007382004a3e1925eae728d4
Clear filters https://github.com/simstudioai/sim/pull/8449/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8449/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8449/files
object-storage.mdx https://github.com/simstudioai/sim/pull/8449/files#diff-370b24131e2379b6e62c501c225b03915126920524c1cea052eaf5c734091472
csp.test.ts https://github.com/simstudioai/sim/pull/8449/files#diff-5715f3f6598a999b504ed2c6f660d160d3f764c10d3ad3210bf360650cecbea4
csp.ts https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
client.test.ts https://github.com/simstudioai/sim/pull/8449/files#diff-35e8011c5cc779bb761eca22ac0125f7832884ac7ee9fd0a822d2f000e9e14f4
client.ts https://github.com/simstudioai/sim/pull/8449/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
presigned-upload.test.ts https://github.com/simstudioai/sim/pull/8449/files#diff-d7bfdfd7e0c05861d007a1c3475f6a4c704637e65def60dac93951be565bafb5
apps/docs/content/docs/platform/self-hosting/object-storage.mdxhttps://github.com/simstudioai/sim/pull/8449/files#diff-370b24131e2379b6e62c501c225b03915126920524c1cea052eaf5c734091472
View file https://github.com/simstudioai/sim/blob/f06962435ede7a26007382004a3e1925eae728d4/apps/docs/content/docs/platform/self-hosting/object-storage.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8449/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8449/files#diff-370b24131e2379b6e62c501c225b03915126920524c1cea052eaf5c734091472
https://github.com/simstudioai/sim/pull/8449/files#diff-370b24131e2379b6e62c501c225b03915126920524c1cea052eaf5c734091472
apps/sim/lib/core/security/csp.test.tshttps://github.com/simstudioai/sim/pull/8449/files#diff-5715f3f6598a999b504ed2c6f660d160d3f764c10d3ad3210bf360650cecbea4
View file https://github.com/simstudioai/sim/blob/f06962435ede7a26007382004a3e1925eae728d4/apps/sim/lib/core/security/csp.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8449/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8449/files#diff-5715f3f6598a999b504ed2c6f660d160d3f764c10d3ad3210bf360650cecbea4
Please reload this pagehttps://github.com/simstudioai/sim/pull/8449/files
https://github.com/simstudioai/sim/pull/8449/files#diff-5715f3f6598a999b504ed2c6f660d160d3f764c10d3ad3210bf360650cecbea4
https://github.com/simstudioai/sim/pull/8449/files#diff-5715f3f6598a999b504ed2c6f660d160d3f764c10d3ad3210bf360650cecbea4
https://github.com/simstudioai/sim/pull/8449/files#diff-5715f3f6598a999b504ed2c6f660d160d3f764c10d3ad3210bf360650cecbea4
https://github.com/simstudioai/sim/pull/8449/files#diff-5715f3f6598a999b504ed2c6f660d160d3f764c10d3ad3210bf360650cecbea4
apps/sim/lib/core/security/csp.tshttps://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
View file https://github.com/simstudioai/sim/blob/f06962435ede7a26007382004a3e1925eae728d4/apps/sim/lib/core/security/csp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8449/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8449/files
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
https://github.com/simstudioai/sim/pull/8449/files#diff-55fae7e120f150813b090d307e3c14acf16e4f8fc963478f3cb96f41f372746d
apps/sim/lib/uploads/providers/s3/client.test.tshttps://github.com/simstudioai/sim/pull/8449/files#diff-35e8011c5cc779bb761eca22ac0125f7832884ac7ee9fd0a822d2f000e9e14f4
View file https://github.com/simstudioai/sim/blob/f06962435ede7a26007382004a3e1925eae728d4/apps/sim/lib/uploads/providers/s3/client.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8449/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8449/files#diff-35e8011c5cc779bb761eca22ac0125f7832884ac7ee9fd0a822d2f000e9e14f4
https://github.com/simstudioai/sim/pull/8449/files#diff-35e8011c5cc779bb761eca22ac0125f7832884ac7ee9fd0a822d2f000e9e14f4
https://github.com/simstudioai/sim/pull/8449/files#diff-35e8011c5cc779bb761eca22ac0125f7832884ac7ee9fd0a822d2f000e9e14f4
https://github.com/simstudioai/sim/pull/8449/files#diff-35e8011c5cc779bb761eca22ac0125f7832884ac7ee9fd0a822d2f000e9e14f4
apps/sim/lib/uploads/providers/s3/client.tshttps://github.com/simstudioai/sim/pull/8449/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
View file https://github.com/simstudioai/sim/blob/f06962435ede7a26007382004a3e1925eae728d4/apps/sim/lib/uploads/providers/s3/client.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8449/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8449/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
https://github.com/simstudioai/sim/pull/8449/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
https://github.com/simstudioai/sim/pull/8449/files#diff-5b5c75fd8b0e84e44544dfe3eb319a86603568755f5568c5b4ce3007b519927e
apps/sim/lib/uploads/providers/s3/presigned-upload.test.tshttps://github.com/simstudioai/sim/pull/8449/files#diff-d7bfdfd7e0c05861d007a1c3475f6a4c704637e65def60dac93951be565bafb5
View file https://github.com/simstudioai/sim/blob/f06962435ede7a26007382004a3e1925eae728d4/apps/sim/lib/uploads/providers/s3/presigned-upload.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8449/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8449/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.