Title: fix(execution): publish a pause only after its run log is finalized by waleedlatif1 · Pull Request #8446 · simstudioai/sim · GitHub
Open Graph Title: fix(execution): publish a pause only after its run log is finalized by waleedlatif1 · Pull Request #8446 · simstudioai/sim
X Title: fix(execution): publish a pause only after its run log is finalized by waleedlatif1 · Pull Request #8446 · simstudioai/sim
Description: Summary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable while its log was still running A resume arriving in that window was admitted, then rejected at the log claim (claimResumeExecutionLog accepts only pending/paused) with a non-retryable ResumeAdmissionError: Execution can no longer be resumed; a timed-wait auto-resume that lost the race was parked as intervention_required with no retry handlePostExecutionPauseState now awaits waitForPostExecution() before publishing a pause. It is the single path every initial-run entry point takes (sync/SSE execute routes, v2 execute service, executeWorkflow, background workflow/schedule/webhook), and matches the resume path, which already settles its log before persisting a re-pause If the paused log was never persisted (primary and fallback writes both failed), the run is failed via markAsFailed instead of publishing a pause no resume could claim Complementary to #8369, which applies the same settle-before-respond rule to completed sync runs Type of Change Bug fix Testing New real-Postgres pause-persistence.integration.ts (2 cases): holds the log finalizer open and records, at the moment the pause is published, whether the log was finalized; then asserts the log is pending and an immediate resume is admitted a finalizer that never persisted the log fails the run and publishes no pause Original code: both cases red ([false] at publish; log left running). Each guard reverted on its own turns its case red; green with the fix Existing caller suites: webhook/workflow/schedule execution, both execute routes, execute-workflow, execute-service, human-in-the-loop-manager — 248 passed bun run type-check, bun run lint, block-registry check, bun run check:audits, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable...
X Description: Summary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable...
Opengraph URL: https://github.com/simstudioai/sim/pull/8446
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cbaf7809-cf32-511f-6b87-6177d73c9361 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD2A:11532:B27717:FC1E79:6AFB5986 |
| html-safe-nonce | 096174d842020951ca79b94f5ddda89df763bacd3ffa22b85837fd8c1ec2f7a2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDJBOjExNTMyOkIyNzcxNzpGQzFFNzk6NkFGQjU5ODYiLCJ2aXNpdG9yX2lkIjoiNTMwOTYwNDU3MzU5NjA0Nzc1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 10f4ce450cf03ad7effdfdc30f6dc4b64b5ae91f5525e1bd9e7c94f6e345f3d1 |
| hovercard-subject-tag | pull_request:4685124817 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8446/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width