René's URL Explorer Experiment


Title: fix(execution): publish a pause only after its run log is finalized by waleedlatif1 · Pull Request #8446 · simstudioai/sim · GitHub

Open Graph Title: fix(execution): publish a pause only after its run log is finalized by waleedlatif1 · Pull Request #8446 · simstudioai/sim

X Title: fix(execution): publish a pause only after its run log is finalized by waleedlatif1 · Pull Request #8446 · simstudioai/sim

Description: Summary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable while its log was still running A resume arriving in that window was admitted, then rejected at the log claim (claimResumeExecutionLog accepts only pending/paused) with a non-retryable ResumeAdmissionError: Execution can no longer be resumed; a timed-wait auto-resume that lost the race was parked as intervention_required with no retry handlePostExecutionPauseState now awaits waitForPostExecution() before publishing a pause. It is the single path every initial-run entry point takes (sync/SSE execute routes, v2 execute service, executeWorkflow, background workflow/schedule/webhook), and matches the resume path, which already settles its log before persisting a re-pause If the paused log was never persisted (primary and fallback writes both failed), the run is failed via markAsFailed instead of publishing a pause no resume could claim Complementary to #8369, which applies the same settle-before-respond rule to completed sync runs Type of Change Bug fix Testing New real-Postgres pause-persistence.integration.ts (2 cases): holds the log finalizer open and records, at the moment the pause is published, whether the log was finalized; then asserts the log is pending and an immediate resume is admitted a finalizer that never persisted the log fails the run and publishes no pause Original code: both cases red ([false] at publish; log left running). Each guard reverted on its own turns its case red; green with the fix Existing caller suites: webhook/workflow/schedule execution, both execute routes, execute-workflow, execute-service, human-in-the-loop-manager — 248 passed bun run type-check, bun run lint, block-registry check, bun run check:audits, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable...

X Description: Summary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable...

Opengraph URL: https://github.com/simstudioai/sim/pull/8446

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cbaf7809-cf32-511f-6b87-6177d73c9361
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD2A:11532:B27717:FC1E79:6AFB5986
html-safe-nonce096174d842020951ca79b94f5ddda89df763bacd3ffa22b85837fd8c1ec2f7a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDJBOjExNTMyOkIyNzcxNzpGQzFFNzk6NkFGQjU5ODYiLCJ2aXNpdG9yX2lkIjoiNTMwOTYwNDU3MzU5NjA0Nzc1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac10f4ce450cf03ad7effdfdc30f6dc4b64b5ae91f5525e1bd9e7c94f6e345f3d1
hovercard-subject-tagpull_request:4685124817
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8446/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary executeWorkflowCore finalizes the run log (running → redacting → pending) in a background post-execution promise, and callers published the pause right after, so a pause could be resumable...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8446/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8446%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8446%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8446/files
Reloadhttps://github.com/simstudioai/sim/pull/8446/files
Reloadhttps://github.com/simstudioai/sim/pull/8446/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/pause-publish-after-log-finalizehttps://github.com/simstudioai/sim/tree/fix/pause-publish-after-log-finalize
Conversation 18 https://github.com/simstudioai/sim/pull/8446
Commits 3 https://github.com/simstudioai/sim/pull/8446/commits
Checks 31 https://github.com/simstudioai/sim/pull/8446/checks
Files changed https://github.com/simstudioai/sim/pull/8446/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8446/files
fix(execution): publish a pause only after its run log is finalized https://github.com/simstudioai/sim/pull/8446/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8446/files
ac35656 fix(execution): publish a pause only after its run log is finalized waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8446/commits/ac35656d5886def2922b7122b1eee05a283c24b1
10bc116 fix(execution): fail a paused run whose log was never finalized inste… waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8446/commits/10bc116347024ad2b447d22bac12d52fca0e0fa5
81b2e99 fix(execution): restore the publish spy explicitly instead of in a hook waleedlatif1 Sep 30, 2026 https://github.com/simstudioai/sim/pull/8446/commits/81b2e99fe42f70a9911f70506642438f44dd7cf9
Clear filters https://github.com/simstudioai/sim/pull/8446/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8446/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8446/files
pause-persistence.integration.ts https://github.com/simstudioai/sim/pull/8446/files#diff-3cf3eb2eb1a15151da29da660b7d70f663a7bd6050181f593eb49c75f875e911
pause-persistence.ts https://github.com/simstudioai/sim/pull/8446/files#diff-9a984c11cb7b01067171772619556cadb351e42707dbfc3f079abc0915b4c01b
apps/sim/lib/workflows/executor/pause-persistence.integration.tshttps://github.com/simstudioai/sim/pull/8446/files#diff-3cf3eb2eb1a15151da29da660b7d70f663a7bd6050181f593eb49c75f875e911
View file https://github.com/simstudioai/sim/blob/81b2e99fe42f70a9911f70506642438f44dd7cf9/apps/sim/lib/workflows/executor/pause-persistence.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8446/{{ revealButtonHref }}
apps/sim/lib/workflows/executor/pause-persistence.tshttps://github.com/simstudioai/sim/pull/8446/files#diff-9a984c11cb7b01067171772619556cadb351e42707dbfc3f079abc0915b4c01b
View file https://github.com/simstudioai/sim/blob/81b2e99fe42f70a9911f70506642438f44dd7cf9/apps/sim/lib/workflows/executor/pause-persistence.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8446/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8446/files#diff-9a984c11cb7b01067171772619556cadb351e42707dbfc3f079abc0915b4c01b
https://github.com/simstudioai/sim/pull/8446/files#diff-9a984c11cb7b01067171772619556cadb351e42707dbfc3f079abc0915b4c01b
Please reload this pagehttps://github.com/simstudioai/sim/pull/8446/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8446/files
https://github.com/simstudioai/sim/pull/8446/files#diff-9a984c11cb7b01067171772619556cadb351e42707dbfc3f079abc0915b4c01b
Please reload this pagehttps://github.com/simstudioai/sim/pull/8446/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.