Title: fix(confluence): retry transient attachment metadata 500s and skip a failing parent instead of aborting the sync by waleedlatif1 · Pull Request #8443 · simstudioai/sim · GitHub
Open Graph Title: fix(confluence): retry transient attachment metadata 500s and skip a failing parent instead of aborting the sync by waleedlatif1 · Pull Request #8443 · simstudioai/sim
X Title: fix(confluence): retry transient attachment metadata 500s and skip a failing parent instead of aborting the sync by waleedlatif1 · Pull Request #8443 · simstudioai/sim
Description: Summary Atlassian intermittently answers attachment metadata GETs with a bare 500, which the shared retry set never retries, so a single 500 aborted the whole Confluence sync and put the connector into failure backoff Retry 500s on attachment metadata reads through the existing fetcher + retryCondition hooks (same pattern as Coda / Google Workspace), scoped to the Confluence connector; shared isRetryableError is unchanged A parent whose attachment listing still 5xx's after retries is skipped and recorded as a listing failure, same path as the existing 403/404/scope handling, so deletion reconciliation is held and the parent is retried next sync Three consecutive server failures still fail the sync, so a real Atlassian outage fails fast instead of spending the retry budget on every remaining parent Log Atlassian's atl-traceid / x-arequestid response headers for every 5xx attempt so failures can be traced with Atlassian support; the error body is never read or logged, so a stalled body cannot consume the retry budget 5xx metadata errors now carry their status (provider_unavailable), so sync diagnostics classify them instead of reporting none; the error message is unchanged Docs: the Atlassian service-account page (the setup guide the connector modal links for non-Search knowledge bases) now lists the connector's full service-account scope set from confluenceConnectorMeta.serviceAccountScopes, including read:attachment:confluence, and how to replace a token that is missing scopes Type of Change Bug fix Testing New cases in connectors/confluence/attachments.test.ts: transient 500 retried (including one whose body never finishes), isolated persistent failures skipped with deletions held, consecutive 500/503 fail the sync, trace ids logged but never the body Each case goes red on the pre-fix code or with its guard reverted individually (retry, skip, outage cap, streak reset, header sanitization, body leak) connectors/confluence/ + lib/knowledge/connectors/ suites, bun run type-check, bun run lint, bun run check:audits, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Atlassian intermittently answers attachment metadata GETs with a bare 500, which the shared retry set never retries, so a single 500 aborted the whole Confluence sync and put the connector...
X Description: Summary Atlassian intermittently answers attachment metadata GETs with a bare 500, which the shared retry set never retries, so a single 500 aborted the whole Confluence sync and put the connector...
Opengraph URL: https://github.com/simstudioai/sim/pull/8443
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2a9c3464-5bc0-049e-7b25-a4758649a14e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A5C6:25245F:B1A62F:F3EC81:6AFB526F |
| html-safe-nonce | 09833665a41a3804edace34afdafb6c1f8484af3841b4f1539a28b156a215180 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUM2OjI1MjQ1RjpCMUE2MkY6RjNFQzgxOjZBRkI1MjZGIiwidmlzaXRvcl9pZCI6Ijc5MzU1OTQ0Nzk0MTMzMTgyNTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a511497077e48466f9bb75bd61172713111ff4fa33d9f16bac318c0a8a5adc0f |
| hovercard-subject-tag | pull_request:4684648516 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8443/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Atlassian intermittently answers attachment metadata GETs with a bare 500, which the shared retry set never retries, so a single 500 aborted the whole Confluence sync and put the connector... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width