René's URL Explorer Experiment


Title: fix(desktop-browser): ask the user before a page's alert, confirm, or leave-site prompt is answered by waleedlatif1 · Pull Request #8432 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop-browser): ask the user before a page's alert, confirm, or leave-site prompt is answered by waleedlatif1 · Pull Request #8432 · simstudioai/sim

X Title: fix(desktop-browser): ask the user before a page's alert, confirm, or leave-site prompt is answered by waleedlatif1 · Pull Request #8432 · simstudioai/sim

Description: Summary Let users answer alerts and confirmations on their visible browser page through a single native Electron dialog. Preserve the complete website message and restore keyboard focus after dismissal. Prevent automation and Stop from answering a dialog owned by the user. Agent actions, unclaimed tabs, hidden pages, and older renderers retain their existing automatic behavior. Ask before browser-chrome navigation discards a draft. Stay is the default, Escape keeps the draft, and Leave replays the navigation once. Clear stale decisions after navigation or a renderer crash. Keep the renderer modal limited to the leave-page decision, using the existing shared modal and browser focus lifecycle. Type of Change Bug fix Testing All 1,070 desktop tests, 41 browser/store tests, all workspace type checks, lint, all 58 audits, docs-manifest, and block-registry checks pass. Both full repository test shards pass in CI. Real Electron coverage exercises renderer compatibility, user/agent ownership, complete dialog messages, automation cancellation, unsaved drafts, stale decisions, and hidden pages. Reports support DESKTOP_BROWSER_DIALOGS_REPORT_PATH. Isolated macOS CI: 91 Electron E2E tests passed (15 environment-specific skips), including browser dialogs, keyboard focus, themed shell dialogs, and password autofill. All 12 real Sim desktop E2E cases passed, along with universal packaging and packaged smoke tests. Physical macOS QA reproduced lost keyboard focus before the fix and verified typing after native alert dismissal and confirmation cancellation with the fix. Electron currently resolves a CDP dialog answer without necessarily closing its native sheet. The unchanged agent/fallback path retains that upstream limitation; the new user path lets Electron own both the answer and physical dismissal. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Let users answer alerts and confirmations on their visible browser page through a single native Electron dialog. Preserve the complete website message and restore keyboard focus after dism...

X Description: Summary Let users answer alerts and confirmations on their visible browser page through a single native Electron dialog. Preserve the complete website message and restore keyboard focus after dism...

Opengraph URL: https://github.com/simstudioai/sim/pull/8432

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:46a304a8-c685-4f01-2738-b4f51b7f6d69
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD130:1B8129:140EE15:1B77228:6AFB7578
html-safe-nonce8456c97b0a0cb9441180a1ecc5a61da882fe57fafa3c49eb21c02f131f478ba9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTMwOjFCODEyOToxNDBFRTE1OjFCNzcyMjg6NkFGQjc1NzgiLCJ2aXNpdG9yX2lkIjoiNzIzMDQwNDk0MTU0NDM4Nzk2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb4296d7c44299de869f85a11ff1c7aa7a679e506b75d73420a5521247356c683
hovercard-subject-tagpull_request:4682562729
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8432/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Let users answer alerts and confirmations on their visible browser page through a single native Electron dialog. Preserve the complete website message and restore keyboard focus after dism...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8432/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8432%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8432%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8432/files
Reloadhttps://github.com/simstudioai/sim/pull/8432/files
Reloadhttps://github.com/simstudioai/sim/pull/8432/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests201 (201)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/browser-page-dialogshttps://github.com/simstudioai/sim/tree/fix/browser-page-dialogs
Conversation 37 https://github.com/simstudioai/sim/pull/8432
Commits 4 https://github.com/simstudioai/sim/pull/8432/commits
Checks 52 https://github.com/simstudioai/sim/pull/8432/checks
Files changed https://github.com/simstudioai/sim/pull/8432/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8432/files
fix(desktop-browser): ask the user before a page's alert, confirm, or leave-site prompt is answered https://github.com/simstudioai/sim/pull/8432/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8432/files
be9ba65 fix(desktop-browser): ask the user before a page's alert, confirm, or… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8432/commits/be9ba650e053dc3de647939ee2bbc0efee03595b
1a4ef00 fix(desktop-browser): ask only about the user's own on-screen page, n… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8432/commits/1a4ef0032d6fc2a9f6f620eb4273898c94e81ac9
464ed21 fix(desktop-browser): label frame dialogs with their own origin and c… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8432/commits/464ed2150477f95c9c181553e3547dd025ec5470
41040be fix(desktop-browser): preserve native dialog ownership and keyboard f… waleedlatif1 Oct 9, 2026 https://github.com/simstudioai/sim/pull/8432/commits/41040be9560de9d746a9b68ae991b8ce3358d0ee
Clear filters https://github.com/simstudioai/sim/pull/8432/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8432/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8432/files
browser-page-dialogs.spec.ts https://github.com/simstudioai/sim/pull/8432/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
cdp.test.ts https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
cdp.ts https://github.com/simstudioai/sim/pull/8432/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
driver.ts https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
session.ts https://github.com/simstudioai/sim/pull/8432/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
browser-page-dialog.tsx https://github.com/simstudioai/sim/pull/8432/files#diff-6675055f3d1d1cbcc7a2b7d0e0d4b05a8dcd2cfa73ab1589a32f03f7d47e75e5
browser-session.tsx https://github.com/simstudioai/sim/pull/8432/files#diff-dc77efde736e424d320cd580e8aa6877a1618db528f899e81f2331a6daf162a2
store.ts https://github.com/simstudioai/sim/pull/8432/files#diff-0ea4d102398b9f8662c131093d08a7b5ebdb31d87e4e7e159347266cc0cbdcbc
index.ts https://github.com/simstudioai/sim/pull/8432/files#diff-7bf024cc51a5498c6b4d087358740c2011c9d5ea86c03391bd1d4623026224d3
apps/desktop/e2e/browser-page-dialogs.spec.tshttps://github.com/simstudioai/sim/pull/8432/files#diff-b09f848f811413e82d620ee40d653ba2b1b9046ecc55812ac087ade8bd992589
View file https://github.com/simstudioai/sim/blob/41040be9560de9d746a9b68ae991b8ce3358d0ee/apps/desktop/e2e/browser-page-dialogs.spec.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/8432/files
apps/desktop/src/main/browser-agent/cdp.test.tshttps://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
View file https://github.com/simstudioai/sim/blob/41040be9560de9d746a9b68ae991b8ce3358d0ee/apps/desktop/src/main/browser-agent/cdp.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8432/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
https://github.com/simstudioai/sim/pull/8432/files#diff-5c99463d5fbb5f5a8d4c7d7b2b621e8fd2ef38db866cff2a75a92fd65859a5c6
apps/desktop/src/main/browser-agent/cdp.tshttps://github.com/simstudioai/sim/pull/8432/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
View file https://github.com/simstudioai/sim/blob/41040be9560de9d746a9b68ae991b8ce3358d0ee/apps/desktop/src/main/browser-agent/cdp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8432/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8432/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
https://github.com/simstudioai/sim/pull/8432/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
https://github.com/simstudioai/sim/pull/8432/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
https://github.com/simstudioai/sim/pull/8432/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
https://github.com/simstudioai/sim/pull/8432/files#diff-20197f234b92c7c1c2b522668174347c28d21a740fb487409f3b3637a423473c
apps/desktop/src/main/browser-agent/driver.tshttps://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
View file https://github.com/simstudioai/sim/blob/41040be9560de9d746a9b68ae991b8ce3358d0ee/apps/desktop/src/main/browser-agent/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8432/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8432/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
Please reload this pagehttps://github.com/simstudioai/sim/pull/8432/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8432/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.