Title: fix(desktop-browser): keep the chat caret while the agent works and route reload/back to the browser tab by waleedlatif1 · Pull Request #8429 · simstudioai/sim · GitHub
Open Graph Title: fix(desktop-browser): keep the chat caret while the agent works and route reload/back to the browser tab by waleedlatif1 · Pull Request #8429 · simstudioai/sim
X Title: fix(desktop-browser): keep the chat caret while the agent works and route reload/back to the browser tab by waleedlatif1 · Pull Request #8429 · simstudioai/sim
Description: Summary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromium focuses anyway (a target=_blank link opened without an opener) hands focus back to Sim Focus moves into a page only on explicit user actions: omnibox Enter, opening a URL in a new tab, and foreground links the user opens; a page not yet on screen takes focus when it is first shown Cmd/Ctrl+R, Cmd/Ctrl+Shift+R, F5, Shift/Ctrl+F5 typed in a page reload that page from its own keystroke instead of relying on the app menu's focus guess (which could reload all of Sim); F5 is now bound in the menu too Clicking from browser chrome into the page no longer wipes the page's shortcut claim (setPanelFocused(false) keeps a claim the native page still holds) Browser shortcuts (Cmd+T, reload, zoom, tab switching) work while a renderer-drawn New Tab or error page hides the native view Back (Cmd+[) and new Forward (Cmd+]) move through the focused tab's history instead of navigating the Sim window Cmd/middle-click and "Open Link in New Tab" open background tabs, like Chrome Omnibox focus on a new blank tab is requested explicitly by the resource strip and claimed once that exact tab is on screen, so blank agent tabs never take the caret Omnibox Escape backs out one step at a time (highlight, then edited text, then blur); omnibox and find bar ignore keys during IME composition Error pages only move focus to their heading when the failed page held focus, never away from a field the user is typing in Type of Change Bug fix Testing New apps/desktop/e2e/browser-focus.spec.ts (Playwright _electron, writes a JSON check report to DESKTOP_BROWSER_FOCUS_REPORT_PATH): composer keeps the caret across agent open/navigate/open-tab and a target=_blank popup; omnibox navigation focuses the page; reload keys reload only the page; the page keeps its claim after chrome blur; Back/Forward move tab history; New Tab works from renderer chrome. Fails on staging at the first check, passes on this branch (3/3 repeats) Real-Electron probe of the same behaviors: staging 4/13, this branch 13/13; reverting the hidden-tab focus handback turns the popup check red Existing browser-tools e2e: no new failures vs staging (the viewport-screenshot test is flaky on both) vitest desktop (875) and sim browser/resource suites (200), type-check both apps, bun run lint, check-block-registry, bun run check:audits, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromi...
X Description: Summary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromi...
Opengraph URL: https://github.com/simstudioai/sim/pull/8429
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:41f70b33-c1ed-c975-6932-d121e28fec59 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D9F2:2F3575:8D317B:C983F0:6AFB5164 |
| html-safe-nonce | 084e9dfc85c15d3aa29e32b0e0c0eb921ab5a34b4fe51fc00446b39b39852dff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUYyOjJGMzU3NTo4RDMxN0I6Qzk4M0YwOjZBRkI1MTY0IiwidmlzaXRvcl9pZCI6IjQxMTMxNTYxNjk2MDQ0ODU0NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 693690a375ef57a2c1542cd9729a5efe090e51824c5920a3566078905ebff435 |
| hovercard-subject-tag | pull_request:4682028832 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8429/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromi... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width