René's URL Explorer Experiment


Title: fix(desktop-browser): keep the chat caret while the agent works and route reload/back to the browser tab by waleedlatif1 · Pull Request #8429 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop-browser): keep the chat caret while the agent works and route reload/back to the browser tab by waleedlatif1 · Pull Request #8429 · simstudioai/sim

X Title: fix(desktop-browser): keep the chat caret while the agent works and route reload/back to the browser tab by waleedlatif1 · Pull Request #8429 · simstudioai/sim

Description: Summary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromium focuses anyway (a target=_blank link opened without an opener) hands focus back to Sim Focus moves into a page only on explicit user actions: omnibox Enter, opening a URL in a new tab, and foreground links the user opens; a page not yet on screen takes focus when it is first shown Cmd/Ctrl+R, Cmd/Ctrl+Shift+R, F5, Shift/Ctrl+F5 typed in a page reload that page from its own keystroke instead of relying on the app menu's focus guess (which could reload all of Sim); F5 is now bound in the menu too Clicking from browser chrome into the page no longer wipes the page's shortcut claim (setPanelFocused(false) keeps a claim the native page still holds) Browser shortcuts (Cmd+T, reload, zoom, tab switching) work while a renderer-drawn New Tab or error page hides the native view Back (Cmd+[) and new Forward (Cmd+]) move through the focused tab's history instead of navigating the Sim window Cmd/middle-click and "Open Link in New Tab" open background tabs, like Chrome Omnibox focus on a new blank tab is requested explicitly by the resource strip and claimed once that exact tab is on screen, so blank agent tabs never take the caret Omnibox Escape backs out one step at a time (highlight, then edited text, then blur); omnibox and find bar ignore keys during IME composition Error pages only move focus to their heading when the failed page held focus, never away from a field the user is typing in Type of Change Bug fix Testing New apps/desktop/e2e/browser-focus.spec.ts (Playwright _electron, writes a JSON check report to DESKTOP_BROWSER_FOCUS_REPORT_PATH): composer keeps the caret across agent open/navigate/open-tab and a target=_blank popup; omnibox navigation focuses the page; reload keys reload only the page; the page keeps its claim after chrome blur; Back/Forward move tab history; New Tab works from renderer chrome. Fails on staging at the first check, passes on this branch (3/3 repeats) Real-Electron probe of the same behaviors: staging 4/13, this branch 13/13; reverting the hidden-tab focus handback turns the popup check red Existing browser-tools e2e: no new failures vs staging (the viewport-screenshot test is flaky on both) vitest desktop (875) and sim browser/resource suites (200), type-check both apps, bun run lint, check-block-registry, bun run check:audits, docs-manifest:check Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromi...

X Description: Summary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromi...

Opengraph URL: https://github.com/simstudioai/sim/pull/8429

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:41f70b33-c1ed-c975-6932-d121e28fec59
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9F2:2F3575:8D317B:C983F0:6AFB5164
html-safe-nonce084e9dfc85c15d3aa29e32b0e0c0eb921ab5a34b4fe51fc00446b39b39852dff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUYyOjJGMzU3NTo4RDMxN0I6Qzk4M0YwOjZBRkI1MTY0IiwidmlzaXRvcl9pZCI6IjQxMTMxNTYxNjk2MDQ0ODU0NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac693690a375ef57a2c1542cd9729a5efe090e51824c5920a3566078905ebff435
hovercard-subject-tagpull_request:4682028832
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8429/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Agent work no longer steals the keyboard from the chat composer: tab views set focusOnNavigation: false (fresh views and page-opened popups), and a hidden or not-yet-listed tab that Chromi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8429/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8429%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8429%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8429/files
Reloadhttps://github.com/simstudioai/sim/pull/8429/files
Reloadhttps://github.com/simstudioai/sim/pull/8429/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/browser-focus-reloadhttps://github.com/simstudioai/sim/tree/fix/browser-focus-reload
Conversation 18 https://github.com/simstudioai/sim/pull/8429
Commits 2 https://github.com/simstudioai/sim/pull/8429/commits
Checks 34 https://github.com/simstudioai/sim/pull/8429/checks
Files changed https://github.com/simstudioai/sim/pull/8429/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8429/files
fix(desktop-browser): keep the chat caret while the agent works and route reload/back to the browser tab https://github.com/simstudioai/sim/pull/8429/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8429/files
75fcb2c fix(desktop-browser): keep the chat caret while the agent works and r… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8429/commits/75fcb2cefbd5aeab10833678505fa119e40ece3e
cfed4d0 fix(desktop-browser): return popup focus to the user's page and wait … waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8429/commits/cfed4d04ec1624ea85e3568cc0afaef7fd64583a
Clear filters https://github.com/simstudioai/sim/pull/8429/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8429/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8429/files
browser-focus.spec.ts https://github.com/simstudioai/sim/pull/8429/files#diff-c8be8618266d7d2c002056094aa37a9538d878b06030eb4e0daa4f14d785b62a
driver.ts https://github.com/simstudioai/sim/pull/8429/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
panel.ts https://github.com/simstudioai/sim/pull/8429/files#diff-c959d74a972aa56a35d36cec6d3dba6e7c1a64007fc68214ae9a36531ef3240a
session.ts https://github.com/simstudioai/sim/pull/8429/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
ipc.ts https://github.com/simstudioai/sim/pull/8429/files#diff-a471b27e653d39114f9a737b0741f68dc1a6f36f3830e9454fd4e00704e24727
menu.ts https://github.com/simstudioai/sim/pull/8429/files#diff-2c64f41ba6f6988f5c9092c476164eae8474fb44e233ab29e3aa97ed1ccab68d
resource-shortcuts.ts https://github.com/simstudioai/sim/pull/8429/files#diff-0dfa07f95381cec3af26b7e788b003c4bf96702713d47237ecc23e6dede429f9
index.ts https://github.com/simstudioai/sim/pull/8429/files#diff-74076d8d25116ad5bb8b4f51915e92169cac28f67682613e6b181a2c845e1412
electron-mock.ts https://github.com/simstudioai/sim/pull/8429/files#diff-27ebaddd30812fedc9725b0b888a6d27edc61735a2c872050a6235ccd741dc1f
browser-find-bar.tsx https://github.com/simstudioai/sim/pull/8429/files#diff-4c0255113fb4a0878e43dba9b88a7ca1bafa899f4225b6a9f8375fb00d2e772f
browser-page-issue.tsx https://github.com/simstudioai/sim/pull/8429/files#diff-1ae48a920c810b139166e7f510a2b6a4aa9bf59d8d5efc697976cfd109ce8644
browser-session.tsx https://github.com/simstudioai/sim/pull/8429/files#diff-dc77efde736e424d320cd580e8aa6877a1618db528f899e81f2331a6daf162a2
resource-tabs.tsx https://github.com/simstudioai/sim/pull/8429/files#diff-3100bbc514f6d0cde18752fc6c6fc7a201c93cee56d5ac3733f477f04144cfbc
omnibox-focus.ts https://github.com/simstudioai/sim/pull/8429/files#diff-4afdce18cb5579c0e1ee3cc94f20633e64f3729995c7ff86c4b170bb1ee5c1cb
apps/desktop/e2e/browser-focus.spec.tshttps://github.com/simstudioai/sim/pull/8429/files#diff-c8be8618266d7d2c002056094aa37a9538d878b06030eb4e0daa4f14d785b62a
View file https://github.com/simstudioai/sim/blob/cfed4d04ec1624ea85e3568cc0afaef7fd64583a/apps/desktop/e2e/browser-focus.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8429/{{ revealButtonHref }}
apps/desktop/src/main/browser-agent/driver.tshttps://github.com/simstudioai/sim/pull/8429/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
View file https://github.com/simstudioai/sim/blob/cfed4d04ec1624ea85e3568cc0afaef7fd64583a/apps/desktop/src/main/browser-agent/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8429/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8429/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
https://github.com/simstudioai/sim/pull/8429/files#diff-515694ac7beaa3b13cb8b2224e3c5ec946ddc589bf9d8c294986e76a8c270ed6
apps/desktop/src/main/browser-agent/panel.tshttps://github.com/simstudioai/sim/pull/8429/files#diff-c959d74a972aa56a35d36cec6d3dba6e7c1a64007fc68214ae9a36531ef3240a
View file https://github.com/simstudioai/sim/blob/cfed4d04ec1624ea85e3568cc0afaef7fd64583a/apps/desktop/src/main/browser-agent/panel.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8429/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8429/files#diff-c959d74a972aa56a35d36cec6d3dba6e7c1a64007fc68214ae9a36531ef3240a
https://github.com/simstudioai/sim/pull/8429/files#diff-c959d74a972aa56a35d36cec6d3dba6e7c1a64007fc68214ae9a36531ef3240a
https://github.com/simstudioai/sim/pull/8429/files#diff-c959d74a972aa56a35d36cec6d3dba6e7c1a64007fc68214ae9a36531ef3240a
https://github.com/simstudioai/sim/pull/8429/files#diff-c959d74a972aa56a35d36cec6d3dba6e7c1a64007fc68214ae9a36531ef3240a
Please reload this pagehttps://github.com/simstudioai/sim/pull/8429/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8429/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.