René's URL Explorer Experiment


Title: fix(tables): settle a resume whose pause cannot be saved as failed, and never fail a completed run by waleedlatif1 · Pull Request #8417 · simstudioai/sim · GitHub

Open Graph Title: fix(tables): settle a resume whose pause cannot be saved as failed, and never fail a completed run by waleedlatif1 · Pull Request #8417 · simstudioai/sim

X Title: fix(tables): settle a resume whose pause cannot be saved as failed, and never fail a completed run by waleedlatif1 · Pull Request #8417 · simstudioai/sim

Description: Summary Two gaps in how a failed resume attempt settles, raised on the v0.9.6 release PR (#8410). A pause that can't be saved now fails the attempt. When a resumed run paused but its pause state couldn't be persisted (the snapshot seed was missing, or persistPauseResult threw), the log was failed but the paused result was still returned. So the table cell showed paused and the resume entry was marked completed. It now fails the log with the same reason, then throws, so the attempt settles through the shared failure path: slot released, resume entry and pause point failed, execution_failed reported to onAttemptFailed, and queued resumes drained. Every caller of startResumeExecution already handles a throw. A completed run is never rewritten as failed. markResumeFailed only skipped cancelled logs. If a step after a completed run threw (for example markResumeCompleted or processQueuedResumes), the log was rewritten from completed to failed, and the cell was set to error. A completed log now keeps its outcome. markResumeFailed reports what the attempt left the execution as, and a new execution_completed outcome settles the cell as completed, which is what the success path would have written. Without that outcome, the cell would stay on its last running progress state. The pause point and resume entry are still marked failed, as before. An already failed log still reports execution_failed but keeps its original end time. runResumeExecution awaits the log's finalization before returning or throwing, so the status read here reflects this attempt's run. Type of Change Bug fix Testing markResumeFailed: a completed log reports execution_completed without rewriting the log; a failed log reports execution_failed without rewriting it; a running log is failed as before; cancelled and cancelling report nothing. The task settles the cell as completed for execution_completed. startResumeExecution: a failed pause persistence and a missing snapshot seed both reject and report execution_failed. Each new test fails on the previous code. Type-check, lint, all audits, and the full apps/sim suite pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Two gaps in how a failed resume attempt settles, raised on the v0.9.6 release PR (#8410). A pause that can't be saved now fails the attempt. When a resumed run paused but its pause sta...

X Description: Summary Two gaps in how a failed resume attempt settles, raised on the v0.9.6 release PR (#8410). A pause that can't be saved now fails the attempt. When a resumed run paused but its pause...

Opengraph URL: https://github.com/simstudioai/sim/pull/8417

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:05f5a52a-95f9-df41-0e6d-0281b1418f79
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEB0:FBC06:14A552C:1C53AF6:6AFB7A00
html-safe-nonceef9b76cae996ab3d9ed65fb33504e3affd82201147c41a53ec5496a77b098026
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUIwOkZCQzA2OjE0QTU1MkM6MUM1M0FGNjo2QUZCN0EwMCIsInZpc2l0b3JfaWQiOiI0NDU3NjM4MjMwNjQ4MTI1OTUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc0f5a424d7567dc9d9f3772057eca956380f33d4c76c302f304b197a4a3af41c
hovercard-subject-tagpull_request:4679921891
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8417/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Two gaps in how a failed resume attempt settles, raised on the v0.9.6 release PR (#8410). A pause that can't be saved now fails the attempt. When a resumed run paused but its pause sta...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2e8872b770cc4d5d0cc1f2026afab747a268e2ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8417/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8417%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8417%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8417/files
Reloadhttps://github.com/simstudioai/sim/pull/8417/files
Reloadhttps://github.com/simstudioai/sim/pull/8417/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/resume-failure-outcome-gapshttps://github.com/simstudioai/sim/tree/fix/resume-failure-outcome-gaps
Conversation 30 https://github.com/simstudioai/sim/pull/8417
Commits 6 https://github.com/simstudioai/sim/pull/8417/commits
Checks 31 https://github.com/simstudioai/sim/pull/8417/checks
Files changed https://github.com/simstudioai/sim/pull/8417/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8417/files
fix(tables): settle a resume whose pause cannot be saved as failed, and never fail a completed run https://github.com/simstudioai/sim/pull/8417/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/8417/files
b6501d0 fix(tables): settle a resume whose pause cannot be saved as failed, a… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8417/commits/b6501d0e05a009edd025e7e47232456b0e6d325d
6be9ba0 fix(tables): settle the cell as completed when a completed resume's l… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8417/commits/6be9ba0261ef7230f952fb1c831c5ff761f0d10c
ccce75f fix(tables): continue the cascade after a completed resume whose late… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8417/commits/ccce75f87cce5ee4ecd25eac57930f1a7f662718
3e15700 fix(tables): keep server-side logging for a resumed pause that cannot… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8417/commits/3e15700c0a45910507b7b542653ea96d86a47859
70755c3 fix(tables): continue the cascade only once the completed cell is saved waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8417/commits/70755c385e551e8272331a5a344672918a7b24d4
4fef9c4 test(tables): assert which downstream groups a resume's cascade started waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8417/commits/4fef9c4eb769e4b622e8cd3285a9fb29edafe4e5
Clear filters https://github.com/simstudioai/sim/pull/8417/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8417/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8417/files
resume-execution.ts https://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
resume-governed-subject.test.ts https://github.com/simstudioai/sim/pull/8417/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
human-in-the-loop-manager.test.ts https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
human-in-the-loop-manager.ts https://github.com/simstudioai/sim/pull/8417/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
apps/sim/background/resume-execution.tshttps://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
View file https://github.com/simstudioai/sim/blob/4fef9c4eb769e4b622e8cd3285a9fb29edafe4e5/apps/sim/background/resume-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8417/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
Please reload this pagehttps://github.com/simstudioai/sim/pull/8417/files
https://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8417/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
apps/sim/background/resume-governed-subject.test.tshttps://github.com/simstudioai/sim/pull/8417/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
View file https://github.com/simstudioai/sim/blob/4fef9c4eb769e4b622e8cd3285a9fb29edafe4e5/apps/sim/background/resume-governed-subject.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8417/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8417/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
https://github.com/simstudioai/sim/pull/8417/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
https://github.com/simstudioai/sim/pull/8417/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
apps/sim/lib/workflows/executor/human-in-the-loop-manager.test.tshttps://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
View file https://github.com/simstudioai/sim/blob/4fef9c4eb769e4b622e8cd3285a9fb29edafe4e5/apps/sim/lib/workflows/executor/human-in-the-loop-manager.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8417/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8417/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
Please reload this pagehttps://github.com/simstudioai/sim/pull/8417/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8417/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.