René's URL Explorer Experiment


Title: fix(logs): keep compacted child span trees shaped as trees by waleedlatif1 · Pull Request #8403 · simstudioai/sim · GitHub

Open Graph Title: fix(logs): keep compacted child span trees shaped as trees by waleedlatif1 · Pull Request #8403 · simstudioai/sim

X Title: fix(logs): keep compacted child span trees shaped as trees by waleedlatif1 · Pull Request #8403 · simstudioai/sim

Description: Summary Block output compaction ran the generic payload compactor over childTraceSpans. Compaction works bottom-up, so when a nested span's children list grew past the threshold it became a large-array manifest or large-value reference instead of an array. Trace span building later spread that value (flattenWorkflowChildren) and threw TypeError: directChildren is not iterable. Span building ran outside the finalization try, so the pause was never persisted, the run was never finalized or billed, and the log stayed running until it was swept. Any later resume was then refused. Other readers that walk raw span trees (children.map, for…of) have the same exposure. Serializer: a child span tree is kept whole or not at all. compactBlockOutput splits childTraceSpans off the block output: The output compacts for execution state exactly as before, so an oversized output still spills whole. The spans compact structurally: children and nested output.childTraceSpans stay arrays, and each span's payload fields spill individually, with a cycle guard. A tree still over the threshold as a whole keeps only its skeleton: shape, names, timing, status and cost. This uses summarizeTraceSpansWithoutIo, the same stripping the execution log applies to oversized traces, now shared from trace-spans/summarize.ts. A tree whose skeleton is still over the threshold is dropped with a warning; when large values are rejected, an oversized tree is rejected instead. This bounds the tree as generic compaction did, including in pause snapshots. The executor puts the spans only on the block log; they were always stripped from state. compactBlockLogs applies the same rule to log.childTraceSpans. Span factory: a child span list that is not an array (for example one persisted by an earlier build) is dropped with a warning instead of throwing. Execution core: trace spans are built inside a guarded helper. If building fails, the run is finalized with no spans and the error is logged, so logs, pauses, billing and run counts still settle. Testing Serializer: a tree with oversized payloads stays whole with each payload spilled; a tree too large as a whole keeps its skeleton, and is dropped only when the skeleton is still too large, or rejected when large values are rejected; an oversized state output still spills whole; block logs follow the same rule; nested child workflow trees keep their shape; a cyclic tree terminates. Trace spans: reference-shaped children and output.childTraceSpans no longer throw. Execution core: pause and failed-run finalization when span building throws. Each guard was reverted individually and its test went red. bun run type-check, bun run lint, bun run check:audits, and the full apps/sim suite pass.

Open Graph Description: Summary Block output compaction ran the generic payload compactor over childTraceSpans. Compaction works bottom-up, so when a nested span's children list grew past the threshold it became a lar...

X Description: Summary Block output compaction ran the generic payload compactor over childTraceSpans. Compaction works bottom-up, so when a nested span's children list grew past the threshold it became a...

Opengraph URL: https://github.com/simstudioai/sim/pull/8403

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a584a4d8-9755-8c05-e1ab-dec761199365
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE08A:1BD5CA:DF8C07:13269C4:6AFB5C76
html-safe-noncec7df5ab050cee389ae835480750795a735b6004a3fa7582d8551b2a3d73725df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDhBOjFCRDVDQTpERjhDMDc6MTMyNjlDNDo2QUZCNUM3NiIsInZpc2l0b3JfaWQiOiI2MDUwNTM0MjY5NTAxNzkxMzUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd69527fccd319ef013f26d397199b76cc1b797fe1e98943ee70d7eaa887c8104
hovercard-subject-tagpull_request:4672358405
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8403/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Block output compaction ran the generic payload compactor over childTraceSpans. Compaction works bottom-up, so when a nested span's children list grew past the threshold it became a lar...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8403/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8403%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8403%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8403/files
Reloadhttps://github.com/simstudioai/sim/pull/8403/files
Reloadhttps://github.com/simstudioai/sim/pull/8403/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/trace-span-tree-compactionhttps://github.com/simstudioai/sim/tree/fix/trace-span-tree-compaction
Conversation 45 https://github.com/simstudioai/sim/pull/8403
Commits 7 https://github.com/simstudioai/sim/pull/8403/commits
Checks 31 https://github.com/simstudioai/sim/pull/8403/checks
Files changed https://github.com/simstudioai/sim/pull/8403/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8403/files
fix(logs): keep compacted child span trees shaped as trees https://github.com/simstudioai/sim/pull/8403/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/8403/files
8727715 fix(logs): keep compacted child span trees shaped as trees waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8403/commits/87277152bec2745a60d016ae96a06b68647987e7
44a7576 fix(logs): keep an output carrying child spans a record when compacti… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8403/commits/44a75760c9c95d2ce45ca33017afed141b21f3c5
405f9bf fix(logs): split child spans off block output so oversized state stil… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8403/commits/405f9bfb6b80a9f5aea0bfe4643a1153fe3e3774
3f074f6 fix(logs): keep a child span tree whole or drop it, bounded as before waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8403/commits/3f074f62a7a2aef40036d8b8d4831a8203adfc24
5ce7f18 fix(logs): keep the skeleton of a child span tree too large to keep w… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8403/commits/5ce7f18fcbff62c86b8041eb7018f17620ecc590
2e2206d fix(logs): keep span trees well formed and keep nested child workflow… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8403/commits/2e2206dcd11a3a4cf5b2b2325fd266251d54287b
c921292 fix(logs): skip span fields not in their expected shape when summarizing waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8403/commits/c92129269cb0253bcf1ae58b6218faf38ed8fb41
Clear filters https://github.com/simstudioai/sim/pull/8403/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8403/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8403/files
block-executor.ts https://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
serializer.test.ts https://github.com/simstudioai/sim/pull/8403/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
serializer.ts https://github.com/simstudioai/sim/pull/8403/files#diff-92aeb7f71ba70de0594c007e2dc7981e60a1f85ebd9881288f5814996729017a
logger.ts https://github.com/simstudioai/sim/pull/8403/files#diff-c93eef5145bbe011ec0c231c435952a4a5d8f1826332935030595b98b5980ee6
span-factory.ts https://github.com/simstudioai/sim/pull/8403/files#diff-03c02936524f11bcd92fd7afe26db78c1696a51948ec26c2ec4a346be152a478
summarize.ts https://github.com/simstudioai/sim/pull/8403/files#diff-44b285e8c0fa26da0ca47e72bdcef6de4bd29a439e2d1120260432b42232d4ac
trace-spans.test.ts https://github.com/simstudioai/sim/pull/8403/files#diff-9c690eb9cb9d5929d46a235a4008f96bdf80f81234df69922bd1443114126801
execution-core.test.ts https://github.com/simstudioai/sim/pull/8403/files#diff-40c3467de29e00eaa8563d025139feccb3d119364e628433260c1b6c70d89704
execution-core.ts https://github.com/simstudioai/sim/pull/8403/files#diff-2a32d546272efa06e3cbe2ccce1cf4e69c74ff37fe98253bcb2742ffed5bae4b
apps/sim/executor/execution/block-executor.tshttps://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
View file https://github.com/simstudioai/sim/blob/c92129269cb0253bcf1ae58b6218faf38ed8fb41/apps/sim/executor/execution/block-executor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8403/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
https://github.com/simstudioai/sim/pull/8403/files#diff-56a5432011895e99101ab4af087446b215bca1a2b216e3c44a5087a11223000d
apps/sim/lib/execution/payloads/serializer.test.tshttps://github.com/simstudioai/sim/pull/8403/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
View file https://github.com/simstudioai/sim/blob/c92129269cb0253bcf1ae58b6218faf38ed8fb41/apps/sim/lib/execution/payloads/serializer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8403/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8403/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
https://github.com/simstudioai/sim/pull/8403/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
https://github.com/simstudioai/sim/pull/8403/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
https://github.com/simstudioai/sim/pull/8403/files#diff-0ab1905985e39fe5d0ff70441c14bf8c0c04327a8f3785f02e965d77c361d57c
Please reload this pagehttps://github.com/simstudioai/sim/pull/8403/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8403/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.