René's URL Explorer Experiment


Title: fix(tables): write the cell state when a resumed run throws by waleedlatif1 · Pull Request #8401 · simstudioai/sim · GitHub

Open Graph Title: fix(tables): write the cell state when a resumed run throws by waleedlatif1 · Pull Request #8401 · simstudioai/sim

X Title: fix(tables): write the cell state when a resumed run throws by waleedlatif1 · Pull Request #8401 · simstudioai/sim

Description: Summary runResumeAndCellTerminal wrote the cell terminal only after a resume returned. A resume that threw left the table cell on its last partial running state — stuck, and not cancellable (the cancel path sees a failed log with a running sidecar and returns conflict) The resume manager now records, on the error it rethrows, whether the attempt kept its pause resumable (wasPausedExecutionRetained): true for an admission refusal or an unavailable run buffer, which go through markResumeAttemptFailed; false for every other failure, which markResumeFailed makes terminal The resume job mirrors that onto the cell: back to paused when the pause was kept, error with the message otherwise — the same shape workflow-column-execution writes when a first run throws. A cancelled cell is protected by the existing cancellation guard in writeWorkflowGroupState A failed cell write is logged without masking the resume error; the original error is still rethrown, so job behavior is unchanged Type of Change Bug fix Testing Manager: an unclaimable paused log (real ResumeAdmissionError) keeps the pause resumable; a failed run does not. Removing the new record from the admission branch turns its test red Resume job, table-cell path: a failed run writes error; a kept pause writes paused; a failing cell write still rethrows the original error (red with the write guard removed) Type-check, lint, all audits, and the background, table, workflow, resume and v2 workflow suites pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary runResumeAndCellTerminal wrote the cell terminal only after a resume returned. A resume that threw left the table cell on its last partial running state — stuck, and not cancellable (the c...

X Description: Summary runResumeAndCellTerminal wrote the cell terminal only after a resume returned. A resume that threw left the table cell on its last partial running state — stuck, and not cancellable (the c...

Opengraph URL: https://github.com/simstudioai/sim/pull/8401

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:68104d65-fc0d-3220-81ff-9e00332ec3af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE40:1C88A1:C6F700:11912F1:6AFB5C90
html-safe-nonce3b0af5a2c78d5986ce9c9795aa9d7a8cb192ed9069fb7a9bdfc5bd4a2c475207
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTQwOjFDODhBMTpDNkY3MDA6MTE5MTJGMTo2QUZCNUM5MCIsInZpc2l0b3JfaWQiOiIzODgyMjA3MzIxMzA3OTYyNTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8359471a2314ee0f6a1cc9bcf5dc1e95a08d8e7182b3848882e0fff80f78f7e0
hovercard-subject-tagpull_request:4671935491
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8401/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary runResumeAndCellTerminal wrote the cell terminal only after a resume returned. A resume that threw left the table cell on its last partial running state — stuck, and not cancellable (the c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8401/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8401%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8401%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8401/files
Reloadhttps://github.com/simstudioai/sim/pull/8401/files
Reloadhttps://github.com/simstudioai/sim/pull/8401/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/resume-cell-terminal-on-throwhttps://github.com/simstudioai/sim/tree/fix/resume-cell-terminal-on-throw
Conversation 19 https://github.com/simstudioai/sim/pull/8401
Commits 4 https://github.com/simstudioai/sim/pull/8401/commits
Checks 31 https://github.com/simstudioai/sim/pull/8401/checks
Files changed https://github.com/simstudioai/sim/pull/8401/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8401/files
fix(tables): write the cell state when a resumed run throws https://github.com/simstudioai/sim/pull/8401/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/8401/files
9eed4a3 fix(tables): write the cell state when a resumed run throws waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8401/commits/9eed4a360e7d476eaa4f5ad86eb919b6e536f00d
e19a8ab fix(tables): mirror what a failed resume did instead of inferring it … waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8401/commits/e19a8ab8387eddf5d7a0739e43e3598239d875d3
d362cc2 fix(tables): type the terminal execution log statuses against the per… waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8401/commits/d362cc24b035feb6128edcb2eb8faa0be375d343
8c419ed fix(tables): report a failed resume's outcome through a hook instead … waleedlatif1 Sep 29, 2026 https://github.com/simstudioai/sim/pull/8401/commits/8c419ed6069de76729131320cf0008a74132a2b6
Clear filters https://github.com/simstudioai/sim/pull/8401/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8401/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8401/files
resume-execution.ts https://github.com/simstudioai/sim/pull/8401/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
resume-governed-subject.test.ts https://github.com/simstudioai/sim/pull/8401/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
human-in-the-loop-manager.test.ts https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
human-in-the-loop-manager.ts https://github.com/simstudioai/sim/pull/8401/files#diff-bb1129b15dc9783d16371ddc2f8992d36e41c60787a458e77e1c59a7e721d292
apps/sim/background/resume-execution.tshttps://github.com/simstudioai/sim/pull/8401/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
View file https://github.com/simstudioai/sim/blob/8c419ed6069de76729131320cf0008a74132a2b6/apps/sim/background/resume-execution.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8401/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8401/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8401/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8401/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8401/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
https://github.com/simstudioai/sim/pull/8401/files#diff-16ae42b061a34f194edac1f14848b4f357d4df95cf8e7fef2219a992da1c6e7f
apps/sim/background/resume-governed-subject.test.tshttps://github.com/simstudioai/sim/pull/8401/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
View file https://github.com/simstudioai/sim/blob/8c419ed6069de76729131320cf0008a74132a2b6/apps/sim/background/resume-governed-subject.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8401/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8401/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
https://github.com/simstudioai/sim/pull/8401/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
https://github.com/simstudioai/sim/pull/8401/files#diff-2188baa67fac4978e58a033197f950a2d661875ae7daffb42511e5f7a2da2ad8
apps/sim/lib/workflows/executor/human-in-the-loop-manager.test.tshttps://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
View file https://github.com/simstudioai/sim/blob/8c419ed6069de76729131320cf0008a74132a2b6/apps/sim/lib/workflows/executor/human-in-the-loop-manager.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8401/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
https://github.com/simstudioai/sim/pull/8401/files#diff-72580e5e18315802c8260c3c01abd48ff8de248edd72c9890764c158e0e52478
Please reload this pagehttps://github.com/simstudioai/sim/pull/8401/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8401/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.