René's URL Explorer Experiment


Title: fix(knowledge): serve list totals when a request omits the count flag by waleedlatif1 · Pull Request #8367 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): serve list totals when a request omits the count flag by waleedlatif1 · Pull Request #8367 · simstudioai/sim

X Title: fix(knowledge): serve list totals when a request omits the count flag by waleedlatif1 · Pull Request #8367 · simstudioai/sim

Description: Summary #8329 added includeCounts to the internal GET /api/knowledge list, defaulting to false, and made tokenCount optional in the response. A page loaded before that deploy sends no flag, and its contract still requires tokenCount on every row, so every knowledge base list in an open tab (the Knowledge page, KB selector, search modal, mentions, resource tabs) fails contract validation until the tab reloads A missing flag now means counted. Current clients always send it: fetchKnowledgeBases passes an explicit boolean, and appendQuery serializes false. So only a pre-flag page gets the totals it requires, and the counts still go through the reader's access The Copilot mention picker omitted the flag and only reads id and name, so it now sends includeCounts: false No other response shape in the release became optional or dropped a field. I diffed every contract between main and staging Type of Change Bug fix Testing Parsing the list query: no flag → counted, false → uncounted, true → counted Lint, all 51 audits, type-check, and the knowledge query/application/page suites (594 tests) pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary #8329 added includeCounts to the internal GET /api/knowledge list, defaulting to false, and made tokenCount optional in the response. A page loaded before that deploy sends no flag, and it...

X Description: Summary #8329 added includeCounts to the internal GET /api/knowledge list, defaulting to false, and made tokenCount optional in the response. A page loaded before that deploy sends no flag, and it...

Opengraph URL: https://github.com/simstudioai/sim/pull/8367

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0ab5f03e-d199-33a7-c277-5456611326c3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4B4:21EB6D:B08E11:F9F447:6AFB5997
html-safe-nonced3ad6d7c0859c72fd28cde6bbedf009aef37bcda82a3e8baee53e3c491a9336c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEI0OjIxRUI2RDpCMDhFMTE6RjlGNDQ3OjZBRkI1OTk3IiwidmlzaXRvcl9pZCI6IjUzNzQ0MDM1NTI2NDQ2NTE0MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac55e7c083295413510c38e1e11d0190f6c3e52f9b2bc2516ea1f5348749030569
hovercard-subject-tagpull_request:4658819760
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8367/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary #8329 added includeCounts to the internal GET /api/knowledge list, defaulting to false, and made tokenCount optional in the response. A page loaded before that deploy sends no flag, and it...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8367/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8367%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8367%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8367/files
Reloadhttps://github.com/simstudioai/sim/pull/8367/files
Reloadhttps://github.com/simstudioai/sim/pull/8367/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/knowledge-list-counts-legacy-defaulthttps://github.com/simstudioai/sim/tree/fix/knowledge-list-counts-legacy-default
Conversation 8 https://github.com/simstudioai/sim/pull/8367
Commits 2 https://github.com/simstudioai/sim/pull/8367/commits
Checks 31 https://github.com/simstudioai/sim/pull/8367/checks
Files changed https://github.com/simstudioai/sim/pull/8367/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8367/files
fix(knowledge): serve list totals when a request omits the count flag https://github.com/simstudioai/sim/pull/8367/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8367/files
8b41371 fix(knowledge): serve list totals when a request omits the count flag waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8367/commits/8b41371c836c08fa375f92075adf6f28bd60e797
fe9ab3a test(knowledge): cover the internal list request a pre-flag page sends waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8367/commits/fe9ab3a86e6dcad98fd2648faf3bc48baa90070f
Clear filters https://github.com/simstudioai/sim/pull/8367/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8367/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8367/files
route.integration.ts https://github.com/simstudioai/sim/pull/8367/files#diff-453b5cb7e3673134c35f8f57a2df21a81f824afe5eb824d5c465bf0b3e3408c9
use-mention-data.ts https://github.com/simstudioai/sim/pull/8367/files#diff-e63599ddcdeab8360c011b7620ee1d8d82d6531187d0ab6141e0244e88d59f98
base.ts https://github.com/simstudioai/sim/pull/8367/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
apps/sim/app/api/v1/knowledge/route.integration.tshttps://github.com/simstudioai/sim/pull/8367/files#diff-453b5cb7e3673134c35f8f57a2df21a81f824afe5eb824d5c465bf0b3e3408c9
View file https://github.com/simstudioai/sim/blob/fe9ab3a86e6dcad98fd2648faf3bc48baa90070f/apps/sim/app/api/v1/knowledge/route.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8367/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8367/files#diff-453b5cb7e3673134c35f8f57a2df21a81f824afe5eb824d5c465bf0b3e3408c9
https://github.com/simstudioai/sim/pull/8367/files#diff-453b5cb7e3673134c35f8f57a2df21a81f824afe5eb824d5c465bf0b3e3408c9
https://github.com/simstudioai/sim/pull/8367/files#diff-453b5cb7e3673134c35f8f57a2df21a81f824afe5eb824d5c465bf0b3e3408c9
https://github.com/simstudioai/sim/pull/8367/files#diff-453b5cb7e3673134c35f8f57a2df21a81f824afe5eb824d5c465bf0b3e3408c9
...owId]/components/panel/components/copilot/components/user-input/hooks/use-mention-data.tshttps://github.com/simstudioai/sim/pull/8367/files#diff-e63599ddcdeab8360c011b7620ee1d8d82d6531187d0ab6141e0244e88d59f98
View file https://github.com/simstudioai/sim/blob/fe9ab3a86e6dcad98fd2648faf3bc48baa90070f/apps/sim/app/workspace/%5BworkspaceId%5D/w/%5BworkflowId%5D/components/panel/components/copilot/components/user-input/hooks/use-mention-data.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8367/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8367/files#diff-e63599ddcdeab8360c011b7620ee1d8d82d6531187d0ab6141e0244e88d59f98
https://github.com/simstudioai/sim/pull/8367/files#diff-e63599ddcdeab8360c011b7620ee1d8d82d6531187d0ab6141e0244e88d59f98
apps/sim/lib/api/contracts/knowledge/base.tshttps://github.com/simstudioai/sim/pull/8367/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
View file https://github.com/simstudioai/sim/blob/fe9ab3a86e6dcad98fd2648faf3bc48baa90070f/apps/sim/lib/api/contracts/knowledge/base.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8367/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8367/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
Please reload this pagehttps://github.com/simstudioai/sim/pull/8367/files
https://github.com/simstudioai/sim/pull/8367/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
Please reload this pagehttps://github.com/simstudioai/sim/pull/8367/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.