René's URL Explorer Experiment


Title: fix(search): validate a new provider server before the approval transaction by waleedlatif1 · Pull Request #8366 · simstudioai/sim · GitHub

Open Graph Title: fix(search): validate a new provider server before the approval transaction by waleedlatif1 · Pull Request #8366 · simstudioai/sim

X Title: fix(search): validate a new provider server before the approval transaction by waleedlatif1 · Pull Request #8366 · simstudioai/sim

Description: Summary Approving a search provider took the connected-accounts advisory lock inside its transaction and then ran the provider server's DNS/SSRF validation while still holding it. A slow resolver held the lock and a pooled connection for the full lookup prepareSearchMcpProvider now runs before the transaction. It skips DNS when the organization already has the server (same as before) and validates the URL up front for a new one. createManagedMcpConnector accepts the pre-validated input, so nothing resolves under the lock If the server is removed between preparation and the transaction, the approval returns a conflict ("try again") instead of creating it unvalidated Error mapping is unchanged (toSetupError dedupes it). The organization-accounts and workspace callers still validate inside their own flow Responds to a review thread on #8356 Type of Change Bug fix Testing New integration test: a separate connection can take the accounts lock during the DNS lookup, so the lookup runs outside the lock. The test fails on the pre-fix code An existing provider still approves with DNS unavailable Type-check and the credential-group unit suites pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Approving a search provider took the connected-accounts advisory lock inside its transaction and then ran the provider server's DNS/SSRF validation while still holding it. A slow resol...

X Description: Summary Approving a search provider took the connected-accounts advisory lock inside its transaction and then ran the provider server's DNS/SSRF validation while still holding it. A slow r...

Opengraph URL: https://github.com/simstudioai/sim/pull/8366

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2c9047c5-5953-ea59-ec62-50c9efae411f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD934:34FC0A:D16BAE:11E2A66:6AFB5A47
html-safe-nonceadc90425311580026040ee96cfd5c243bdd5b1b8be2ab53e7c32cd0b0a1d3f3c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTM0OjM0RkMwQTpEMTZCQUU6MTFFMkE2Njo2QUZCNUE0NyIsInZpc2l0b3JfaWQiOiI3ODU3NjMxNDA4NDIyNjA3NDMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdeb7a14d6e10048a2a8712b96ec0d45fc859cdeef2887639c992656e30ee240b
hovercard-subject-tagpull_request:4658294832
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8366/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Approving a search provider took the connected-accounts advisory lock inside its transaction and then ran the provider server's DNS/SSRF validation while still holding it. A slow resol...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8366/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8366%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8366%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8366/files
Reloadhttps://github.com/simstudioai/sim/pull/8366/files
Reloadhttps://github.com/simstudioai/sim/pull/8366/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/search-provider-validate-before-txhttps://github.com/simstudioai/sim/tree/fix/search-provider-validate-before-tx
Conversation 11 https://github.com/simstudioai/sim/pull/8366
Commits 3 https://github.com/simstudioai/sim/pull/8366/commits
Checks 31 https://github.com/simstudioai/sim/pull/8366/checks
Files changed https://github.com/simstudioai/sim/pull/8366/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8366/files
fix(search): validate a new provider server before the approval transaction https://github.com/simstudioai/sim/pull/8366/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8366/files
40a3a24 fix(search): validate a new provider server before the approval trans… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8366/commits/40a3a24167ef291096b9d57a328e0c8e041d6e28
354fe10 fix(search): recheck for the provider server after a failed pre-appro… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8366/commits/354fe105f607cb8fc13c18d060a2853714811a28
c83f4be Merge remote-tracking branch 'origin/staging' into fix/search-provide… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8366/commits/c83f4befc2e7ec3ff29fb7c57f0a2b8e1dd20b7e
Clear filters https://github.com/simstudioai/sim/pull/8366/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8366/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8366/files
managed-mcp-service.ts https://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
search-mcp-setup.integration.ts https://github.com/simstudioai/sim/pull/8366/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
search-integrations.ts https://github.com/simstudioai/sim/pull/8366/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
member-setup.ts https://github.com/simstudioai/sim/pull/8366/files#diff-a7f4fdea3c01ed55816125954efce5d777d60adb26808492ef63c2dd6d193a11
apps/sim/lib/credential-groups/managed-mcp-service.tshttps://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
View file https://github.com/simstudioai/sim/blob/c83f4befc2e7ec3ff29fb7c57f0a2b8e1dd20b7e/apps/sim/lib/credential-groups/managed-mcp-service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8366/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
https://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
https://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
https://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
https://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
https://github.com/simstudioai/sim/pull/8366/files#diff-0967622d2f93defa2a4441de77075eb27b1f3b26b6587afbe8e80cb6a67710e3
apps/sim/lib/knowledge/__integration__/search-mcp-setup.integration.tshttps://github.com/simstudioai/sim/pull/8366/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
View file https://github.com/simstudioai/sim/blob/c83f4befc2e7ec3ff29fb7c57f0a2b8e1dd20b7e/apps/sim/lib/knowledge/__integration__/search-mcp-setup.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8366/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8366/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
https://github.com/simstudioai/sim/pull/8366/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
https://github.com/simstudioai/sim/pull/8366/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
https://github.com/simstudioai/sim/pull/8366/files#diff-eff1007aa0e75b3a67e7fdeb40a90b7e0762c21870ee4eada5f1c7ec1234b9cd
apps/sim/lib/knowledge/application/search-integrations.tshttps://github.com/simstudioai/sim/pull/8366/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
View file https://github.com/simstudioai/sim/blob/c83f4befc2e7ec3ff29fb7c57f0a2b8e1dd20b7e/apps/sim/lib/knowledge/application/search-integrations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8366/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8366/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
https://github.com/simstudioai/sim/pull/8366/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
https://github.com/simstudioai/sim/pull/8366/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
https://github.com/simstudioai/sim/pull/8366/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
https://github.com/simstudioai/sim/pull/8366/files#diff-ae488674006ff9ad33c7fa3b3f02fe5a99dfe646b7a6949ca8b6c1c4c84cc551
apps/sim/lib/sim-search/live/member-setup.tshttps://github.com/simstudioai/sim/pull/8366/files#diff-a7f4fdea3c01ed55816125954efce5d777d60adb26808492ef63c2dd6d193a11
View file https://github.com/simstudioai/sim/blob/c83f4befc2e7ec3ff29fb7c57f0a2b8e1dd20b7e/apps/sim/lib/sim-search/live/member-setup.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8366/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8366/files
https://github.com/simstudioai/sim/pull/8366/files#diff-a7f4fdea3c01ed55816125954efce5d777d60adb26808492ef63c2dd6d193a11
https://github.com/simstudioai/sim/pull/8366/files#diff-a7f4fdea3c01ed55816125954efce5d777d60adb26808492ef63c2dd6d193a11
Please reload this pagehttps://github.com/simstudioai/sim/pull/8366/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.