René's URL Explorer Experiment


Title: fix(knowledge): resume the member resurrection walk from a persisted cursor by waleedlatif1 · Pull Request #8365 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): resume the member resurrection walk from a persisted cursor by waleedlatif1 · Pull Request #8365 · simstudioai/sim

X Title: fix(knowledge): resume the member resurrection walk from a persisted cursor by waleedlatif1 · Pull Request #8365 · simstudioai/sim

Description: Summary The member resurrection pass walked a connector's documents from the first id on every run. A walk the deadline cut short never reached the tail, so documents past that point could stay tombstoned indefinitely walkReconciliationWindows now takes startAfterId and returns { finished, lastId }. The resurrection pass resumes from a new nullable column, knowledge_connector.member_resurrection_cursor, and clears it once the tail is covered. The cursor is written once per run, only when it moved, under the member lease It's a separate column rather than a reuse of member_tombstone_cursor, so an app rollback never misreads a resurrection position as a tombstone cursor Purge still waits for a finished walk. Purge candidates have no observation and resurrectable documents do, so the two sets never overlap withoutSecret strips the new column like the tombstone cursor Migration: a single nullable ADD COLUMN with no default and no rewrite. It will be renumbered against #8335 at merge Responds to a review thread on #8356 Type of Change Bug fix Testing New integration test (real Postgres): a deadline-cut first run persists the cursor at the last handled id, the resumed run covers exactly the remaining tail, and it clears the cursor. The test fails on the pre-fix code Type-check, check:migrations, and the schema-mock check pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The member resurrection pass walked a connector's documents from the first id on every run. A walk the deadline cut short never reached the tail, so documents past that point could sta...

X Description: Summary The member resurrection pass walked a connector's documents from the first id on every run. A walk the deadline cut short never reached the tail, so documents past that point could...

Opengraph URL: https://github.com/simstudioai/sim/pull/8365

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:61ab98ae-e2e1-439a-6174-2a0befb18857
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94FC:A5723:89239D:C25693:6AFB4F7A
html-safe-nonce0a7d9a6a8a2d3eadd22c01b8bccbb0619d8ac44ae0d6b80a9fd266a56c8baff9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEZDOkE1NzIzOjg5MjM5RDpDMjU2OTM6NkFGQjRGN0EiLCJ2aXNpdG9yX2lkIjoiNDk0MTA3NjU1MzAwNDAzMDY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac24eb6b07c93fdba6391d3392a2b024118e8777cc38f5da3b65ae562380fef192
hovercard-subject-tagpull_request:4658294428
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8365/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The member resurrection pass walked a connector's documents from the first id on every run. A walk the deadline cut short never reached the tail, so documents past that point could sta...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8365/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8365%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8365%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8365/files
Reloadhttps://github.com/simstudioai/sim/pull/8365/files
Reloadhttps://github.com/simstudioai/sim/pull/8365/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/member-resurrection-cursorhttps://github.com/simstudioai/sim/tree/fix/member-resurrection-cursor
Conversation 2 https://github.com/simstudioai/sim/pull/8365
Commits 2 https://github.com/simstudioai/sim/pull/8365/commits
Checks 31 https://github.com/simstudioai/sim/pull/8365/checks
Files changed https://github.com/simstudioai/sim/pull/8365/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8365/files
fix(knowledge): resume the member resurrection walk from a persisted cursor https://github.com/simstudioai/sim/pull/8365/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8365/files
6a88a51 fix(knowledge): resume the member resurrection walk from a persisted … waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8365/commits/6a88a5104d97a0aab18ee35c7c4ff0f398fe15c1
f6a7a3c chore(knowledge): brace the resurrection cursor branches and drop a v… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8365/commits/f6a7a3c8312255f4b0f321385b6b051807bd2062
Clear filters https://github.com/simstudioai/sim/pull/8365/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8365/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8365/files
member-document-lifecycle.integration.ts https://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
member-observations.ts https://github.com/simstudioai/sim/pull/8365/files#diff-d38c4ec5ee0b5affe0223c865a8c4e1d1ee9673238bb0efc831542f2cd0388ea
reconciliation-window.ts https://github.com/simstudioai/sim/pull/8365/files#diff-a397298150e20079f419649d2cd5491b535ffde39ab744149eea033f5e8455e4
sync-content-pass.ts https://github.com/simstudioai/sim/pull/8365/files#diff-b6bd8cd1ab36d6b8e1b29f63847ffc4e4ee912f70e19de773896d753cc73d866
connectors.ts https://github.com/simstudioai/sim/pull/8365/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
0389_member_resurrection_cursor.sql https://github.com/simstudioai/sim/pull/8365/files#diff-36750b58873fcd3042c83b4f577954b030701de068871e5e0b859eb484b728db
0389_snapshot.json https://github.com/simstudioai/sim/pull/8365/files#diff-7be7ade3e6ce88c72d19db3947829f9efb69d4480678e645f0a42a97b1d3be21
_journal.json https://github.com/simstudioai/sim/pull/8365/files#diff-37150cc65ad16ee6fbc5fa318fc096be7730e16d63eaf863e3df5521b7030649
schema.ts https://github.com/simstudioai/sim/pull/8365/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
schema-tables.generated.ts https://github.com/simstudioai/sim/pull/8365/files#diff-e0edf0f56682cbbb36446389d81ccd7516f377568a0c09cd8e9c1c87b0b1850e
apps/sim/lib/knowledge/__integration__/member-document-lifecycle.integration.tshttps://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
View file https://github.com/simstudioai/sim/blob/f6a7a3c8312255f4b0f321385b6b051807bd2062/apps/sim/lib/knowledge/__integration__/member-document-lifecycle.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8365/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
https://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
https://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
https://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
https://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
https://github.com/simstudioai/sim/pull/8365/files#diff-e34731c263809cd6eef7e8e54dd08da1af38b7502cd515f0f26e531f279b355e
apps/sim/lib/knowledge/connectors/member-observations.tshttps://github.com/simstudioai/sim/pull/8365/files#diff-d38c4ec5ee0b5affe0223c865a8c4e1d1ee9673238bb0efc831542f2cd0388ea
View file https://github.com/simstudioai/sim/blob/f6a7a3c8312255f4b0f321385b6b051807bd2062/apps/sim/lib/knowledge/connectors/member-observations.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8365/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8365/files#diff-d38c4ec5ee0b5affe0223c865a8c4e1d1ee9673238bb0efc831542f2cd0388ea
https://github.com/simstudioai/sim/pull/8365/files#diff-d38c4ec5ee0b5affe0223c865a8c4e1d1ee9673238bb0efc831542f2cd0388ea
https://github.com/simstudioai/sim/pull/8365/files#diff-d38c4ec5ee0b5affe0223c865a8c4e1d1ee9673238bb0efc831542f2cd0388ea
https://github.com/simstudioai/sim/pull/8365/files#diff-d38c4ec5ee0b5affe0223c865a8c4e1d1ee9673238bb0efc831542f2cd0388ea
apps/sim/lib/knowledge/connectors/reconciliation-window.tshttps://github.com/simstudioai/sim/pull/8365/files#diff-a397298150e20079f419649d2cd5491b535ffde39ab744149eea033f5e8455e4
View file https://github.com/simstudioai/sim/blob/f6a7a3c8312255f4b0f321385b6b051807bd2062/apps/sim/lib/knowledge/connectors/reconciliation-window.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8365/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8365/files#diff-a397298150e20079f419649d2cd5491b535ffde39ab744149eea033f5e8455e4
https://github.com/simstudioai/sim/pull/8365/files#diff-a397298150e20079f419649d2cd5491b535ffde39ab744149eea033f5e8455e4
https://github.com/simstudioai/sim/pull/8365/files#diff-a397298150e20079f419649d2cd5491b535ffde39ab744149eea033f5e8455e4
https://github.com/simstudioai/sim/pull/8365/files#diff-a397298150e20079f419649d2cd5491b535ffde39ab744149eea033f5e8455e4
apps/sim/lib/knowledge/connectors/sync-content-pass.tshttps://github.com/simstudioai/sim/pull/8365/files#diff-b6bd8cd1ab36d6b8e1b29f63847ffc4e4ee912f70e19de773896d753cc73d866
View file https://github.com/simstudioai/sim/blob/f6a7a3c8312255f4b0f321385b6b051807bd2062/apps/sim/lib/knowledge/connectors/sync-content-pass.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8365/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8365/files#diff-b6bd8cd1ab36d6b8e1b29f63847ffc4e4ee912f70e19de773896d753cc73d866
https://github.com/simstudioai/sim/pull/8365/files#diff-b6bd8cd1ab36d6b8e1b29f63847ffc4e4ee912f70e19de773896d753cc73d866
https://github.com/simstudioai/sim/pull/8365/files#diff-b6bd8cd1ab36d6b8e1b29f63847ffc4e4ee912f70e19de773896d753cc73d866
https://github.com/simstudioai/sim/pull/8365/files#diff-b6bd8cd1ab36d6b8e1b29f63847ffc4e4ee912f70e19de773896d753cc73d866
apps/sim/lib/knowledge/orchestration/connectors.tshttps://github.com/simstudioai/sim/pull/8365/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
View file https://github.com/simstudioai/sim/blob/f6a7a3c8312255f4b0f321385b6b051807bd2062/apps/sim/lib/knowledge/orchestration/connectors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8365/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8365/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8365/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
https://github.com/simstudioai/sim/pull/8365/files#diff-50cb99189b1dc87df12d9b4f50a563206952b53de947873de00ad9f30ef59a25
packages/db/migrations/0389_member_resurrection_cursor.sqlhttps://github.com/simstudioai/sim/pull/8365/files#diff-36750b58873fcd3042c83b4f577954b030701de068871e5e0b859eb484b728db
View file https://github.com/simstudioai/sim/blob/f6a7a3c8312255f4b0f321385b6b051807bd2062/packages/db/migrations/0389_member_resurrection_cursor.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8365/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8365/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8365/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.