René's URL Explorer Experiment


Title: test(knowledge): accept either ordered index in the scale window check and bound discussion case text by waleedlatif1 · Pull Request #8363 · simstudioai/sim · GitHub

Open Graph Title: test(knowledge): accept either ordered index in the scale window check and bound discussion case text by waleedlatif1 · Pull Request #8363 · simstudioai/sim

X Title: test(knowledge): accept either ordered index in the scale window check and bound discussion case text by waleedlatif1 · Pull Request #8363 · simstudioai/sim

Description: Summary scale.integration.ts: the reconciliation window-scan plan may walk the v2 index or the primary key (the fixture's single connector is nearly the whole table). The check now requires every index in the plan to be one of those two and at least one to be present, instead of v2 only, so it still rejects a plan that reads the connector through another index and sorts github.ts exports exceedsGitHubTextLimit (the same count and 256-character boundary as the inline check it replaces in searchGitHub), and scripts/test-search-discussions-live.ts rejects over-limit case queries while parsing, before any oracle request Responds to review threads on #8356 Type of Change Other: test and script hygiene Testing An oversized case fails at parse time with no request made sim-search live suites (218 tests) and type-check pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary scale.integration.ts: the reconciliation window-scan plan may walk the v2 index or the primary key (the fixture's single connector is nearly the whole table). The check now requires ev...

X Description: Summary scale.integration.ts: the reconciliation window-scan plan may walk the v2 index or the primary key (the fixture's single connector is nearly the whole table). The check now require...

Opengraph URL: https://github.com/simstudioai/sim/pull/8363

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:231d6920-173a-abb1-9224-e4872f8fe8a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC290:3C556:A7BC87:E7077F:6AFB4FBD
html-safe-nonce7c35b5c9f278728a89994b67ba583f7531d534d3dbbd3578fb227cfc05b60d19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjkwOjNDNTU2OkE3QkM4NzpFNzA3N0Y6NkFGQjRGQkQiLCJ2aXNpdG9yX2lkIjoiODMxMDczOTc0NjUwMjE2ODUwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0561796f79825b3cee9792ced26865d1ab1b3c3f437bbc0ffbc23b52af6fb2f7
hovercard-subject-tagpull_request:4658277321
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8363/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary scale.integration.ts: the reconciliation window-scan plan may walk the v2 index or the primary key (the fixture's single connector is nearly the whole table). The check now requires ev...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8363/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8363%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8363%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8363/files
Reloadhttps://github.com/simstudioai/sim/pull/8363/files
Reloadhttps://github.com/simstudioai/sim/pull/8363/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
chore/review-followup-testshttps://github.com/simstudioai/sim/tree/chore/review-followup-tests
Conversation 2 https://github.com/simstudioai/sim/pull/8363
Commits 2 https://github.com/simstudioai/sim/pull/8363/commits
Checks 31 https://github.com/simstudioai/sim/pull/8363/checks
Files changed https://github.com/simstudioai/sim/pull/8363/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8363/files
test(knowledge): accept either ordered index in the scale window check and bound discussion case text https://github.com/simstudioai/sim/pull/8363/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8363/files
ed6f665 test(knowledge): accept either ordered index in the scale window chec… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8363/commits/ed6f665224ba9829479d3a82cc8c304ee1e7bcfe
ec3efcb chore: document the GitHub text-limit helper and brace the scale plan… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8363/commits/ec3efcb5765d253486763a18aca6b262505b4b37
Clear filters https://github.com/simstudioai/sim/pull/8363/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8363/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8363/files
scale.integration.ts https://github.com/simstudioai/sim/pull/8363/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
github.ts https://github.com/simstudioai/sim/pull/8363/files#diff-119864a99326c02ba32b34bfe1ce0befb46277a72d377b21415e5a4d92337ca1
test-search-discussions-live.ts https://github.com/simstudioai/sim/pull/8363/files#diff-bc028e1d00658086fccf7df102cdaabcc8d90ddc7746c47386c2f61ff73b729f
apps/sim/lib/knowledge/__integration__/scale.integration.tshttps://github.com/simstudioai/sim/pull/8363/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
View file https://github.com/simstudioai/sim/blob/ec3efcb5765d253486763a18aca6b262505b4b37/apps/sim/lib/knowledge/__integration__/scale.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8363/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8363/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8363/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
apps/sim/lib/sim-search/live/github.tshttps://github.com/simstudioai/sim/pull/8363/files#diff-119864a99326c02ba32b34bfe1ce0befb46277a72d377b21415e5a4d92337ca1
View file https://github.com/simstudioai/sim/blob/ec3efcb5765d253486763a18aca6b262505b4b37/apps/sim/lib/sim-search/live/github.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8363/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8363/files#diff-119864a99326c02ba32b34bfe1ce0befb46277a72d377b21415e5a4d92337ca1
https://github.com/simstudioai/sim/pull/8363/files#diff-119864a99326c02ba32b34bfe1ce0befb46277a72d377b21415e5a4d92337ca1
https://github.com/simstudioai/sim/pull/8363/files#diff-119864a99326c02ba32b34bfe1ce0befb46277a72d377b21415e5a4d92337ca1
https://github.com/simstudioai/sim/pull/8363/files#diff-119864a99326c02ba32b34bfe1ce0befb46277a72d377b21415e5a4d92337ca1
apps/sim/scripts/test-search-discussions-live.tshttps://github.com/simstudioai/sim/pull/8363/files#diff-bc028e1d00658086fccf7df102cdaabcc8d90ddc7746c47386c2f61ff73b729f
View file https://github.com/simstudioai/sim/blob/ec3efcb5765d253486763a18aca6b262505b4b37/apps/sim/scripts/test-search-discussions-live.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8363/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8363/files#diff-bc028e1d00658086fccf7df102cdaabcc8d90ddc7746c47386c2f61ff73b729f
https://github.com/simstudioai/sim/pull/8363/files#diff-bc028e1d00658086fccf7df102cdaabcc8d90ddc7746c47386c2f61ff73b729f
https://github.com/simstudioai/sim/pull/8363/files#diff-bc028e1d00658086fccf7df102cdaabcc8d90ddc7746c47386c2f61ff73b729f
https://github.com/simstudioai/sim/pull/8363/files#diff-bc028e1d00658086fccf7df102cdaabcc8d90ddc7746c47386c2f61ff73b729f
Please reload this pagehttps://github.com/simstudioai/sim/pull/8363/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.