René's URL Explorer Experiment


Title: fix(billing): key the usage email claim on the exact period start and anchor shared sums to their start by waleedlatif1 · Pull Request #8360 · simstudioai/sim · GitHub

Open Graph Title: fix(billing): key the usage email claim on the exact period start and anchor shared sums to their start by waleedlatif1 · Pull Request #8360 · simstudioai/sim

X Title: fix(billing): key the usage email claim on the exact period start and anchor shared sums to their start by waleedlatif1 · Pull Request #8360 · simstudioai/sim

Description: Summary The usage-threshold email claim keyed creditsPeriod on the period start's UTC day. Two distinct periods starting the same day with the same limit (a subscription replaced the day it began) shared one key, so the new period's email was suppressed. It now keys on the exact period start in epoch seconds, bound as bigint in both the pre-check SELECT and the claim UPDATE, which share one SQL builder. This has to land before v0.9.4 reaches main, because changing the key later would re-arm every current claim The shared reporting-usage cache wrote SET … PX TTL NX after the sum finished, so a sum that ran long, or a SET resent after a reconnect, got a full fresh TTL on an older total. The write now anchors expiry to when the sum began: PX max(sumStartedAt + TTL + jitter − now, 5s) NX. The 5s floor keeps a slow sum briefly shared instead of re-run by every process. TSDoc states the resulting bound Responds to review threads on #8356 Type of Change Bug fix Testing usage-threshold-email.integration.ts: a period and its same-day replacement each deliver their own warning; it fails on staging's day key reporting-usage-cache.integration.ts (real Redis): a sum that began 20s ago expires ~TTL−20s after the write, not a full TTL a sum that began 31s ago is stored with the 5s floor both fail on staging's relative write, and the second fails with the floor removed Billing and logs integration (66) and unit (1,059) suites, type-check, lint, and check:audits pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The usage-threshold email claim keyed creditsPeriod on the period start's UTC day. Two distinct periods starting the same day with the same limit (a subscription replaced the day it be...

X Description: Summary The usage-threshold email claim keyed creditsPeriod on the period start's UTC day. Two distinct periods starting the same day with the same limit (a subscription replaced the day i...

Opengraph URL: https://github.com/simstudioai/sim/pull/8360

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0135d20f-616d-3cfb-fada-36e6f3334d60
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D10:219171:932256:CFDE7E:6AFB508A
html-safe-nonced03458aa66e3e25799a7848545e1bb1967d500c438e8a4367a72c0f6ea3a54f1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDEwOjIxOTE3MTo5MzIyNTY6Q0ZERTdFOjZBRkI1MDhBIiwidmlzaXRvcl9pZCI6IjY2MTY1MzI0OTAwNjIwOTAzNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0ca9a8046f7d28cabb4c711683af0ae10a71d316fbe09e4503bdfb2b200838bc
hovercard-subject-tagpull_request:4658087532
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8360/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The usage-threshold email claim keyed creditsPeriod on the period start's UTC day. Two distinct periods starting the same day with the same limit (a subscription replaced the day it be...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8360/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8360%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8360%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8360/files
Reloadhttps://github.com/simstudioai/sim/pull/8360/files
Reloadhttps://github.com/simstudioai/sim/pull/8360/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/usage-claim-exact-period-and-anchored-cachehttps://github.com/simstudioai/sim/tree/fix/usage-claim-exact-period-and-anchored-cache
Conversation 2 https://github.com/simstudioai/sim/pull/8360
Commits 3 https://github.com/simstudioai/sim/pull/8360/commits
Checks 31 https://github.com/simstudioai/sim/pull/8360/checks
Files changed https://github.com/simstudioai/sim/pull/8360/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8360/files
fix(billing): key the usage email claim on the exact period start and anchor shared sums to their start https://github.com/simstudioai/sim/pull/8360/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8360/files
79ba544 fix(billing): key the usage email claim on the exact period start and… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8360/commits/79ba544dd53ea984205ebf57b9322c8e36c7b9a9
7e842d1 fix(billing): anchor shared sum expiry with a portable PX and a floor… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8360/commits/7e842d138d0b6dac674f15936003a4c7b3604dda
b8fd3f6 docs(billing): note the reconnect delay in the shared sum staleness b… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8360/commits/b8fd3f67ea3ce9b2664a5e0d66f51d01d44f3e6e
Clear filters https://github.com/simstudioai/sim/pull/8360/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8360/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8360/files
limit-notifications.ts https://github.com/simstudioai/sim/pull/8360/files#diff-ff2454cf24b15a2340dd07fda2e65cc33b10498be771492f9c47efd549430a9d
reporting-usage-cache.integration.ts https://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
reporting-usage-cache.ts https://github.com/simstudioai/sim/pull/8360/files#diff-977dfbb8bb7a097f1980636fd3a5e4b78fdcafae0905d0fbd941eba44a35ab7f
usage-threshold-email.integration.ts https://github.com/simstudioai/sim/pull/8360/files#diff-43e574033f5c5e83226cdec197dd3f36cdbbe79f7f62cb9b7b26865e22467128
schema.ts https://github.com/simstudioai/sim/pull/8360/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
apps/sim/lib/billing/core/limit-notifications.tshttps://github.com/simstudioai/sim/pull/8360/files#diff-ff2454cf24b15a2340dd07fda2e65cc33b10498be771492f9c47efd549430a9d
View file https://github.com/simstudioai/sim/blob/b8fd3f67ea3ce9b2664a5e0d66f51d01d44f3e6e/apps/sim/lib/billing/core/limit-notifications.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8360/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8360/files#diff-ff2454cf24b15a2340dd07fda2e65cc33b10498be771492f9c47efd549430a9d
https://github.com/simstudioai/sim/pull/8360/files#diff-ff2454cf24b15a2340dd07fda2e65cc33b10498be771492f9c47efd549430a9d
https://github.com/simstudioai/sim/pull/8360/files#diff-ff2454cf24b15a2340dd07fda2e65cc33b10498be771492f9c47efd549430a9d
apps/sim/lib/billing/core/reporting-usage-cache.integration.tshttps://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
View file https://github.com/simstudioai/sim/blob/b8fd3f67ea3ce9b2664a5e0d66f51d01d44f3e6e/apps/sim/lib/billing/core/reporting-usage-cache.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8360/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
https://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
https://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
https://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
https://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
https://github.com/simstudioai/sim/pull/8360/files#diff-82e94e157ca2946ebf8db682fc4721e56025668b5ee5eb403d21e74881cacbca
apps/sim/lib/billing/core/reporting-usage-cache.tshttps://github.com/simstudioai/sim/pull/8360/files#diff-977dfbb8bb7a097f1980636fd3a5e4b78fdcafae0905d0fbd941eba44a35ab7f
View file https://github.com/simstudioai/sim/blob/b8fd3f67ea3ce9b2664a5e0d66f51d01d44f3e6e/apps/sim/lib/billing/core/reporting-usage-cache.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8360/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8360/files#diff-977dfbb8bb7a097f1980636fd3a5e4b78fdcafae0905d0fbd941eba44a35ab7f
https://github.com/simstudioai/sim/pull/8360/files#diff-977dfbb8bb7a097f1980636fd3a5e4b78fdcafae0905d0fbd941eba44a35ab7f
https://github.com/simstudioai/sim/pull/8360/files#diff-977dfbb8bb7a097f1980636fd3a5e4b78fdcafae0905d0fbd941eba44a35ab7f
https://github.com/simstudioai/sim/pull/8360/files#diff-977dfbb8bb7a097f1980636fd3a5e4b78fdcafae0905d0fbd941eba44a35ab7f
https://github.com/simstudioai/sim/pull/8360/files#diff-977dfbb8bb7a097f1980636fd3a5e4b78fdcafae0905d0fbd941eba44a35ab7f
apps/sim/lib/billing/core/usage-threshold-email.integration.tshttps://github.com/simstudioai/sim/pull/8360/files#diff-43e574033f5c5e83226cdec197dd3f36cdbbe79f7f62cb9b7b26865e22467128
View file https://github.com/simstudioai/sim/blob/b8fd3f67ea3ce9b2664a5e0d66f51d01d44f3e6e/apps/sim/lib/billing/core/usage-threshold-email.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8360/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8360/files#diff-43e574033f5c5e83226cdec197dd3f36cdbbe79f7f62cb9b7b26865e22467128
https://github.com/simstudioai/sim/pull/8360/files#diff-43e574033f5c5e83226cdec197dd3f36cdbbe79f7f62cb9b7b26865e22467128
https://github.com/simstudioai/sim/pull/8360/files#diff-43e574033f5c5e83226cdec197dd3f36cdbbe79f7f62cb9b7b26865e22467128
https://github.com/simstudioai/sim/pull/8360/files#diff-43e574033f5c5e83226cdec197dd3f36cdbbe79f7f62cb9b7b26865e22467128
packages/db/schema.tshttps://github.com/simstudioai/sim/pull/8360/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
View file https://github.com/simstudioai/sim/blob/b8fd3f67ea3ce9b2664a5e0d66f51d01d44f3e6e/packages/db/schema.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8360/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8360/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
https://github.com/simstudioai/sim/pull/8360/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
Please reload this pagehttps://github.com/simstudioai/sim/pull/8360/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.