René's URL Explorer Experiment


Title: fix(search): let cancelled live reads stop instead of reporting partial coverage by waleedlatif1 · Pull Request #8359 · simstudioai/sim · GitHub

Open Graph Title: fix(search): let cancelled live reads stop instead of reporting partial coverage by waleedlatif1 · Pull Request #8359 · simstudioai/sim

X Title: fix(search): let cancelled live reads stop instead of reporting partial coverage by waleedlatif1 · Pull Request #8359 · simstudioai/sim

Description: Summary A cancelled or timed-out live read could resolve as a successful, partially covered document. readDiscussionSection turns every per-section failure into a "could not be fully retrieved" warning, including the caller's abort, so Drive, Linear, and GitHub reads kept going after Stop, a cancelled MCP request, or the 15s read budget readLiveDocument now decides cancellation by the signal's state right after the provider read (signal.throwIfAborted(), before verifyCurrent), as search already does. That covers every abort reason: Copilot Stop's string reasons, custom abort errors, an MCP cancel reason, AbortError, and TimeoutError, on every provider path. Genuine provider failures still degrade to partial coverage Notion: a notion-ai-search result without a type is reported as partial instead of complete; an explicit workspace_search fallback stays complete Linear: backwards (oldest-first) reads validate hasPreviousPage, the flag they actually page on Meeting content and discussion entries are cut with truncateAtCodePoint, so a cut never splits a surrogate pair and the discussion cap is exact Type of Change Bug fix Testing readLiveDocument rejects with the exact reason for a string reason, AbortError, and TimeoutError during a Drive discussion read, and a connection reset on the comments request still returns the document with the coverage warning Notion missing-type → partial; Linear backwards read without hasPreviousPage → rejected With staging's sources swapped in, all five new cases fail lib/sim-search suites (303 tests), type-check, lint, and check:audits pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary A cancelled or timed-out live read could resolve as a successful, partially covered document. readDiscussionSection turns every per-section failure into a "could not be fully retrieve...

X Description: Summary A cancelled or timed-out live read could resolve as a successful, partially covered document. readDiscussionSection turns every per-section failure into a "could not be fully retr...

Opengraph URL: https://github.com/simstudioai/sim/pull/8359

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:81ab321a-2dbb-4429-f7c5-9c353c18210c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2BC:1C8E04:BD7F85:1049E68:6AFB568B
html-safe-nonce502268706b43fb7ec6bdeac4ee6645e6210d8ae35b8d5467cc8e7840b4c02624
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkJDOjFDOEUwNDpCRDdGODU6MTA0OUU2ODo2QUZCNTY4QiIsInZpc2l0b3JfaWQiOiI2MTEyMzE5MjIwODkwNjg3MTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac715a89f4f6287c0fbf0a5c9e33ea40763efbc653685b214a2e30dba92ceb36ce
hovercard-subject-tagpull_request:4658078864
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8359/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary A cancelled or timed-out live read could resolve as a successful, partially covered document. readDiscussionSection turns every per-section failure into a "could not be fully retrieve...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8359/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8359%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8359%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8359/files
Reloadhttps://github.com/simstudioai/sim/pull/8359/files
Reloadhttps://github.com/simstudioai/sim/pull/8359/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/search-discussion-propagate-cancellationhttps://github.com/simstudioai/sim/tree/fix/search-discussion-propagate-cancellation
Conversation 8 https://github.com/simstudioai/sim/pull/8359
Commits 3 https://github.com/simstudioai/sim/pull/8359/commits
Checks 31 https://github.com/simstudioai/sim/pull/8359/checks
Files changed https://github.com/simstudioai/sim/pull/8359/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8359/files
fix(search): let cancelled live reads stop instead of reporting partial coverage https://github.com/simstudioai/sim/pull/8359/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8359/files
48d561e fix(search): let cancelled discussion reads stop instead of reporting… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8359/commits/48d561e1a9881132cf112730d96dc49e0370f55d
bb7323d fix(search): judge live-read cancellation by the signal, not the erro… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8359/commits/bb7323d298288f0e4ed3478e2439728b59a0c09a
8774dba fix(search): stop a live read cancelled during current-scope verifica… waleedlatif1 Sep 28, 2026 https://github.com/simstudioai/sim/pull/8359/commits/8774dba103cc3616e39b55ef4214e71bbad643a3
Clear filters https://github.com/simstudioai/sim/pull/8359/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8359/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8359/files
application.test.ts https://github.com/simstudioai/sim/pull/8359/files#diff-af2d21accc00823b671d6bf1cb0dda2f0f273ebdb911e7ec9cdd52ea034a5c20
application.ts https://github.com/simstudioai/sim/pull/8359/files#diff-151e464c65b5447415809287c8c227355b3d21309f26c9399b2e49c0cdd59608
discussion-reads.test.ts https://github.com/simstudioai/sim/pull/8359/files#diff-81f831759e49364c3d8e997a6782f5d532cfbe66651218e4cda9cc1f2378afe0
discussion.ts https://github.com/simstudioai/sim/pull/8359/files#diff-0672621f27e2c8253c4a130af74a5360cb644cb9f167422f154e3ac541237e3d
linear.test.ts https://github.com/simstudioai/sim/pull/8359/files#diff-44f84b8e48de3d7d3464cb965c0d5f19de83fa878e650d66530eaab5157e2356
linear.ts https://github.com/simstudioai/sim/pull/8359/files#diff-b072c85af3569f64b9a0c687fe04cffbd3b4add350cca73b340aebc95bc0dcdf
meeting-content.ts https://github.com/simstudioai/sim/pull/8359/files#diff-d84debd51d22014d267d70befb6200d9517906530c4da278c95c854a7f9a1829
notion-mcp.test.ts https://github.com/simstudioai/sim/pull/8359/files#diff-b37dabd0aefdd6e3ced753bfbb20ee502b5e801a54190d5f211e035890de6299
notion-mcp.ts https://github.com/simstudioai/sim/pull/8359/files#diff-737e80eecbbea842b4dc1b3f5b1cf1c7c4ca4a50790cdc1227245c4d2832a85f
apps/sim/lib/sim-search/live/application.test.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-af2d21accc00823b671d6bf1cb0dda2f0f273ebdb911e7ec9cdd52ea034a5c20
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/application.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-af2d21accc00823b671d6bf1cb0dda2f0f273ebdb911e7ec9cdd52ea034a5c20
https://github.com/simstudioai/sim/pull/8359/files#diff-af2d21accc00823b671d6bf1cb0dda2f0f273ebdb911e7ec9cdd52ea034a5c20
https://github.com/simstudioai/sim/pull/8359/files#diff-af2d21accc00823b671d6bf1cb0dda2f0f273ebdb911e7ec9cdd52ea034a5c20
https://github.com/simstudioai/sim/pull/8359/files#diff-af2d21accc00823b671d6bf1cb0dda2f0f273ebdb911e7ec9cdd52ea034a5c20
apps/sim/lib/sim-search/live/application.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-151e464c65b5447415809287c8c227355b3d21309f26c9399b2e49c0cdd59608
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/application.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-151e464c65b5447415809287c8c227355b3d21309f26c9399b2e49c0cdd59608
https://github.com/simstudioai/sim/pull/8359/files#diff-151e464c65b5447415809287c8c227355b3d21309f26c9399b2e49c0cdd59608
apps/sim/lib/sim-search/live/discussion-reads.test.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-81f831759e49364c3d8e997a6782f5d532cfbe66651218e4cda9cc1f2378afe0
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/discussion-reads.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-81f831759e49364c3d8e997a6782f5d532cfbe66651218e4cda9cc1f2378afe0
https://github.com/simstudioai/sim/pull/8359/files#diff-81f831759e49364c3d8e997a6782f5d532cfbe66651218e4cda9cc1f2378afe0
apps/sim/lib/sim-search/live/discussion.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-0672621f27e2c8253c4a130af74a5360cb644cb9f167422f154e3ac541237e3d
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/discussion.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-0672621f27e2c8253c4a130af74a5360cb644cb9f167422f154e3ac541237e3d
https://github.com/simstudioai/sim/pull/8359/files#diff-0672621f27e2c8253c4a130af74a5360cb644cb9f167422f154e3ac541237e3d
https://github.com/simstudioai/sim/pull/8359/files#diff-0672621f27e2c8253c4a130af74a5360cb644cb9f167422f154e3ac541237e3d
apps/sim/lib/sim-search/live/linear.test.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-44f84b8e48de3d7d3464cb965c0d5f19de83fa878e650d66530eaab5157e2356
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/linear.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-44f84b8e48de3d7d3464cb965c0d5f19de83fa878e650d66530eaab5157e2356
https://github.com/simstudioai/sim/pull/8359/files#diff-44f84b8e48de3d7d3464cb965c0d5f19de83fa878e650d66530eaab5157e2356
apps/sim/lib/sim-search/live/linear.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-b072c85af3569f64b9a0c687fe04cffbd3b4add350cca73b340aebc95bc0dcdf
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/linear.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-b072c85af3569f64b9a0c687fe04cffbd3b4add350cca73b340aebc95bc0dcdf
https://github.com/simstudioai/sim/pull/8359/files#diff-b072c85af3569f64b9a0c687fe04cffbd3b4add350cca73b340aebc95bc0dcdf
apps/sim/lib/sim-search/live/meeting-content.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-d84debd51d22014d267d70befb6200d9517906530c4da278c95c854a7f9a1829
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/meeting-content.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
apps/sim/lib/sim-search/live/notion-mcp.test.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-b37dabd0aefdd6e3ced753bfbb20ee502b5e801a54190d5f211e035890de6299
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/notion-mcp.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-b37dabd0aefdd6e3ced753bfbb20ee502b5e801a54190d5f211e035890de6299
https://github.com/simstudioai/sim/pull/8359/files#diff-b37dabd0aefdd6e3ced753bfbb20ee502b5e801a54190d5f211e035890de6299
apps/sim/lib/sim-search/live/notion-mcp.tshttps://github.com/simstudioai/sim/pull/8359/files#diff-737e80eecbbea842b4dc1b3f5b1cf1c7c4ca4a50790cdc1227245c4d2832a85f
View file https://github.com/simstudioai/sim/blob/8774dba103cc3616e39b55ef4214e71bbad643a3/apps/sim/lib/sim-search/live/notion-mcp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8359/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8359/files#diff-737e80eecbbea842b4dc1b3f5b1cf1c7c4ca4a50790cdc1227245c4d2832a85f
https://github.com/simstudioai/sim/pull/8359/files#diff-737e80eecbbea842b4dc1b3f5b1cf1c7c4ca4a50790cdc1227245c4d2832a85f
Please reload this pagehttps://github.com/simstudioai/sim/pull/8359/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.