René's URL Explorer Experiment


Title: fix(desktop): wait for native update staging and verify installation by waleedlatif1 · Pull Request #8346 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): wait for native update staging and verify installation by waleedlatif1 · Pull Request #8346 · simstudioai/sim

X Title: fix(desktop): wait for native update staging and verify installation by waleedlatif1 · Pull Request #8346 · simstudioai/sim

Description: Summary Wait for native Squirrel staging before offering restart, including when a newer release replaces an already staged update. Retain an older staged build only while its native feed is still valid, and let failed native staging retry safely. Handle background check failures independently of native failures so they cannot cancel a confirmed restart. Record the staged version atomically and compare it with the version running on the next launch, so an interrupted installation is distinguishable from a completed upgrade. Exercise real Electron and MacUpdater downloads, replacement failures, cached retries, and installation checkpoints. This follows Electron's native update lifecycle. Type of Change Bug fix Testing 870 desktop tests; desktop type check and build. Real Electron/MacUpdater integration test, demonstrated failing against the original updater. JSON checks and HTTP request evidence are written to DESKTOP_UPDATER_REPORT_PATH or Playwright test results. Native verification and signed bundle replacement are simulated in the integration fixture; a signed release upgrade remains release validation. Repository lint, all 51 audits, block-registry checks, and docs-manifest check. Full local Electron run: 56 passed, 3 packaged-only skips, and 4 browser/password-picker failures. All 4 passed on focused reruns; the unpackaged shell exits updater initialization before the changed logic. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Wait for native Squirrel staging before offering restart, including when a newer release replaces an already staged update. Retain an older staged build only while its native feed is still...

X Description: Summary Wait for native Squirrel staging before offering restart, including when a newer release replaces an already staged update. Retain an older staged build only while its native feed is still...

Opengraph URL: https://github.com/simstudioai/sim/pull/8346

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c1c49d94-4d8f-4b84-6bf9-a02c871aef47
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC38:C4B81:BD17EC:104CADE:6AFB5681
html-safe-noncea8792d93ab3c1cef3551c3c30ced8c55457467f8d3fff7ead06626013c632a4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzM4OkM0QjgxOkJEMTdFQzoxMDRDQURFOjZBRkI1NjgxIiwidmlzaXRvcl9pZCI6IjU2NTU0NjA0NjU4Mjg2NDg1NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace05d3fea4a378265f93ed7ef1641922ae463c7b304aeec9ba2d5f59f491200bb
hovercard-subject-tagpull_request:4650003956
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8346/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Wait for native Squirrel staging before offering restart, including when a newer release replaces an already staged update. Retain an older staged build only while its native feed is still...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8346/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8346%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8346%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8346/files
Reloadhttps://github.com/simstudioai/sim/pull/8346/files
Reloadhttps://github.com/simstudioai/sim/pull/8346/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
codex/desktop-update-lifecyclehttps://github.com/simstudioai/sim/tree/codex/desktop-update-lifecycle
Conversation 10 https://github.com/simstudioai/sim/pull/8346
Commits 2 https://github.com/simstudioai/sim/pull/8346/commits
Checks 35 https://github.com/simstudioai/sim/pull/8346/checks
Files changed https://github.com/simstudioai/sim/pull/8346/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8346/files
fix(desktop): wait for native update staging and verify installation https://github.com/simstudioai/sim/pull/8346/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/8346/files
3a2ba81 fix(desktop): wait for native update staging and verify installation waleedlatif1 Sep 26, 2026 https://github.com/simstudioai/sim/pull/8346/commits/3a2ba81a68b52911b193bedef49ab45dc868a1b8
4f89858 fix(desktop): distinguish refresh failures from native update errors waleedlatif1 Sep 26, 2026 https://github.com/simstudioai/sim/pull/8346/commits/4f8985875b88f0eebefcac41c4e64d871b23391d
Clear filters https://github.com/simstudioai/sim/pull/8346/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8346/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8346/files
README.md https://github.com/simstudioai/sim/pull/8346/files#diff-02fa0edf2d5e897ab8020e95df421b21ff1c00f317f4e1fe4b85b8324abc09f6
updater.ts https://github.com/simstudioai/sim/pull/8346/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
updater.spec.ts https://github.com/simstudioai/sim/pull/8346/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
index.ts https://github.com/simstudioai/sim/pull/8346/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
observability.ts https://github.com/simstudioai/sim/pull/8346/files#diff-7d31e6ea1da86b8429cae98ee6a33a26579db8dd8383da8c0fe46b42a639a42c
updater.test.ts https://github.com/simstudioai/sim/pull/8346/files#diff-0d46817435dcd69c44c58e6a04c3da617de298f35f971d036fab402a9e89f501
updater.ts https://github.com/simstudioai/sim/pull/8346/files#diff-2c6665d35565a24497c27ea0f07e85853958beada9e7889bd1f81068ef1fe76a
apps/desktop/README.mdhttps://github.com/simstudioai/sim/pull/8346/files#diff-02fa0edf2d5e897ab8020e95df421b21ff1c00f317f4e1fe4b85b8324abc09f6
View file https://github.com/simstudioai/sim/blob/4f8985875b88f0eebefcac41c4e64d871b23391d/apps/desktop/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8346/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8346/files#diff-02fa0edf2d5e897ab8020e95df421b21ff1c00f317f4e1fe4b85b8324abc09f6
https://github.com/simstudioai/sim/pull/8346/files#diff-02fa0edf2d5e897ab8020e95df421b21ff1c00f317f4e1fe4b85b8324abc09f6
apps/desktop/e2e/fixtures/updater.tshttps://github.com/simstudioai/sim/pull/8346/files#diff-d05ad2cd4b4acef40a64a505660ea88f497f44d4a4ca4311916d9a51dab5e03e
View file https://github.com/simstudioai/sim/blob/4f8985875b88f0eebefcac41c4e64d871b23391d/apps/desktop/e2e/fixtures/updater.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8346/{{ revealButtonHref }}
apps/desktop/e2e/updater.spec.tshttps://github.com/simstudioai/sim/pull/8346/files#diff-fec33a65a8bb63e7dbc26b9716e946ee822cdab4b3ff011e52da0750a13c8f6c
View file https://github.com/simstudioai/sim/blob/4f8985875b88f0eebefcac41c4e64d871b23391d/apps/desktop/e2e/updater.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8346/{{ revealButtonHref }}
apps/desktop/src/main/index.tshttps://github.com/simstudioai/sim/pull/8346/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
View file https://github.com/simstudioai/sim/blob/4f8985875b88f0eebefcac41c4e64d871b23391d/apps/desktop/src/main/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8346/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8346/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
https://github.com/simstudioai/sim/pull/8346/files#diff-5bf7db7b15749c034541a4a70a0cacf9816b4e214fd11cb5735c5ddb7ca4b1d8
apps/desktop/src/main/observability.tshttps://github.com/simstudioai/sim/pull/8346/files#diff-7d31e6ea1da86b8429cae98ee6a33a26579db8dd8383da8c0fe46b42a639a42c
View file https://github.com/simstudioai/sim/blob/4f8985875b88f0eebefcac41c4e64d871b23391d/apps/desktop/src/main/observability.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8346/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8346/files#diff-7d31e6ea1da86b8429cae98ee6a33a26579db8dd8383da8c0fe46b42a639a42c
https://github.com/simstudioai/sim/pull/8346/files#diff-7d31e6ea1da86b8429cae98ee6a33a26579db8dd8383da8c0fe46b42a639a42c
Please reload this pagehttps://github.com/simstudioai/sim/pull/8346/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8346/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.