René's URL Explorer Experiment


Title: fix(desktop): keep built-in browser logins across restarts, faster tab reveal by TheodoreSpeaks · Pull Request #8337 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): keep built-in browser logins across restarts, faster tab reveal by TheodoreSpeaks · Pull Request #8337 · simstudioai/sim

X Title: fix(desktop): keep built-in browser logins across restarts, faster tab reveal by TheodoreSpeaks · Pull Request #8337 · simstudioai/sim

Description: Summary Built-in browser logins no longer disappear when the desktop app restarts. Electron hard-codes Chromium's persist_session_cookies to false, so every session-only cookie in the persist:sim-browser-agent partition was dropped on quit — both ones imported from Chrome and ones sites set in-app Session cookies set over HTTP get Max-Age (30 days) added to their Set-Cookie header in onHeadersReceived, before Chromium stores them. Cookies that already have Expires/Max-Age (including deletions) pass through untouched, and the window renews whenever the site re-sends the cookie Session cookies imported from Chrome get the same 30-day lifetime when written Rewriting the header instead of re-saving stored cookies avoids a race: re-saving after the fact resurrected cookies a site deleted milliseconds after setting them (login redirects do this) Known gap: session cookies set from page JS (document.cookie) still die on quit — they can't be HttpOnly, so logins rarely live in them Tab strip: bringing the active tab into view now takes a fixed 200ms instead of native smooth scroll, whose duration grows with distance and crawled across a crowded strip. Jumps instantly under reduced motion, and stops when the user wheel-scrolls or drags Type of Change Bug fix Improvement Testing New desktop e2e (e2e/session-cookies.spec.ts): signs in to a fixture site in the built-in browser, quits, relaunches on the same profile, and asserts the exact cookies the site receives — login survives, a cookie deleted mid-redirect stays gone. Fails with the fix disabled Unit tests for the Set-Cookie rewrite and import lifetime Tested both changes manually in the local desktop app Desktop + emcn type-check, lint, and check:audits pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code https://claude.ai/code/session_012J9iDBUYML4JywAxj4DaKq

Open Graph Description: Summary Built-in browser logins no longer disappear when the desktop app restarts. Electron hard-codes Chromium's persist_session_cookies to false, so every session-only cookie in the persist:...

X Description: Summary Built-in browser logins no longer disappear when the desktop app restarts. Electron hard-codes Chromium's persist_session_cookies to false, so every session-only cookie in the pers...

Opengraph URL: https://github.com/simstudioai/sim/pull/8337

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d180cc08-a5e6-355c-98de-52bb1babfec1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6A0:2D7CAE:C20D3E:1127A8B:6AFB5E1D
html-safe-nonceed33b1e6520dd9e10ce43769e1af2107dbbd091e4c8ab52bcc3342cbf5333018
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkEwOjJEN0NBRTpDMjBEM0U6MTEyN0E4Qjo2QUZCNUUxRCIsInZpc2l0b3JfaWQiOiIyNDk0MzEyNTY2ODY4MzY4OTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf39109835391b625dc68318be0dc433ecea5abdcbfb6e9514e09a4100d085c7f
hovercard-subject-tagpull_request:4649240954
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8337/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary Built-in browser logins no longer disappear when the desktop app restarts. Electron hard-codes Chromium's persist_session_cookies to false, so every session-only cookie in the persist:...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8337/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8337%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8337%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8337/files
Reloadhttps://github.com/simstudioai/sim/pull/8337/files
Reloadhttps://github.com/simstudioai/sim/pull/8337/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
TheodoreSpeakshttps://github.com/TheodoreSpeaks
staginghttps://github.com/simstudioai/sim/tree/staging
improve/desktop-synchttps://github.com/simstudioai/sim/tree/improve/desktop-sync
Conversation 35 https://github.com/simstudioai/sim/pull/8337
Commits 5 https://github.com/simstudioai/sim/pull/8337/commits
Checks 34 https://github.com/simstudioai/sim/pull/8337/checks
Files changed https://github.com/simstudioai/sim/pull/8337/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8337/files
fix(desktop): keep built-in browser logins across restarts, faster tab reveal https://github.com/simstudioai/sim/pull/8337/files#top
Show all changes 5 commits https://github.com/simstudioai/sim/pull/8337/files
f1772cf fix(desktop): keep built-in browser logins across app restarts TheodoreSpeaks Sep 26, 2026 https://github.com/simstudioai/sim/pull/8337/commits/f1772cf8b3f818b911f65038bdd3c12b589f5362
36965cb test(desktop): cover session-cookie persistence with a relaunch e2e TheodoreSpeaks Sep 26, 2026 https://github.com/simstudioai/sim/pull/8337/commits/36965cbb8b1734489b1c7f8e5c768ac322f1d36f
47ffe00 improvement(tab-strip): reveal the active tab in a fixed 200ms TheodoreSpeaks Sep 28, 2026 https://github.com/simstudioai/sim/pull/8337/commits/47ffe0018c17d11de3adcec38ffcb468ab1ab2a2
1a6a708 fix(tab-strip): stop an in-flight reveal on every retarget and on poi… TheodoreSpeaks Sep 28, 2026 https://github.com/simstudioai/sim/pull/8337/commits/1a6a7085b077d2078b0184991dacfdba153d18f1
ee6c10e fix(tab-strip): yield the reveal only to scrolling it did not cause TheodoreSpeaks Sep 28, 2026 https://github.com/simstudioai/sim/pull/8337/commits/ee6c10eae1ac384beac93b28afbf4a73fe015cb8
Clear filters https://github.com/simstudioai/sim/pull/8337/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8337/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8337/files
session-cookies.spec.ts https://github.com/simstudioai/sim/pull/8337/files#diff-02585e6a23e5817a58691a2367f50392c77da1a1e4292c2b08eafd48451b5230
session-cookies.test.ts https://github.com/simstudioai/sim/pull/8337/files#diff-d42b6ea4be59088508922d20998e3c8b54ea7bcc9351a767db2e6f4e6968fc3f
session-cookies.ts https://github.com/simstudioai/sim/pull/8337/files#diff-dce2b868dcbcd26bf4c0f5014974071c9a947224512aa207e6ade618fd5e161b
session.ts https://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
electron-mock.ts https://github.com/simstudioai/sim/pull/8337/files#diff-27ebaddd30812fedc9725b0b888a6d27edc61735a2c872050a6235ccd741dc1f
tab-strip.tsx https://github.com/simstudioai/sim/pull/8337/files#diff-12c2ca8a3aafb86d7c16fe72d1a349d77ba3de13abfa331b9120bc10d64bd425
apps/desktop/e2e/session-cookies.spec.tshttps://github.com/simstudioai/sim/pull/8337/files#diff-02585e6a23e5817a58691a2367f50392c77da1a1e4292c2b08eafd48451b5230
View file https://github.com/simstudioai/sim/blob/ee6c10eae1ac384beac93b28afbf4a73fe015cb8/apps/desktop/e2e/session-cookies.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8337/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/8337/files
apps/desktop/src/main/browser-agent/session-cookies.test.tshttps://github.com/simstudioai/sim/pull/8337/files#diff-d42b6ea4be59088508922d20998e3c8b54ea7bcc9351a767db2e6f4e6968fc3f
View file https://github.com/simstudioai/sim/blob/ee6c10eae1ac384beac93b28afbf4a73fe015cb8/apps/desktop/src/main/browser-agent/session-cookies.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8337/{{ revealButtonHref }}
apps/desktop/src/main/browser-agent/session-cookies.tshttps://github.com/simstudioai/sim/pull/8337/files#diff-dce2b868dcbcd26bf4c0f5014974071c9a947224512aa207e6ade618fd5e161b
View file https://github.com/simstudioai/sim/blob/ee6c10eae1ac384beac93b28afbf4a73fe015cb8/apps/desktop/src/main/browser-agent/session-cookies.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8337/{{ revealButtonHref }}
apps/desktop/src/main/browser-agent/session.tshttps://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
View file https://github.com/simstudioai/sim/blob/ee6c10eae1ac384beac93b28afbf4a73fe015cb8/apps/desktop/src/main/browser-agent/session.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8337/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
https://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
https://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
https://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
https://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
https://github.com/simstudioai/sim/pull/8337/files#diff-4950875424919c3217a0b1f974e08ec2f97fe2cd318916f610158e3cf09db3c7
apps/desktop/src/test/electron-mock.tshttps://github.com/simstudioai/sim/pull/8337/files#diff-27ebaddd30812fedc9725b0b888a6d27edc61735a2c872050a6235ccd741dc1f
View file https://github.com/simstudioai/sim/blob/ee6c10eae1ac384beac93b28afbf4a73fe015cb8/apps/desktop/src/test/electron-mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8337/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8337/files#diff-27ebaddd30812fedc9725b0b888a6d27edc61735a2c872050a6235ccd741dc1f
https://github.com/simstudioai/sim/pull/8337/files#diff-27ebaddd30812fedc9725b0b888a6d27edc61735a2c872050a6235ccd741dc1f
Please reload this pagehttps://github.com/simstudioai/sim/pull/8337/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8337/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.