René's URL Explorer Experiment


Title: improvement(knowledge): walk connector reconciliation by id so seen stamps stay off the index by waleedlatif1 · Pull Request #8334 · simstudioai/sim · GitHub

Open Graph Title: improvement(knowledge): walk connector reconciliation by id so seen stamps stay off the index by waleedlatif1 · Pull Request #8334 · simstudioai/sim

X Title: improvement(knowledge): walk connector reconciliation by id so seen stamps stay off the index by waleedlatif1 · Pull Request #8334 · simstudioai/sim

Description: Summary Connector sync stamps document.source_seen_at on every listed document. source_seen_at is a key column of doc_connector_reconciliation_idx, so every stamp was a non-HOT update that wrote every index on document. This is release A of two: move every reader off that key so release B can drop it and the stamps become HOT New doc_connector_reconciliation_v2_idx (connector_id, id) with the same partial predicate, built concurrently. The old index stays until release B The absence walks (ACL revoke, soft delete, hard delete) and the member resurrection walk page by id instead of (seen, id), with absence as a plain filter. Each window is built by a recursive keyset walk that fetches one row per step (id > previous ORDER BY id LIMIT 1) up to 5,000 ids, so every statement reads at most one window whatever plan the database picks. A single ORDER BY id LIMIT could be planned as a bitmap read of the whole connector plus a sort. Matches are filtered within the window, so cost is bounded by ids scanned, not matches found. A walk whose absence count is zero is skipped Both seen stamps skip rows already stamped at or after the run start (staleSeen), so current rows aren't rewritten and a later stamp is never overwritten by an earlier one Type of Change Improvement Testing New listing-continuation case: 15k present rows, then a few absent live rows and tombstones last in id order. Every absent row is processed, and every page statement (re-run under EXPLAIN ANALYZE) stays within the window bound. It fails on the unbounded id keyset (15,003 rows scanned in one statement) Seen-stamp guard: rows stamped after the run start keep their stamp (connector-lease-pages); it fails with the guard removed Scale suite: both window statements use the v2 index. Reconciliation took 2.0s vs 15.9s with unbounded pages listing-continuation (incl. NULL and microsecond tie cases), member-document-lifecycle, sync-content-pass, and connector-lease-pages pass, as do the lib/knowledge unit tests, type-check, lint, check:audits, and check:migrations origin/staging Release B, after this deploys: drop doc_connector_reconciliation_idx concurrently and add a HOT-update regression test Migration renumbered to 0388 on top of staging Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Connector sync stamps document.source_seen_at on every listed document. source_seen_at is a key column of doc_connector_reconciliation_idx, so every stamp was a non-HOT update that wrote e...

X Description: Summary Connector sync stamps document.source_seen_at on every listed document. source_seen_at is a key column of doc_connector_reconciliation_idx, so every stamp was a non-HOT update that wrote e...

Opengraph URL: https://github.com/simstudioai/sim/pull/8334

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:912c00dd-cf97-36d2-c2fa-2b03ff76f148
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB88:11DC7C:B07EC9:F15B21:6AFB507D
html-safe-nonceb10361cecdc7c78d2daffb2fcc1d204541813e7957df74ac7b7ef6342f809fba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjg4OjExREM3QzpCMDdFQzk6RjE1QjIxOjZBRkI1MDdEIiwidmlzaXRvcl9pZCI6IjU5MDQzNjgxNTI5Mzc3MTM3ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2564e98ae45466f4e0d751ba3c15221fae68c227816a0f240b7b504a86af8b01
hovercard-subject-tagpull_request:4648650090
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8334/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Connector sync stamps document.source_seen_at on every listed document. source_seen_at is a key column of doc_connector_reconciliation_idx, so every stamp was a non-HOT update that wrote e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8334/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8334%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8334%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8334/files
Reloadhttps://github.com/simstudioai/sim/pull/8334/files
Reloadhttps://github.com/simstudioai/sim/pull/8334/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
improvement/connector-reconciliation-id-keysethttps://github.com/simstudioai/sim/tree/improvement/connector-reconciliation-id-keyset
Conversation 21 https://github.com/simstudioai/sim/pull/8334
Commits 1 https://github.com/simstudioai/sim/pull/8334/commits
Checks 32 https://github.com/simstudioai/sim/pull/8334/checks
Files changed https://github.com/simstudioai/sim/pull/8334/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8334/files
improvement(knowledge): walk connector reconciliation by id so seen stamps stay off the index https://github.com/simstudioai/sim/pull/8334/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/8334/files
9b2d1d8 improvement(knowledge): walk connector reconciliation by id so seen s… waleedlatif1 Sep 26, 2026 https://github.com/simstudioai/sim/pull/8334/commits/9b2d1d8152650650fe1f8e754b7e1eb2015224c0
Clear filters https://github.com/simstudioai/sim/pull/8334/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8334/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8334/files
connector-lease-pages.integration.ts https://github.com/simstudioai/sim/pull/8334/files#diff-5fa5ca3a11a947dcad4f56d576ff1a199a9fde1a3d0d7bda3b10abbb38787ae3
listing-continuation.integration.ts https://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
scale.integration.ts https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
member-observations.test.ts https://github.com/simstudioai/sim/pull/8334/files#diff-862878ee240c7c81a2b4c5fe75155383f946ddb11f9bf70aa8f5a689ef93c23d
member-observations.ts https://github.com/simstudioai/sim/pull/8334/files#diff-d38c4ec5ee0b5affe0223c865a8c4e1d1ee9673238bb0efc831542f2cd0388ea
member-sync-engine-content-credential.test.ts https://github.com/simstudioai/sim/pull/8334/files#diff-40f1876e4f1f511d3de4d450ad9f97ffb6d2b500a4017fab27b899af27484d57
member-sync-engine.ts https://github.com/simstudioai/sim/pull/8334/files#diff-f5784431ef7cb3961aec5ea7513b6af82c03f47030b45533077f1be9233550d0
reconciliation-window.test-helpers.ts https://github.com/simstudioai/sim/pull/8334/files#diff-282d1098b5c70b8070973c142c45337e07a924f7968c290f485228dba6fbbf8c
reconciliation-window.ts https://github.com/simstudioai/sim/pull/8334/files#diff-a397298150e20079f419649d2cd5491b535ffde39ab744149eea033f5e8455e4
sync-content-pass.integration.ts https://github.com/simstudioai/sim/pull/8334/files#diff-fa75e5999c2488ccdf3c7523b17b435e7ee27fea3954a774ff1e37ebe2b30341
sync-content-pass.test.ts https://github.com/simstudioai/sim/pull/8334/files#diff-8d35d55800e2821b9e7cd19c76e2db80b43c20e2e53ab4485115f2abfd24d5d7
sync-content-pass.ts https://github.com/simstudioai/sim/pull/8334/files#diff-b6bd8cd1ab36d6b8e1b29f63847ffc4e4ee912f70e19de773896d753cc73d866
sync-engine.test.ts https://github.com/simstudioai/sim/pull/8334/files#diff-021afebf7e100833ecdc940e307263436964ce85ef3dfd40fc90307a1d115534
sync-primitives.ts https://github.com/simstudioai/sim/pull/8334/files#diff-f03702ab1eda626483984539879fd0475efc6ee2b6bf9c1df86cca4ead80a1fb
0388_document_connector_reconciliation_v2_index.sql https://github.com/simstudioai/sim/pull/8334/files#diff-b0878c70404286df77ededa5fae92b0bed27156d0bd29ab6b468b705cf609528
0388_snapshot.json https://github.com/simstudioai/sim/pull/8334/files#diff-14737b38db6269b034b7931dc312c28ff9959c42532084edf0579cef90ad95db
_journal.json https://github.com/simstudioai/sim/pull/8334/files#diff-37150cc65ad16ee6fbc5fa318fc096be7730e16d63eaf863e3df5521b7030649
schema.ts https://github.com/simstudioai/sim/pull/8334/files#diff-9a959e2ce3cb4c86957bbae021d06eae364f7b0cb18964f5873bab53220af928
apps/sim/lib/knowledge/__integration__/connector-lease-pages.integration.tshttps://github.com/simstudioai/sim/pull/8334/files#diff-5fa5ca3a11a947dcad4f56d576ff1a199a9fde1a3d0d7bda3b10abbb38787ae3
View file https://github.com/simstudioai/sim/blob/9b2d1d8152650650fe1f8e754b7e1eb2015224c0/apps/sim/lib/knowledge/__integration__/connector-lease-pages.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8334/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8334/files#diff-5fa5ca3a11a947dcad4f56d576ff1a199a9fde1a3d0d7bda3b10abbb38787ae3
https://github.com/simstudioai/sim/pull/8334/files#diff-5fa5ca3a11a947dcad4f56d576ff1a199a9fde1a3d0d7bda3b10abbb38787ae3
https://github.com/simstudioai/sim/pull/8334/files#diff-5fa5ca3a11a947dcad4f56d576ff1a199a9fde1a3d0d7bda3b10abbb38787ae3
https://github.com/simstudioai/sim/pull/8334/files#diff-5fa5ca3a11a947dcad4f56d576ff1a199a9fde1a3d0d7bda3b10abbb38787ae3
apps/sim/lib/knowledge/__integration__/listing-continuation.integration.tshttps://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
View file https://github.com/simstudioai/sim/blob/9b2d1d8152650650fe1f8e754b7e1eb2015224c0/apps/sim/lib/knowledge/__integration__/listing-continuation.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8334/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
https://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
https://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
https://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
https://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
https://github.com/simstudioai/sim/pull/8334/files#diff-e0cfe9e757a63c3c668fa797a9a26e31db2e1773cbbedf4f4ee7066714447105
apps/sim/lib/knowledge/__integration__/scale.integration.tshttps://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
View file https://github.com/simstudioai/sim/blob/9b2d1d8152650650fe1f8e754b7e1eb2015224c0/apps/sim/lib/knowledge/__integration__/scale.integration.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8334/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
https://github.com/simstudioai/sim/pull/8334/files#diff-3ded7c9f612bb44648454405acfbb45c1e52377d444f37dfb98b06896ba4d0cb
apps/sim/lib/knowledge/connectors/member-observations.test.tshttps://github.com/simstudioai/sim/pull/8334/files#diff-862878ee240c7c81a2b4c5fe75155383f946ddb11f9bf70aa8f5a689ef93c23d
View file https://github.com/simstudioai/sim/blob/9b2d1d8152650650fe1f8e754b7e1eb2015224c0/apps/sim/lib/knowledge/connectors/member-observations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8334/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8334/files#diff-862878ee240c7c81a2b4c5fe75155383f946ddb11f9bf70aa8f5a689ef93c23d
https://github.com/simstudioai/sim/pull/8334/files#diff-862878ee240c7c81a2b4c5fe75155383f946ddb11f9bf70aa8f5a689ef93c23d
https://github.com/simstudioai/sim/pull/8334/files#diff-862878ee240c7c81a2b4c5fe75155383f946ddb11f9bf70aa8f5a689ef93c23d
https://github.com/simstudioai/sim/pull/8334/files#diff-862878ee240c7c81a2b4c5fe75155383f946ddb11f9bf70aa8f5a689ef93c23d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8334/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8334/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.