René's URL Explorer Experiment


Title: fix(files): keep the shared markdown parser editor unmounted by waleedlatif1 · Pull Request #8308 · simstudioai/sim · GitHub

Open Graph Title: fix(files): keep the shared markdown parser editor unmounted by waleedlatif1 · Pull Request #8308 · simstudioai/sim

X Title: fix(files): keep the shared markdown parser editor unmounted by waleedlatif1 · Pull Request #8308 · simstudioai/sim

Description: Summary The shared markdown parse/serialize editor in markdown-parse.ts was mounted, so every serialize rendered the doc into a hidden DOM view. ProseMirror's DOMObserver schedules a 20ms flush timer it never tracks, so nothing can cancel it; in jsdom suites it fired after teardown and failed CI with ReferenceError: document is not defined in whichever test file happened to finish first Build that editor unmounted (element: null), with no view, observer, or timers. TipTap only installs extension plugins on mount, so they're installed via state.reconfigure the same way, keeping normalization (e.g. the trailing paragraph) identical to the live editor serializeDocToMarkdown sets content with emitUpdate: false: nothing listens to the scratchpad, and the update made TipTap's core Delete extension defer a timer on every serialize markdown-paste.test.ts leaked a mounted editor: its single editor slot was overwritten when one test mounted twice, so the first was never destroyed and its observer timer could fire after teardown. mount() now registers every editor and afterEach destroys them all (an audit of every file-viewer test found no other leak) Drop a dead cleanups hook from block-image-paragraph.test.ts that nothing pushes into Type of Change Bug fix Testing Reproduced deterministically in a scratch jsdom test (serialize, drop document, wait): old code throws the exact CI error, new code throws nothing Serialization parity: all 705 .md/.mdx files in the repo serialize byte-identically through a mounted editor vs the new unmounted one Regression test in markdown-parse.test.ts: fresh module under fake timers, serialize, assert no pending timers. Red in whole-file runs with the editor mounted again, with the update emitted, and on the pre-PR file; green with the fix rich-markdown-editor + collab-doc suites pass (771 tests); type-check, lint, check:audits (49 audits), docs-manifest:check pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing (new tests pass the test-audit authoring gate) No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The shared markdown parse/serialize editor in markdown-parse.ts was mounted, so every serialize rendered the doc into a hidden DOM view. ProseMirror's DOMObserver schedules a 20ms flus...

X Description: Summary The shared markdown parse/serialize editor in markdown-parse.ts was mounted, so every serialize rendered the doc into a hidden DOM view. ProseMirror's DOMObserver schedules a 20ms ...

Opengraph URL: https://github.com/simstudioai/sim/pull/8308

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6169cf92-c288-889f-dc65-e8de6da4fd19
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9698:2B9F:37EFA4:4EA4D4:6AFB5736
html-safe-nonce6afc2781447e082684a60af7a940d7c7d0bc806d53c979c960ccad78d7fbf5cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Njk4OjJCOUY6MzdFRkE0OjRFQTRENDo2QUZCNTczNiIsInZpc2l0b3JfaWQiOiI4MzU0ODYzMTUyNDE5Nzg4NTk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac94d4b324038081981c04eda7dc25287b30538448b0a57775fdb3b88d437e9b27
hovercard-subject-tagpull_request:4642405086
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8308/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The shared markdown parse/serialize editor in markdown-parse.ts was mounted, so every serialize rendered the doc into a hidden DOM view. ProseMirror's DOMObserver schedules a 20ms flus...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/8308/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8308%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F8308%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/8308/files
Reloadhttps://github.com/simstudioai/sim/pull/8308/files
Reloadhttps://github.com/simstudioai/sim/pull/8308/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/markdown-parser-headlesshttps://github.com/simstudioai/sim/tree/fix/markdown-parser-headless
Conversation 11 https://github.com/simstudioai/sim/pull/8308
Commits 3 https://github.com/simstudioai/sim/pull/8308/commits
Checks 32 https://github.com/simstudioai/sim/pull/8308/checks
Files changed https://github.com/simstudioai/sim/pull/8308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8308/files
fix(files): keep the shared markdown parser editor unmounted https://github.com/simstudioai/sim/pull/8308/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/8308/files
7ea2fa8 fix(files): keep the shared markdown parser editor unmounted waleedlatif1 Sep 25, 2026 https://github.com/simstudioai/sim/pull/8308/commits/7ea2fa8bcf6ab1f0b3a7a80cd3dd94ea1e988d68
0eae82e fix(files): serialize without deferred work and guard it with a regre… waleedlatif1 Sep 25, 2026 https://github.com/simstudioai/sim/pull/8308/commits/0eae82e9b6f5e4b95b813f2d1225d293c88792a8
4e31bbc fix(files): destroy every editor a markdown paste test mounts waleedlatif1 Sep 25, 2026 https://github.com/simstudioai/sim/pull/8308/commits/4e31bbc44822ac5136f072aadf5ef12a8b259dcf
Clear filters https://github.com/simstudioai/sim/pull/8308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8308/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/8308/files
block-image-paragraph.test.ts https://github.com/simstudioai/sim/pull/8308/files#diff-7e88ae9a1a62c581fa10ca836e9c55c9c993e072ab64a502b15a9743796f42d7
markdown-parse.test.ts https://github.com/simstudioai/sim/pull/8308/files#diff-91a315ff3c7110b4dd98108374ddfd3c12301f537e43f4da8a7b8617f932df98
markdown-parse.ts https://github.com/simstudioai/sim/pull/8308/files#diff-9f4d1ed8214db9dceefdbf4fe314a6cc2a89000b2a933964baff741f16f5222e
markdown-paste.test.ts https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
...kspaceId]/files/components/file-viewer/rich-markdown-editor/block-image-paragraph.test.tshttps://github.com/simstudioai/sim/pull/8308/files#diff-7e88ae9a1a62c581fa10ca836e9c55c9c993e072ab64a502b15a9743796f42d7
View file https://github.com/simstudioai/sim/blob/4e31bbc44822ac5136f072aadf5ef12a8b259dcf/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/block-image-paragraph.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8308/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8308/files#diff-7e88ae9a1a62c581fa10ca836e9c55c9c993e072ab64a502b15a9743796f42d7
https://github.com/simstudioai/sim/pull/8308/files#diff-7e88ae9a1a62c581fa10ca836e9c55c9c993e072ab64a502b15a9743796f42d7
...ce/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-parse.test.tshttps://github.com/simstudioai/sim/pull/8308/files#diff-91a315ff3c7110b4dd98108374ddfd3c12301f537e43f4da8a7b8617f932df98
View file https://github.com/simstudioai/sim/blob/4e31bbc44822ac5136f072aadf5ef12a8b259dcf/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/markdown-parse.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8308/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8308/files#diff-91a315ff3c7110b4dd98108374ddfd3c12301f537e43f4da8a7b8617f932df98
https://github.com/simstudioai/sim/pull/8308/files#diff-91a315ff3c7110b4dd98108374ddfd3c12301f537e43f4da8a7b8617f932df98
https://github.com/simstudioai/sim/pull/8308/files#diff-91a315ff3c7110b4dd98108374ddfd3c12301f537e43f4da8a7b8617f932df98
...rkspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-parse.tshttps://github.com/simstudioai/sim/pull/8308/files#diff-9f4d1ed8214db9dceefdbf4fe314a6cc2a89000b2a933964baff741f16f5222e
View file https://github.com/simstudioai/sim/blob/4e31bbc44822ac5136f072aadf5ef12a8b259dcf/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/markdown-parse.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8308/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8308/files#diff-9f4d1ed8214db9dceefdbf4fe314a6cc2a89000b2a933964baff741f16f5222e
Please reload this pagehttps://github.com/simstudioai/sim/pull/8308/files
https://github.com/simstudioai/sim/pull/8308/files#diff-9f4d1ed8214db9dceefdbf4fe314a6cc2a89000b2a933964baff741f16f5222e
https://github.com/simstudioai/sim/pull/8308/files#diff-9f4d1ed8214db9dceefdbf4fe314a6cc2a89000b2a933964baff741f16f5222e
https://github.com/simstudioai/sim/pull/8308/files#diff-9f4d1ed8214db9dceefdbf4fe314a6cc2a89000b2a933964baff741f16f5222e
...ce/[workspaceId]/files/components/file-viewer/rich-markdown-editor/markdown-paste.test.tshttps://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
View file https://github.com/simstudioai/sim/blob/4e31bbc44822ac5136f072aadf5ef12a8b259dcf/apps/sim/app/workspace/%5BworkspaceId%5D/files/components/file-viewer/rich-markdown-editor/markdown-paste.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/8308/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
https://github.com/simstudioai/sim/pull/8308/files#diff-6dd1bb954441318158b3f450a775b2b0d3b7ad4f28660ce672ba5c8ce6d35e6d
Please reload this pagehttps://github.com/simstudioai/sim/pull/8308/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.