Title: chore(tests): remove low-signal tests and consolidate the testing setup by waleedlatif1 · Pull Request #8295 · simstudioai/sim · GitHub
Open Graph Title: chore(tests): remove low-signal tests and consolidate the testing setup by waleedlatif1 · Pull Request #8295 · simstudioai/sim
X Title: chore(tests): remove low-signal tests and consolidate the testing setup by waleedlatif1 · Pull Request #8295 · simstudioai/sim
Description: Summary Delete low-signal unit tests across the monorepo: config/registry restatements, mock-call choreography, per-route copies of route-builder behavior, schema accept/reject checks, render/class/query-key tests, tests of mocks and factories, and near-duplicate variants. Kept: security denials, billing math, executor semantics, real parsers, cross-process wire contracts, and demonstrated regressions apps/sim: 4,027 → 3,271 test files, 60,643 → 34,286 tests. Repo-wide: ~438k lines of tests removed Remove production exports whose only callers were deleted tests (validateStringParam, validateRequiredFields, resubscribe, resolveSelectExportValue, getSlackV2ToolAccess, unused provider/model helpers, USAGE_PROVIDER_ICON_IDS) Remove ~130 orphaned @sim/testing exports (unused assertions, builders, factories, mock helpers, setup/) Consolidate the real-database layer: *.postgres.test.ts → *.integration.ts, one TEST_DATABASE_URL/TEST_REDIS_URL contract enforced by packages/db/testing/test-infrastructure.ts, CI discovers suites by glob instead of a hand-maintained file list, and every integration run uploads a JSON report. *.live.test.ts holds opt-in provider/sandbox suites (never in CI); 7 integration suites that already failed on a fresh DB are quarantined explicitly in apps/sim/vitest.config.ts Upgrade Vitest 4.1 → 5.0.1 (5.0.2 is inside the minimumReleaseAge window); publish workflows run tests on Node 22 and keep a Node 20 bundle smoke Drop the 3-way apps/sim test sharding — the suite runs in the Lint and Test job again Drop ~2,960 redundant @vitest-environment node docblocks (node is the default) and ~2,260 vi.clearAllMocks() in beforeEach (Vitest 5 clears mocks before every test) Add testing rules to AGENTS.md/CLAUDE.md: never write unit tests after the code, prefer E2E tests that end with a verifiable artifact, write failure modes down first when testing in isolation Add a test-audit skill (authoring gate, junk patterns, retention bar, audit/campaign workflow), rewrite .claude/rules/sim-testing.md around test layers and naming, and gate new tests in /ship and /cleanup Type of Change Other: test cleanup, tooling, and docs Testing bun run test (every workspace + scripts + setup): all green except 2 pre-existing background/knowledge-processing.test.ts cases that fail only when the checkout path contains /private Integration layer run against local Docker Postgres 17/16 + Redis in both push and migrate provisioning: every file that ran in CI before still passes; SCIM HTTP e2e 17/17 bunx turbo run type-check, bun run lint, bun run check:audits (49), docs-manifest:check, block registry, check:migrations all pass Greptile will likely refuse this PR for file count; the diff is almost entirely test deletions. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Delete low-signal unit tests across the monorepo: config/registry restatements, mock-call choreography, per-route copies of route-builder behavior, schema accept/reject checks, render/clas...
X Description: Summary Delete low-signal unit tests across the monorepo: config/registry restatements, mock-call choreography, per-route copies of route-builder behavior, schema accept/reject checks, render/clas...
Opengraph URL: https://github.com/simstudioai/sim/pull/8295
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a72271ee-bcab-b38f-d9a6-bac14cf60a37 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0DE:36F372:168F31:1F9C07:6AFB7831 |
| html-safe-nonce | 2387c7a8416f87eed9f90dd43bd0a897beed816a0fb83b3037c4d225444a85ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMERFOjM2RjM3MjoxNjhGMzE6MUY5QzA3OjZBRkI3ODMxIiwidmlzaXRvcl9pZCI6IjE3OTc3ODI3OTk3NTk2NjkyOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0cfb95707f1a709ee2a266ad248222d5ef44c0d98ac899d73c3caa6a8440e4cd |
| hovercard-subject-tag | pull_request:4637514971 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/8295/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Delete low-signal unit tests across the monorepo: config/registry restatements, mock-call choreography, per-route copies of route-builder behavior, schema accept/reject checks, render/clas... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width